openstack
/
neutron
Code Issues Proposed changes
neutron/neutron/tests/unit
History
Yuki Nishiwaki b803195a99 Dont use dict.get() to know certain key is in dict 
In CommonAgentLoop class, there is logic to detect tap device is changed
locally or not by comparing timestamp with previous.
Sometimes timestamp value could be None depending on the timing (see bug/1781129)

But current _get_devices_locally_modified logic can not detect local
change from None to something because _get_devices_locally_modified
function don't always compare if previous timestamp value was None.

In order not to miss updated device always, better not to use dict.get() to
know previous iteration have timestamp or not.

Change-Id: Ib0361ad5c281f88558e8e048cfec588b9f9b1de4
Closes-Bug: #1781129
 		2018-07-25 16:08:42 +09:00
..
agent Merge "Pass network's dns_domain to dnsmasq conf" 2018-07-02 16:53:43 +00:00
api Merge "Fix lack of routes for neighbour IPv4 subnets" 2018-05-21 22:29:15 +00:00
cmd Fix exception in neutron-sanity-check 2018-06-13 18:21:14 +00:00
common Switch to oslo_messaging.ConfFixture.transport_url 2018-06-05 12:33:55 +10:00
conf/agent Agent common config 2017-03-15 09:52:18 -06:00
core_extensions use qos constants from neutron-lib 2017-10-26 19:57:19 +00:00
db Merge "Allow sub-resources to have standard attributes" 2018-07-10 04:28:08 +00:00
debug Change ip_lib network namespace code to use pyroute2 2017-10-04 21:09:28 +00:00
extensions use db utils from lib 2018-07-02 08:24:36 -06:00
hacking Use flake8-import-order plugin 2017-07-05 03:15:27 +00:00
ipam Removed unnecessary setUp calls in tests 2017-07-31 17:16:01 +02:00
notifiers Fix W503 pep8 warnings 2018-04-17 14:22:58 +00:00
objects objects: don't refetch a non-list object field if it's None 2018-06-25 15:23:10 +07:00
pecan_wsgi Removing deprecated module neutron.api.versions 2018-03-28 14:15:50 +07:00
plugins Dont use dict.get() to know certain key is in dict 2018-07-25 16:08:42 +09:00
privileged python3: fix netlink_lib delete_entries 2018-06-29 00:30:19 +02:00
quota CountableResource: try count/get functions for all plugins 2017-09-08 10:50:12 -07:00
scheduler Fix DVR scheduling checks wrong profile for host 2018-06-13 20:39:02 +08:00
services Introduce l3_logging extension base 2018-06-24 06:05:24 +00:00
tests Replaced assertTrue(False) with fail() 2017-06-22 19:31:00 +02:00
__init__.py Don't set use_stderr to False for tests 2017-04-15 01:41:29 +00:00
_test_extension_portbindings.py use plugin constants from neutron-lib 2017-10-16 09:32:20 -06:00
dummy_plugin.py use neutron-lib servicetype api def 2018-03-27 14:32:44 -06:00
extension_stubs.py Consume ServicePluginBase from neutron-lib 2017-03-17 12:06:57 -06:00
test_auth.py Fix context deprecation warnings 2018-02-13 15:02:49 -05:00
test_manager.py use plugin constants from neutron-lib 2017-10-16 09:32:20 -06:00
test_neutron_plugin_base_v2.py Add unit test to validate non DB base core plugin can be loaded 2017-11-15 21:21:35 +00:00
test_opts.py Fix the sriov agent config group name 2016-05-05 16:16:08 +08:00
test_policy.py consume neutron-lib resources attr map 2018-03-09 13:37:28 -07:00
test_service.py use callback payloads for _SPAWN events 2017-12-21 11:03:36 -07:00
test_worker.py Move AgentStatusCheckWorker to PeriodicWorker 2016-11-17 15:31:19 -08:00
test_wsgi.py [Unit tests] Skip TestWSGIServer with IPv6 if no IPv6 enabled 2018-06-28 12:42:48 +02:00
testlib_api.py Remove usage of TestCase.skip() method 2018-03-21 22:14:53 +01:00