openstack/nova
Code Issues Proposed changes

Default to py3 for the pep8 tox env because it's stricter

Browse Source 
We recently fixed a couple of pep8 failures under py3 [0] which got
through because we're not gating pep8 on py3. This changes the python
version for the pep8 tox env to python3 because the py3 checks are
stricter. This updates the fast8 tox env as well.

[0] https://review.openstack.org/#/c/557633

Change-Id: I540377606a8224ba569b8c145773e7d057575bd8
This commit is contained in:
melanie witt 2018-04-03 23:12:52 +00:00
parent 21eec0c313
commit ef7e2a1988
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tox.ini
View File

@ -45,6 +45,8 @@ commands =
env TEST_OSPROFILER=1 stestr run --combine --no-discover 'nova.tests.unit.test_profiler'
[testenv:pep8]
# Let's gate pep8 under py3 by default because the py3 checks are stricter.
basepython = python3
deps = {[testenv]deps}
commands =
bash tools/flake8wrap.sh {posargs}
@ -54,6 +56,8 @@ commands =
bash -c '! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2>&1 > /dev/null | grep -B1 -v ^python'
[testenv:fast8]
# Let's run fast8 under py3 by default because the py3 checks are stricter.
basepython = python3
# This is a subset of the full pep8 check which
# only runs flake8 on the changes made since
# HEAD-1. For a full flake8 run including checking