openstack
/
nova
Code Issues Proposed changes
nova/nova/tests/functional/regressions
History
Matt Riedemann 581df2c986 Add regression recreate test for bug 1830747 
Before change I4244f7dd8fe74565180f73684678027067b4506e in Stein, when
a cold migration would reschedule to conductor it would not send the
RequestSpec, only the filter_properties. The filter_properties contain
a primitive version of the instance group information from the RequestSpec
for things like the group members, hosts and policies, but not the uuid.
When conductor is trying to reschedule the cold migration without a
RequestSpec, it builds a RequestSpec from the components it has, like the
filter_properties. This results in a RequestSpec with an instance_group
field set but with no uuid field in the RequestSpec.instance_group.
That RequestSpec gets persisted and then because of change
Ie70c77db753711e1449e99534d3b83669871943f, later attempts to load the
RequestSpec from the database will fail because of the missing
RequestSpec.instance_group.uuid.

The test added here recreates the pre-Stein scenario which could still
be a problem (on master) for any corrupted RequestSpecs for older
instances.

NOTE(mriedem): In this version we have to request a specific port
to avoid a NetworkAmbiguous failure when creating the server.

Change-Id: I05700c97f756edb7470be7273d5c9c3d76d63e29
Related-Bug: #1830747
(cherry picked from commit c96c7c5e13)
(cherry picked from commit 8478a75480)
(cherry picked from commit a0a187c9bb)
 		2019-06-03 15:37:59 -04:00
..
README.rst add a place for functional test to block specific regressions 2016-02-24 18:14:27 +00:00
__init__.py add a place for functional test to block specific regressions 2016-02-24 18:14:27 +00:00
test_bug_1404867.py fixtures: Track volume attachments within CinderFixtureNewAttachFlow 2018-10-22 15:51:59 -04:00
test_bug_1522536.py replace chance with filter scheduler in func tests 2017-08-16 14:42:51 +00:00
test_bug_1541691.py Remove unused conf 2016-09-02 09:02:23 +08:00
test_bug_1548980.py replace chance with filter scheduler in func tests 2017-08-16 14:42:51 +00:00
test_bug_1552888.py Trivial-Fix: Fix typos 2016-06-13 06:41:08 +00:00
test_bug_1554631.py Catching OverQuota Exception 2017-05-03 19:00:34 +00:00
test_bug_1558866.py conf: Remove deprecated 'null_kernel' opt 2017-10-21 00:23:51 +00:00
test_bug_1568208.py Fix generation of Guru Meditation Report 2016-04-13 17:00:32 +03:00
test_bug_1595962.py Remove unnecessary self.flags and ConfPatcher 2017-11-27 15:49:10 +00:00
test_bug_1620248.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1627838.py Stop overwriting thread local context in ClientRouter 2016-09-26 20:49:22 +00:00
test_bug_1669054.py Do not persist RequestSpec.ignore_hosts 2019-04-02 11:07:52 -04:00
test_bug_1670627.py Clean up ports and volumes when deleting ERROR instance 2018-02-20 14:10:26 -05:00
test_bug_1671648.py Make conductor pass and use host_lists 2017-12-21 17:02:35 -05:00
test_bug_1675570.py fixtures: Track volume attachments within CinderFixtureNewAttachFlow 2018-10-22 15:51:59 -04:00
test_bug_1678326.py Commit usage decrement after destroying instance 2017-04-05 15:19:15 -04:00
test_bug_1679750.py Delete allocations from API if nova-compute is down 2018-04-20 14:57:34 -04:00
test_bug_1682693.py replace chance with filter scheduler in func tests 2017-08-16 14:42:51 +00:00
test_bug_1689692.py Clean up ports and volumes when deleting ERROR instance 2018-02-20 14:10:26 -05:00
test_bug_1702454.py Functional regression test for evacuate with a target 2017-10-29 13:49:06 -04:00
test_bug_1713783.py Set server status to ERROR if rebuild failed 2018-01-23 11:39:45 -05:00
test_bug_1718455.py Ensure instance can migrate when launched concurrently 2017-09-28 11:40:54 -04:00
test_bug_1718512.py Don't persist RequestSpec.retry 2018-04-12 11:27:49 -04:00
test_bug_1719730.py Set group_members when converting to legacy request spec 2017-09-27 20:52:19 +00:00
test_bug_1732947.py Implement new attach Cinder flow 2017-12-07 10:29:15 -05:00
test_bug_1735407.py Add late server group policy check to rebuild 2018-02-06 13:54:12 +01:00
test_bug_1741125.py Fix TypeError in prep_resize allocation cleanup 2018-07-11 08:59:20 -04:00
test_bug_1741307.py Handle no allocations during migrate 2018-01-04 14:18:50 -05:00
test_bug_1746483.py Handle volume-backed instances in IsolatedHostsFilter 2018-02-12 14:45:39 -05:00
test_bug_1746509.py Move _make_instance_list call outside of DB transaction context 2018-03-23 20:01:15 +00:00
test_bug_1764883.py compute: Ensure pre-migrating instances are destroyed during init_host 2018-11-30 16:07:22 +00:00
test_bug_1780373.py Fix server_group_members quota check 2018-07-11 15:04:34 -04:00
test_bug_1784353.py conductor: Recreate volume attachments during a reschedule 2018-10-22 16:08:10 -04:00
test_bug_1794996.py Fix InstanceNotFound during _destroy_evacuated_instances 2018-12-06 18:58:24 -05:00
test_bug_1797580.py Don't persist RequestSpec.requested_destination 2018-12-14 02:57:04 +00:00
test_bug_1806064.py Create BDMs/tags in cell with instance when over-quota 2018-12-11 14:20:35 +00:00
test_bug_1806515.py Handle tags in _bury_in_cell0 2018-12-12 17:20:44 -05:00
test_bug_1830747.py Add regression recreate test for bug 1830747 2019-06-03 15:37:59 -04:00

README.rst

Tests for Specific Regressions

When we have a bug reported by end users that we can write a full stack reproduce on, we should. And we should keep a regression test for that bug in our tree. It can be deleted at some future date if needed, but largely should not be changed.

Writing Regression Tests

  • These should be full stack tests which inherit from nova.test.TestCase directly. (This is to prevent coupling with other tests).
  • They should setup a full stack cloud in their setUp via fixtures
  • They should each live in a file which is named test_bug######.py

Writing Tests Before the Bug is Fixed

TODO describe writing and landing tests before the bug is fixed as a reproduce.