openstack
/
nova
Code Issues Proposed changes
nova/nova
History
Stephen Finucane 99cf5292c7 objects: Fix VIFMigrateData.supports_os_vif_delegation setter 
We're using a 'profile' getter/setter in the 'VIFMigrateData' object to
ensure we transform the JSON encoded string we store in the database to
an actual dictionary on load and vice versa on save. However, because
the getter is returning a new object (constructed from 'json.loads')
rather than a reference to the original data (which is a string),
modifying this object doesn't actually change the underlying data in the
object. We were relying on this broken behavior to set the
'supports_os_vif_delegation' attribute of the 'VIFMigrateData' object
and trigger the delegated port creation introduced in change
I11fb5d3ada7f27b39c183157ea73c8b72b4e672e, which means that code isn't
actually doing anything yet. Resolve this.

Change-Id: I362deb1088c88cdcd8219922da9dc9a01b10a940
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-Bug: #1734320
Related-Bug: #1815989
 		2021-06-18 18:14:39 +01:00
..
accelerator Remove six.text_type (1/2) 2020-12-13 11:25:31 +00:00
api Merge "Remove references to 'inst_type'" 2021-06-15 21:47:10 +00:00
cmd Merge "Replace getargspec with getfullargspec" 2021-06-01 19:33:28 +00:00
compute Merge "Remove (almost) all references to 'instance_type'" 2021-06-13 05:57:49 +00:00
conductor Remove (almost) all references to 'instance_type' 2021-03-29 12:24:15 +01:00
conf Use the new type HostDomainOpt. 2021-05-19 10:29:56 +02:00
console Reject open redirection in the console proxy 2021-05-14 17:26:00 +02:00
db db: Remove dead code 2021-06-16 10:10:27 +01:00
hacking Add a hacking rule for assert_has_calls 2020-09-28 23:08:15 +09:00
image glance: Remove [glance]/allowed_direct_url_schemes 2021-01-28 12:46:57 +00:00
keymgr
…
locale Imported Translations from Zanata 2020-04-26 07:51:21 +00:00
network Merge "Honor [neutron]http_retries in the manual client" 2021-06-02 15:33:10 +00:00
notifications Remove (almost) all references to 'instance_type' 2021-03-29 12:24:15 +01:00
objects objects: Fix VIFMigrateData.supports_os_vif_delegation setter 2021-06-18 18:14:39 +01:00
pci mypy: Add type annotations to 'nova.pci' 2021-04-26 18:06:21 +01:00
policies virt: Remove 'reset_network' API 2020-11-23 15:55:50 +00:00
privsep Retry lvm volume and volume group query 2021-06-15 12:39:26 +02:00
scheduler Merge "Remove (almost) all references to 'instance_type'" 2021-06-13 05:57:49 +00:00
servicegroup Remove six.binary_type/integer_types/string_types 2020-12-13 11:25:14 +00:00
storage Stop leaking ceph df cmd in RBD utils 2021-05-11 17:28:56 +02:00
tests objects: Fix VIFMigrateData.supports_os_vif_delegation setter 2021-06-18 18:14:39 +01:00
virt Merge "libvirt: Set driver_iommu when attaching virtio devices to SEV instance" 2021-06-16 00:53:08 +00:00
volume Remove six.text_type (1/2) 2020-12-13 11:25:31 +00:00
__init__.py
…
availability_zones.py Remove six.PY2 and six.PY3 2020-08-15 07:45:23 +00:00
baserpc.py
…
block_device.py virt: Remove 'is_xenapi' helper 2020-09-11 14:09:06 +01:00
cache_utils.py trivial: Remove unused 'cache_utils' APIs 2020-02-05 17:20:28 +00:00
config.py Fix config option default value for sample config file 2020-11-25 00:05:08 +00:00
context.py Remove six.binary_type/integer_types/string_types 2020-12-13 11:25:14 +00:00
crypto.py Replace md5 for fips 2021-02-25 16:01:43 -05:00
debugger.py trivial: Remove remaining '_LW' instances 2020-05-18 17:00:41 +01:00
exception.py api: Block unsupported actions with vDPA 2021-03-16 20:39:27 +00:00
exception_wrapper.py rpc: Rework 'get_notifier', 'wrap_exception' 2021-03-01 11:06:48 +00:00
filters.py trivial: Remove remaining '_LI' instances 2020-05-18 17:00:57 +01:00
i18n.py trivial: Remove remaining '_LI' instances 2020-05-18 17:00:57 +01:00
loadables.py trivial: Remove dead code 2019-12-12 10:55:02 +00:00
manager.py Remove six.add_metaclass 2020-08-15 07:45:39 +00:00
middleware.py Allow X-OpenStack-Nova-API-Version header in CORS 2021-06-15 07:35:36 -04:00
monkey_patch.py Correctly disable greendns 2020-09-11 12:42:04 -04:00
policy.py Reuse code from oslo lib for JSON policy migration 2021-01-14 22:41:33 +00:00
profiler.py
…
quota.py Make quotas respect instance_list_per_project_cells 2020-05-15 17:21:29 -04:00
rpc.py rpc: Rework 'get_notifier', 'wrap_exception' 2021-03-01 11:06:48 +00:00
safe_utils.py
…
service.py Restore retrying the RPC connection to conductor 2020-11-13 18:02:00 +01:00
service_auth.py
…
test.py Merge "Replace getargspec with getfullargspec" 2021-06-01 19:33:28 +00:00
utils.py Replace getargspec with getfullargspec 2021-05-12 10:50:52 +08:00
version.py Change API unexpected exception message 2021-02-17 21:30:07 +00:00
weights.py Remove six.add_metaclass 2020-08-15 07:45:39 +00:00
wsgi.py trivial: Remove remaining '_LI' instances 2020-05-18 17:00:57 +01:00