nova/nova/tests/unit
Michael Still f535e8bb99 First attempt at adding a privsep user to nova itself.
I don't particularly care about this use case (although the localfs
code should perhaps go away), but it was a nice contained example
of a privsep user which wasn't just calling a command line.

This patch also starts to layout what an API to the privsep'd code
might look like. For now its modelled on python's os module, because
that's where all the operations we perform are coming from.

The rootwrap configuration is cleaned up as we remove users.

Co-Authored-By: Tony Breeds <tony@bakeyournoodle.com>
Change-Id: I911cc51a226d6af29d63a7a2c69253de870073e9
2017-09-07 03:01:01 +10:00
..
api Merge "Add uuid to migration object and migrate-on-load" 2017-09-06 06:19:21 +00:00
api_samples_test_base
cells Merge "Handle uuids in os-hypervisors API" 2017-07-20 01:03:27 +00:00
cmd Require Placement 1.10 in nova-status upgrade check 2017-08-09 15:26:46 -04:00
compute Merge "Add uuid to migration object and migrate-on-load" 2017-09-06 06:19:21 +00:00
conductor Cleanup allocations on invalid dest node during live migration 2017-08-30 14:24:14 -04:00
console conf: remove *_topic config opts 2017-07-17 21:27:02 -07:00
consoleauth conf: remove *_topic config opts 2017-07-17 21:27:02 -07:00
db Merge "Add uuid online migration for migrations" 2017-09-06 06:40:14 +00:00
fake_loadables
image Add service_token for nova-glance interaction 2017-06-07 20:11:06 +00:00
keymgr
monkey_patch_example
network Merge "Remove plug_ovs_hybrid, unplug_ovs_hybrid" 2017-09-04 19:08:38 +00:00
notifications Merge "Use enum value instead of string service name" 2017-08-28 21:23:41 +00:00
objects Merge "Add uuid to migration object and migrate-on-load" 2017-09-06 06:19:21 +00:00
pci [Trivial] docstrings, typos, minor refactoring 2017-08-28 08:33:58 -05:00
scheduler Add missing unit tests for FilterScheduler._get_all_host_states 2017-08-23 11:51:13 -04:00
servicegroup iso8601.is8601.Utc No Longer Exists 2017-08-29 19:26:55 -04:00
ssl_cert Update SSL cert used in testing 2017-07-31 13:09:49 +10:00
virt First attempt at adding a privsep user to nova itself. 2017-09-07 03:01:01 +10:00
volume Translate the return value of attachment_create and _update 2017-07-25 21:16:03 -04:00
README.rst
__init__.py
cast_as_call.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
conf_fixture.py Set wsgi.keep_alive=False globally for tests 2017-07-14 11:42:38 -04:00
fake_block_device.py objects: Add attachment_id to BlockDeviceMapping 2017-03-16 16:35:01 -04:00
fake_build_request.py Support tag instances when boot(2/4) 2017-06-06 06:16:41 +00:00
fake_console_auth_token.py
fake_crypto.py
fake_diagnostics.py Added nova objects for intance diagnostics 2017-05-30 00:39:44 +04:00
fake_flavor.py
fake_hosts.py
fake_instance.py Add tags to instance.create Notification 2017-07-24 18:05:05 -04:00
fake_ldap.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
fake_network.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
fake_network_cache_model.py
fake_notifier.py Short circuit notifications when not enabled 2017-03-30 22:32:14 +00:00
fake_pci_device_pools.py
fake_policy.py Add policy granularity to the Flavors API 2017-07-19 15:56:47 -04:00
fake_processutils.py
fake_request_spec.py Image meta min_disk should be int in fake_request_spec 2017-04-06 23:12:46 -04:00
fake_server_actions.py
fake_volume.py Remove check_detach 2017-07-20 22:32:52 +02:00
fake_xvp_console_proxy.py tests: Replace use of CONF with monkey patching 2017-01-06 14:54:47 +00:00
image_fixtures.py
matchers.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
policy_fixture.py update policy UT fixtures 2017-08-09 10:00:27 -04:00
test_api_validation.py Stop using deprecated 'message' attribute in Exception 2017-07-10 09:55:06 +00:00
test_availability_zones.py Avoid lazy-load error when getting instance AZ 2017-05-25 15:46:22 -04:00
test_baserpc.py conf: remove *_topic config opts 2017-07-17 21:27:02 -07:00
test_block_device.py Remove unused validation code from block_device 2017-02-09 11:54:40 -08:00
test_cache.py Do not rely on dogpile internals for mocks 2017-05-30 11:57:54 +00:00
test_cinder.py Fix ksa mocking in test_cinderclient_unsupported_v1 2017-01-05 19:52:10 -05:00
test_conf.py conf: Remove 'virt' file 2016-12-21 16:45:08 +00:00
test_configdrive2.py Merge "Remove mox from nova/tests/unit/test_configdrive2.py" 2017-03-07 18:55:47 +00:00
test_context.py Add scatter gather utilities for cells 2017-06-29 19:41:20 +00:00
test_crypto.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:20 +05:30
test_exception.py Use enum value instead of string service name 2017-07-25 17:36:41 +02:00
test_fixtures.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_flavors.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_hacking.py remove hacking rule that enforces log translation 2017-03-16 09:56:21 -04:00
test_hooks.py
test_identity.py Be more tolerant of keystone catalog configuration 2017-06-05 14:56:44 +00:00
test_instance_types_extra_specs.py objects: Move 'arch' to 'fields.Architecture' 2016-11-25 16:19:41 +00:00
test_iptables_network.py Use more specific asserts in tests 2017-06-20 13:27:39 +02:00
test_ipv6.py
test_loadables.py
test_matchers.py Port test_matchers.TestDictMatches.test__str__ to Python 3 2016-12-20 11:11:44 +08:00
test_metadata.py Pre-load instance.device_metadata in InstanceMetadata 2017-07-06 19:10:59 -04:00
test_notifications.py Merge "Change default for [notifications]/default_publisher_id to $host" 2017-08-29 06:07:53 +00:00
test_notifier.py Replace messaging.get_transport with get_rpc_transport 2017-06-05 15:05:29 -04:00
test_nova_manage.py always show urls in list_cells 2017-07-31 15:56:26 -04:00
test_policy.py Merge "Add policy granularity to the Flavors API" 2017-08-10 11:47:12 +00:00
test_profiler.py Remove nova-cert 2017-04-27 22:28:01 -04:00
test_quota.py Make Quotas object favor the API database 2017-07-20 21:02:18 +00:00
test_rpc.py Replace messaging.get_transport with get_rpc_transport 2017-06-05 15:05:29 -04:00
test_safeutils.py Allow wrapping of closures 2017-07-20 10:07:52 +01:00
test_service.py Use enum value instead of string service name 2017-07-25 17:36:41 +02:00
test_service_auth.py Add service_token for nova-cinder interaction 2017-01-11 15:49:16 +00:00
test_test.py Improve assertJsonEqual error reporting 2017-07-26 10:22:53 +02:00
test_test_utils.py
test_utils.py First attempt at adding a privsep user to nova itself. 2017-09-07 03:01:01 +10:00
test_uuid_sentinels.py
test_versions.py
test_weights.py
test_wsgi.py Skip unit tests for SSL + py3 2017-03-02 14:30:16 +08:00
utils.py First attempt at adding a privsep user to nova itself. 2017-09-07 03:01:01 +10:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎