3426 Commits

Author SHA1 Message Date
Zuul
198980639c Merge "Use run_flow for failover functions in v2 control worker" 2020-10-30 19:26:42 +00:00
Zuul
7f26a5d5b4 Merge "Stop install unnecessary packages when run tox -ereleasenotes" 2020-10-29 10:59:24 +00:00
Zuul
009af5b0d8 Merge "Correct a typo in the document" 2020-10-29 09:09:50 +00:00
Ann Taraday
a9a817e428 Use run_flow for failover functions in v2 control worker
Align failover_amphora and failover_loadbalancer to use
run_flow.

Also avoid NoneType error in logging of create_health_monitor.

Change-Id: I1b4c18d3bec5ff62adf48d3d751d553eb359ccbe
2020-10-27 08:48:55 +00:00
OpenStack Proposal Bot
71440bdbdb Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ida42b240a1caec3805ce8148eb114a8c7d67db97
2020-10-15 08:19:40 +00:00
Zuul
8ea4d40281 Merge "Fix pool delete race on load balancer cascade delete" 2020-10-14 14:26:07 +00:00
Zuul
6c3fabc414 Merge "Remove unnecessary joinedload" 2020-10-14 12:07:32 +00:00
Carlos Goncalves
332791ee2b Fix pool delete race on load balancer cascade delete
In what appears to be a race condition, load balancer cascade delete can
fail while deleting numerous pools. The load balancer can still be
deleted with one or more follow-up cascade delete API calls but this is
suboptimal.

Per local testing, the ValueError exception is harmless so we can just
ignore it and continue the pool delete flow, with no orphan resources
left behind resulting from the exception skip.

Task: 41096
Story: 2008249

Change-Id: I9283d9804feb83a1d5a160da48da6146b19da88c
2020-10-13 13:37:27 +02:00
likui
ce6b563ee9 Stop install unnecessary packages when run tox -ereleasenotes
requirements.txt is unnecessary when run tox -e releasenotes,
releasenotes relative stuffs is in doc/requirements.txt

Change-Id: Ia6649ba95bdaa5d4c48f766bc8c1a87bab4f07b3
2020-10-12 13:52:58 +08:00
Michael Johnson
77dc23fc26 Fix load balancers with failed amphora failover
There was a bug in the load balancer failover code for the amphora
v1 driver where if there were multiple failed amphora, with session
persistence, could cause a load balancer failover to not complete.

Change-Id: Ia46a05ab9fdc97ed9be699e5b2ae90daca3ab9a2
Story: 2008099
Task: 40802
2020-10-07 16:02:19 -07:00
418ea0908c Add Python3 wallaby unit tests
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.

See also the PTI in governance [1].

[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html

Change-Id: I55420694117bcefae53e7d5f724b72a1b77938d1
2020-09-25 08:38:19 +00:00
3d0486a7f3 Update master for stable/victoria
Add file to the reno documentation build to show release notes for
stable/victoria.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.

Change-Id: Ibc14026c757b424c36dc2b1ed356c2e62e36499e
Sem-Ver: feature
2020-09-25 08:38:16 +00:00
Zuul
afe9ac3cfc Merge "Ensure install of diskimage-create.sh requirements" 2020-09-24 22:38:38 +00:00
Zuul
7152718493 Merge "Fix building Ubuntu 20.04 focal amphorae" 2020-09-24 18:11:58 +00:00
Carlos Goncalves
cb7d5133e7 Ensure install of diskimage-create.sh requirements
Change I612ea1c583090897bd44453b867d75929a01b7fc [1] removed
diskimage-builder from the root requirements.txt file. Devstack
deployments not setting LIBS_FROM_GIT+=diskimage-builder will not
install diskimage-builder. This means our diskimage-create.sh tool will
fail to build amphora images and abort the deployment.

[1] https://review.opendev.org/#/c/741960/

Change-Id: Id535d2d5ea6c23c9646c568a17d7695f82c0c1a9
2020-09-24 12:06:00 +02:00
Zuul
9d112ecec1 Merge "Ignore DELETED amphorae when performing certificate rotation" 2020-09-24 09:09:35 +00:00
Zuul
8000be85d4 Merge "Update protocol combination api-ref for PROXYV2" 2020-09-24 06:27:10 +00:00
Zuul
5ea6b11bc0 Merge "Add a requirements.txt check job" 2020-09-24 06:27:08 +00:00
Zuul
95597ae011 Merge "Fix image build when installing agent from package" 2020-09-24 01:48:54 +00:00
Lingxian Kong
f3eff29ce1 Ignore DELETED amphorae when performing certificate rotation
Deleted amphorae should not be included when housekeeping service is
performing certificate rotation. Otherwise, deleted amphorae will
become ERROR.

Story: #2007635
Task: #39681

Change-Id: Ie2c748ff69c8fd736e9c67d686068a33d803222e
2020-09-24 10:01:57 +12:00
Michael Johnson
70079d861d Fix building Ubuntu 20.04 focal amphorae
Ubuntu 20.04 is a "Tested Runtime" for the Victoria release[1].
This patch updated our diskimage-create script and elements to
support building a amphora image that uses Ubuntu 20.04 (focal).

[1] https://governance.openstack.org/tc/reference/runtimes/victoria.html

Change-Id: I6f53ea5d012ab64b985d981ecd1b1967e18e4e81
2020-09-23 14:14:25 -07:00
Zuul
b3982cd32f Merge "[Amphorav2] Healthmonitor operation minor fixes" 2020-09-23 14:58:51 +00:00
Zuul
81e677be40 Merge "Followup Remove haproxy_check_script for UDP-only" 2020-09-23 14:15:29 +00:00
Zuul
ba2b9482e7 Merge "Fix backend certificate file paths" 2020-09-22 17:54:23 +00:00
Zuul
d90452806a Merge "Fixes API list handling of unscoped tokens" 2020-09-22 09:28:12 +00:00
Zuul
498d103b97 Merge "Fix AttributeError on TLS-enabled pool provisioning" 2020-09-22 04:11:44 +00:00
Zuul
6d62b18d86 Merge "Fix the tls_cipher_prohibit_list release note" 2020-09-22 02:18:05 +00:00
Adam Harwell
7839ffd50d Followup Remove haproxy_check_script for UDP-only
The original patch: Ib2a80afb9223da2c0af6f6add250ffaaa20a316f

First attempt at fixing this issue assumed that the update function
would actually be called again after the initial LB creation, which it
is not. We should ensure that this is called when we do any UDP listener
creation, so the file can be removed if necessary.

Change-Id: Iec1ec7df420e3746b47004c8c0374d2d8274f45b
2020-09-21 16:13:37 -07:00
Michael Johnson
9453701fb4 Fixes API list handling of unscoped tokens
The API list methods were not handling unscoped tokens correctly.
If the API is using the admin_or_owner-policy.yaml policy override file,
and a user used an unscoped token, the API will list objects for all
projects. This patch corrects that issue.
If you are using the default policies, the API handles unscoped tokens
correctly.

Change-Id: I88e64fd5e8a4c709f735be85b85139dbb52e4acd
2020-09-21 16:12:17 -07:00
Michael Johnson
6a3a81b661 Add a requirements.txt check job
This patch adds a new tox environment and gate job that checks
requirements.txt for missing or extra requirements.

Change-Id: Id8c44821455644576cf055cccaa38c9ab2f49ec6
2020-09-18 15:13:12 -07:00
Zuul
e45ecc2111 Merge "Fix requirements.txt for Victoria" 2020-09-18 18:56:34 +00:00
Zuul
e3085940c6 Merge "Fix amphora failover when VRRP port is missing" 2020-09-18 15:01:20 +00:00
Michael Johnson
6c8c4f18fd Fix requirements.txt for Victoria
There are a couple of extra requirements no longer used and one
that was missing. This patch corrects that.

Change-Id: I5f45e6f0f15bca201c3ef63f2e42a183510f5977
2020-09-17 21:45:18 +00:00
Zuul
c3ad32d1a8 Merge "Switch grenade to run the octavia smoke tests" 2020-09-17 15:32:32 +00:00
Carlos Goncalves
89d5e9fcf6 Fix backend certificate file paths
In amphora-agent API version 1.0, backend certificate files are uploaded
to /var/lib/octavia/certs/<lb_id>/. However, the "server" line in the
rendered HAProxy configuration sets the certificate paths to
/var/lib/octavia/certs/<listener_id>/ (amphora-agent version 0.5).

This renders an invalid HAProxy configuration file and as result HAProxy
fails to reload with the new configuration, and members marked in ERROR
provisioning status.

Task: 40903
Story: 2008157

Change-Id: I7e2b12f19ee7b172464e809df6342ade1e87fb2e
2020-09-17 10:31:19 +00:00
Zuul
d03e165bf7 Merge "Drop diskimage-builder from root requirements.txt" 2020-09-17 08:18:20 +00:00
Zuul
b3a1d32b9f Merge "Add amphora delete support to amphorav2 driver" 2020-09-16 18:47:41 +00:00
Carlos Goncalves
a6a4001f57 Fix AttributeError on TLS-enabled pool provisioning
This patch fixes an hidden AttributeError exception in the HAProxy
driver when adding TLS-enabled pools to listeners.

Task: 40895
Story: 2008150

Change-Id: If165e995a8b61d8a8ed6bc0c4dd036af0c55c6e0
2020-09-16 13:37:38 +00:00
Zuul
19a8b743d8 Merge "Add a release note about HAProxy 2.0" 2020-09-16 12:24:27 +00:00
Michael Johnson
b627d7cf72 Remove unnecessary joinedload
This patch removes an unnecessary joinedload when looking up a
load balancer from an amphora ID. This should reduce the database
load when this method is called.

Change-Id: I04bb38c657c87ace941eb6e332f58f7218980ad1
2020-09-15 07:46:26 +00:00
Zuul
a28bc2a55a Merge "Remove haproxy_check_script for UDP-only LBs" 2020-09-14 20:46:58 +00:00
Michael Johnson
8cd7a6b9d7 Update protocol combination api-ref for PROXYV2
A previous patch[1] forgot to update the api-ref protocol combination
tables for the PROXYV2 pools.
This patch corrects that oversight.

[1] https://review.opendev.org/747801

Change-Id: I84025c5d1d3091c408416fb78b92ae0a7a89b74e
2020-09-14 17:00:47 +00:00
Carlos Goncalves
16f9d2ebf8 Fix image build when installing agent from package
There is a bug in the octavia-lib DIB element where it runs install
actions that should only be ran when the amphora-agent is installed from
source. This issue causes the amphora image build to fail when
installing the amphora-agent from distribution packages (option -p in
the diskimage-create.sh tool).

Task: 40870
Story: 2008138

Change-Id: I46ba7798322f24255ab7d49db4b4df886e92cbf3
2020-09-14 18:56:36 +02:00
Michael Johnson
eb9e9dc7a4 Switch grenade to run the octavia smoke tests
This patch updates the tempest plugin regex for the grenade job
to run the tests tagged with the "smoke" attribute.

Change-Id: Id1eadc19dd283caeb9f6a31dc69e5bc734daf784
2020-09-14 09:47:48 -07:00
Zuul
b400620a24 Merge "Change tls_ciphers init in Pool API classes" 2020-09-11 19:29:18 +00:00
Adam Harwell
0ce9add9d9 Remove haproxy_check_script for UDP-only LBs
This file is created when no HAProxy listeners exist so VRRP will fail,
but needs to be removed when a UDP listener is added so that VRRP can
actually correctly start.

Story: 2008133
Task: 40859

Change-Id: Ib2a80afb9223da2c0af6f6add250ffaaa20a316f
2020-09-11 12:16:23 -07:00
Corey Bryant
59c4ad4832 Drop diskimage-builder from root requirements.txt
diskimage-builder is already listed in diskimage-create/requirements.txt,
and it isn't really a run-time dependency for octavia so it tends to be
confusing downstream as we generally add run-time dependencies based on
the root requirements.txt.

Change-Id: I612ea1c583090897bd44453b867d75929a01b7fc
Story: 2007934
Task: 40389
2020-09-11 10:10:54 -07:00
Michael Johnson
a446c04f77 Revert pyroute2 workaround
The pyroute2 module had a regression in 0.5.13, but neutron needed a fix
that was included in 0.5.13. It was easier for us to work around it than
for neutron to revert the update to 0.5.13, so we hacked a workaround[1].

A new pyroute2 release, 0.5.14, has been published, so this patch reverts
the hack and bumps our minimum version of pyroute2 to 0.5.14.

[1] https://review.opendev.org/#/c/744045

Change-Id: Ia4357a4f5db07e1a6b0beb11b58ce125215eeef1
2020-09-10 16:57:02 -07:00
Michael Johnson
66f3a63f44 Fix amphora failover when VRRP port is missing
In an amphora failover situation, if the VRRP port of the other
amphora in an active/standby pair is missing from neutron, the amphora
failover may fail with a "port not found" error.
This patch corrects this issue by allowing the amphora failover in
progress to complete even if the other amphora is also in a failed
state.

Story: 2008127
Task: 40851

Change-Id: I806d220236ad741b638ad9315537334f2d923031
2020-09-10 16:50:42 -07:00
Zuul
f306ec7f46 Merge "Add requirements for jobboard drivers" 2020-09-10 22:02:29 +00:00