Because the intermediate certificates are misplaced(they are not expected
to be at the top of the pem file), there is issue in haproxy config file
generation and hence the listener creation fails. This patch fixes the
ordering issue.
Change-Id: I1e7c3c1579d410ded77962e03b1ac8778b0e5d72
Closes-Bug: 1567031
Write files using a safer open for writing operations[1].
Modifided the file permission from 666 to 644 in base.j2 to make sure
consistenacy between docs and real file permission.
Edited unit tests based on the new method.
[1] https://security.openstack.org/guidelines/
dg_apply-restrictive-file-permissions.html
Closes-Bug: #1548552
Change-Id: If3f315005fcd22afc2f24da527da08175e230bb1
Remove anchor's default value for username and password
for the sake of a security perspective.
Closes-Bug: #1548555
Change-Id: I14f1b84f5161308fc23ef3776a796636ba61154d
A previous patch [1] mistakenly added a port detach call to the failover
flow. It didn't cause failures due to a type-o in the arguments to the
call, so it would passively fail with a log entry. However, if someone
fixed this it would cause failover to fail due to the port getting
deleted during the detach.
This patch removes that code.
[1] https://review.openstack.org/#/c/295475/
Change-Id: I1eb1ad551636d5cd9253690a59e0e88ca1d238b5
1. Fixes the mismatch between the tls_container_id lengths in neutron.lbaas_sni
and octavia.sni tables.
2. Fixes the syntax error in cert_parser.py field. (tls_container.id => tls_container_id)
3. Removes the certs['sni_certs'] parameter from the rest_api_driver.py as it gets wrongly
assigned to socket_path parameter in the jinja_cfg.py file.
4. Modifies the sample_configs to make the unit tests work with the above changes.
Change-Id: I8fe5854ef2dc508e37a368294c44eef63b5bccba
Closes-Bug: #1520990
The local.conf example includes setting up Horizon. It should include
setting up the lbaas-dashboard as well.
Change-Id: I44073aea3f1769dc1211967baa629bb6d2f1323d
The failover flow was not plugging the ports back into the
amphora if the failover used an amphora from the spares pool.
This patch adds a task to plug the ports back into the amphora
during failover
Change-Id: Id7f0e60650ca2b35afb2695181897674abb9d8cf
Closes-Bug: #1558934
Devstack allows configuration of the OVS bridge which will be used.
Octavia plugin has the default, br-int hardcoded.
Plugin should use OVS_BRIDGE when the value is set, or default to br-int.
Change-Id: I1a92667790c4e58691c3d946d6cecc6527211b9b
Fixing the keystone token issue due to the different
keystone version env variables
Change-Id: I6a60502f7b8369755f69a231a81032d04cf518ab
Closes-Bug: #1559223
This patch moves the Octavia configuration option documentation
into the Octavia repository. The OpenStack docs team deleted
this documentation from the Mitaka release[1]. The Octavia
team finds value in this documentation so we are moving it into
our repository.
[1] https://review.openstack.org/#/c/259889/
Change-Id: I4fcc2a7dc8fa3ef343456d98202ea7d4f9cd1289
The Octavia devstack plugin does not shutdown the dhclient
instance for the o-hm0 interface it creates. This leads to
many dhclients running on the same interface.
This patch removes the cleanup of haproxy services (octavia doesn't
run haproxy on the devstack host) and replaces it with cleanup of
the dhclient processes for the o-hm0 interface.
Change-Id: If8d73e7771177d9a446a85c5db8511c96ae06a1b
Closes-Bug: #1557242
While updating the admin-state-up of LB, Listener, Pool,
or member the update fails due to the wrong order of the
positional parameters.
This leads to SQL syntax error and eventually
Loadbalancer gets stuck in PENDING_UPDATE provisioning
status.
The haproxy jinja was not taking into account if objects
were enabled or not.
This patch fixes the above issue.
This patch also adds the OpenFixture class from neutron
to enable safer mocks of os.open. This was needed for the
test of this code.
Co-Authored-By: Michael Johnson <johnsomor@gmail.com>
Closes-Bug: #1547123
Closes-Bug: #1549036
Closes-Bug: #1549186
Closes-Bug: #1552098
Change-Id: Id5733cc8e26ec7092b821c2c18c41696d6789265
Single create was accepted on the condition that some unit test coverage was
added afterward. In testing I found a few errors involving the "pop" method,
and included those fixes here.
Closes-Bug: #1551427
Change-Id: If6dc8521ecf3bd194638f163e128fa2015320da8
Added hacking check to ensure not to use xrange. Also,
fixed issues with EoF missing newline [W391].
Change-Id: Iba8d240c042e46cb34eb6ed057534d62efb6f903
Closes-Bug: #1538118
Since single-create utilizes the existing objects already documented, I added an
example for the request and response, and indicated to look for more details
in the appropriate object's section.
Change-Id: Icdf7f21867457e22086f9c44ab657f95617bee1a
Closes-Bug: #1551428
The API WSME Types all inherit a to_dict method that accepts as a parameter
render_unsets. It is currently set to True by default but should be False for
consistency and also because it just makes better sense. This has caused some
unnecessary workarounds and work before it was known this existed.
Closes-Bug: 1555493
Change-Id: Idd21a003c0b1e3092f979013f8c19d75f17d0249
This patch adds unit tests for the data model manipulations which were
added in L7 and the subsequent model update flow fix and session
persistence update fix patches. While writing these unit tests, it
became apparent that we could simplify some of the logic in the L7
Policy data model update method-- so this has been done.
Closes-Bug: #1548944
Change-Id: I0df4e234e3383cf310d6169349844a344633ba1a
It appears the improved L7Policy validation code recently merged broke
some types of L7Policy updates. This patch fixes this regression.
Further, the validations were reworked significantly since I had made an
incorrect assumption about which API parameters would be filled by the
l7policy API controller put method.
Change-Id: Ibd8723400d60e286e2704a8d52ac0baf582f38a3
Closes-Bug: #1555420
Our code for updating a pool in the repository was off: You could
potentially update other pool parameters (ie. not session_persistence)
and it would unexpectedly clear the session_persistence. This patch
corrects this problem and cleans up the code dealing with session
persistence so that it's more understandable what it's doing.
There was also a bug in Neutron-LBaaS' handling of session_persistence
which was making troubleshooting this problem more difficult. This patch
is a prerequisite for the Neutron-LBaaS bugfix.
Beyond this, this patch also cleans up calls to
repository.update_pool_and_sp to not require the sp_dict parameter
(which, it turns out, did not need to be split out of the pool data
structure prior to calling this method anyway).
Closes-Bug: #1547157
Change-Id: Idcf12e463fbaa3a61a211f13986d8472f52036d2
We were using inconsistent type checking for the project_id in various
API endpoints. This could lead to erratic behavior if some API requests
specified the project_id UUID with hyphens and some without hyphens and
normlization occurred.
This patch changes this behavior to use consistent type checking for the
project_id for all API endpoints. Since this bug is a regression that is
less than 2 weeks old, I've also introduced a few unit tests which
should ensure we don't have another regression of the desired behavior
anytime soon.
Change-Id: I4c3ec52c01547196160e977029ecc5ded97c79ed
Closes-Bug: #1555401
