openstack/openstacksdk
Code Issues Proposed changes

tox: Correct functional test factors

Browse Source 
We are running functional tests in zuul without a 'pyNN' factor (e.g.
'tox -e functional'). For this to work, we need to allow an empty
factor, i.e. we want:

  [testenv:functional{,-py310}]

rather than:

  [testenv:functional{-py310}]

(note the missing comma)

Unfortunately we missed this as tox 4 has a currently unaddressed
regression [1] that results in it running the base testenv in the case
there is only a partial factor match. That needs to be fixed for avoid
this biting us again the future, but we can at least fix it for now.

[1] https://github.com/tox-dev/tox/issues/3219

Change-Id: Ib9f65a4523222f1224d51534c5061f90501b59d3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2024-02-15 14:19:10 +00:00
parent c2baf1db41
commit 568921ce5b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tox.ini
View File

@ -23,7 +23,7 @@ commands =
stestr run {posargs} stestr run {posargs}
stestr slowest stestr slowest
[testenv:functional{-py37,-py38,-py39}] [testenv:functional{,-py37,-py38,-py39,-py310,-py311,-py312}]
description = description =
Run functional tests. Run functional tests.
# Some jobs (especially heat) takes longer, therefore increase default timeout # Some jobs (especially heat) takes longer, therefore increase default timeout