openstack
/
oslo.messaging
Code Issues Proposed changes

Update patch set 15 

Patch Set 15:

(1 comment)

Other than a minor nit the patch looks fine, though I agree with Ben that (unless otherwise intended) the metric stuff should not be assumed public API.

Patch-set: 15
Reviewer: Gerrit User 8770 <8770@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 8770 2021-06-07 17:03:14 +00:00 committed by Gerrit Code Review
parent 3c3021a075
commit 867525071c
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
23909b76f66301e094b20853ddb8d160c56fab5f
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "e76168a4_ffc4028a",
"filename": "oslo_messaging/metrics/client.py",
"patchSetId": 15
},
"lineNbr": 53,
"author": {
"id": 8770
},
"writtenOn": "2021-06-07T17:03:14Z",
"side": 1,
"message": "multi-line help text like this needs a space at the end or beginning of the lines so the last and first words don\u0027t get squished together. Minor nit you can follow up with a separate patch if you\u0027d like.",
"revId": "23909b76f66301e094b20853ddb8d160c56fab5f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "3fef8931_4b17c1bd",