Floating IP port forwarding by ml2/ovn uses OVN load balancers.
Integration tests with ovn_octavia_provider here are done to
ensure that these two functionalities can coexist.
Depends-On: https://review.opendev.org/#/c/741303/
Change-Id: I4b5ded003cbb3c9c4c0bc026f0e9b396f2665531
We should only be using unittest.mock since we're python3-only,
so add and enable a hacking check that will catch it.
Change-Id: I64847f329ee3e1a3377a8c63df90c697d8b74c86
If IpAddressAlreadyAllocated is raised and the created VIP with
the same IP address allocated is not owned by LB that we're trying
to create, we should raise DriverError instead passing the status
update to Octavia API.
Change-Id: Id0dc8a478b903b80cf8afdfa3d2b23e90d22e112
Closes-Bug: 1882724
The Backend class in ovsdbapp was modified when adding index
support. Different projects wanted different scopes for their
ovsdb_connections, and this was moved to a property in ovsdbapp.
For now, we can just set ovsdb_connection = None on the backend
class to get the behavior we desire.
Also mocks out autocreate_indicies for a unit test.
Change-Id: I7741a441a55e67354bc0887e5db2f8137073b5b4
Prior this patch OVN Octavia provider driver used
default 5-tuple-hash algorithm which is pretty similar to
SOURCE_IP_PORT.
Unfornutelly because of the bug described here [1] it
was not clear how 5-tuple-hash works and some inconsistencies
between kernel and user space implementations were found.
OVN recently added support for selective fields in OVN LB, to
explicitly define what fields are being hashed to tackle this problem.
This commit adds support for that kind of hashing. If installation
of OVN on which OVN Octavia provider is running doesn't support
selective fields - it will use old behavior.
[1] https://mail.openvswitch.org/pipermail/ovs-discuss/2020-April/049896.html
[2] 5af304e747
Change-Id: I7b4ab99d1be2855e18b186557990c85f170ad548
Closes-Bug: #1871239
Move them to their respective test_*.py files.
Created base.py to hold the parent class common to all
sub-tests.
Change-Id: I4f8466ceb36356e0d80cdcfe1e6e2c5884c1f567
The OVN Octavia provider driver in the OvnProviderHelper
class caches these attributes:
ovn_nbdb_api_for_events
ovn_nb_idl_for_events
ovn_nbdb_api
to not re-create things each time OVN IDL that is used for
handling events is called.
We should be using the Octavia Driver Provider Agent framework
instead to not have those long-running IDLs in the API process.
This change:
- Creates driver provider agent and registers its entry point
- While setting up the driver agent instance, start IDL that
will handle events
- Stop caching ovn_nbdb_api, ovn_nb_idl_for_events and
ovn_nbdb_api_for_events in the OvnProviderHelper class
Change-Id: I0034a48997bd6b95e1b51bfcbd56e8372b35e62f
Closes-bug: #1871355
Added a number of unit tests based on coverage report
data, it's up to 79% now.
Fixed test_pool_create_exception() to call pool_create()
instead of pool_update().
Also fixed a bug in the driver.pool_update() exception code
path found when adding a new test, status['pools'] is the
correct element.
Change-Id: Ic72aad21e0ecf5b0334b321b18515d909daa3ba4
This repo is python3 only, we should move to using the built
in version of mock that supports all of our testing needs and
remove the dependency on the "mock" package.
This patch moves all references to "import mock" to
"from unittest import mock".
Fixed one related functional test failure.
Change-Id: I4f7568b1af254488cbc75aefac2a1708e70eaf31
The repo is Python 3, so update hacking to version 3.0 which
supports Python 3.
Update local hacking checks for new flake8.
Change-Id: I37851c466ac14f41506f3d0d7cee75db84580756
We shouldn't be using Octavia components except octavia-lib
in provider driver.
For now we only use Neutron client methods from Octavia Neutron network
driver, so this patch removes use of Octavia network driver
in favor of direct use of Neutron Client.
Change-Id: I77802ff65f975f8136daddfe897ae1993bd9c5e9
The unit test setup has a try/except to support octavia-lib
< 1.3.1, but since that is the version in lower-constraints
it can never be triggered. Remove it.
Change-Id: Ia28ecf4ffd1a0aaf7c7b28af9d6ec75b313d8abf
When there are multiple listeners with different protocols
configured on OVN LB, and one of listeners needs to be deleted,
there is no need to refresh vips on given OVN LB.
If there are no listners withing same protocol left the given OVN
LB could be deleted and there is no need to refresh vips then.
Change-Id: If15f817617facade10005878c8dfc7f467ce75a9
Closes-Bug: 1866087
If IPv6 address is not wrapped with brackets OpenFlow rules are
not properly installed.
Change-Id: Ib5836b004fd47671c4cdaa382c9376380beee448
Closes-Bug: #1863892
When Load Balancer and its member has FIP assigned
and environment is configured to use DVR the member
FIP needs to be centralized. It is current core OVN
limitation, that should be solved in [1].
This patch adds this mechanism to OVN Client and
OVN Octavia provider driver.
It covers cases:
1) FIP association on port that is a member of
some LB - make it centralized.
2) FIP association on LB VIP - find a members
FIPs and centralized them.
3) Add a member to LB that has FIP already
configured - checks if a member has FIP
and centralize it.
4) The reverse of each of the above cases.
In addition I needed to extend OVN LB member external_id
entry to add an information about member subnet_id
in order to easly track member port from mechanism OVN
driver.
That means I needed also to support both old and new
conventions. This patch adds also this code.
Old convention:
member_`member_id`_`ip_address`:`port`
New convention:
member_`member_id`_`ip_address`:`port`_`subnet_id`
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1793897
Related-Bug: #1860662
Change-Id: I254f0ac28f7585b699a8238e01ffb37dd70282ef
(cherry picked from networking-ovn commit 57ac38921efa6bbf0bc4a22950355256cc3ebe6d)
Sometimes there is a race condition on creation of VIP port
or deleting it that ends with exception and blocks LB stack
creation / deletion.
Because for now we don't have running master branch
for OVN provider driver this change will be applied
first on stable/train in networking-ovn tree and then cherry-picked.
Change-Id: I2aaae7c407caba7a57e2ca2d4ed524f3bb63953f
Closes-Bug: #1860141
In some corner cases while updating a member, OVN
Provider Driver sends a malformed status update
to Octavia that breaks the update operation and
resources stuck in PENDING_UPDATE state.
In OVN while resource is administratively disabled
we suffix its ID with string ':D'.
This patch filters this string from resources ID
before sending Octavia a status update.
Because for now we don't have running master branch
for OVN provider driver this change will be applied
first on stable/train and then cherry-picked.
Change-Id: Ib2ce04625faddd6ed263678bad2f4eb10929a520
Closes-Bug: #1860140
In case of subnet not found all the related actions could
not be taken. This patch prevent this situation to happen.
This could be possible that LB is going to be deleted after
the subnet (for example remove of the LoadBalancer in Error
state).
The same could happend with Logical Switch. Sometimes the
member network is delated in meantime and then we tries to
the members. It means we would need to remove LB to LS and
LB to LR associations, but it could not happend because of
missing LS. In those terms now we just pass the flow
and remove the LS to LR counters in external_ids.
Change-Id: I44f6de4c9a2b1c6054417dbb7f647a6af8339660
Closes-Bug: 1857009
(cherry picked from networking-ovn 9aa7edd7852df98fe257d6a3b5c3b524398a1d4b)
This change introduces a way of providing multiple listeners and pools
on the same Load Balancer, but with different L4 protocols.
In case there are more than one unique protocol defined in Octavia pools
or Octavia listeners the OVN driver now adds another Load_Balancer row
per protocol, but with the same name. The selection of which OVN
Load_Balancer should be used is done by a protocol key.
This change also adds possibility to expose two listeners on the same
port, but with different L4 protocol. The common use-case is providing
a DNS service that listens both on UDP and TCP sockets.
Partial-Bug: #1789157
Change-Id: I2ee13b75713e7538d1b4f70207a90a95315eb914
This code moves OVN Octavia provider driver from networking-ovn
(branch master) repository to this repository.
For first step lets move code and unit tests.
Previous paths in networking-ovn tree:
./networking_ovn/octavia/ovn_driver.py -> ./ovn_octavia_provider/driver.py
./networking_ovn/tests/unit/octavia/test_ovn_driver ->
./ovn_octavia_provider/tests/unit/test_driver.py
There are a few files taken directly from neutron
repository that could be removed when neutron-lib
including those will be released:
./ovn_octavia_provider/ovsdb/impl_idl_ovn.py
./ovn_octavia_provider/ovsdb/ovsdb_monitor.py
Co-Authored-By: Brian Haley <bhaley@redhat.com>
Co-Authored-By: Carlos Goncalves <cgoncalves@redhat.com>
Co-Authored-By: Frode Nordahl <frode.nordahl@canonical.com>
Co-Authored-By: Jakub Libosvar <libosvar@redhat.com>
Co-Authored-By: Maciej Józefczyk <mjozefcz@redhat.com>
Co-Authored-By: Numan Siddique <nusiddiq@redhat.com>
Co-Authored-By: Reedip Banerjee <rbanerje@redhat.com>
Co-Authored-By: Terry Wilson <twilson@redhat.com>
Co-Authored-By: Yunxiang Tao <taoyunxiang@cmss.chinamobile.com>
Co-Authored-By: zhufl <zhu.fanglei@zte.com.cn>
Change-Id: I9b562c4ed5f74df2c3d600356758f4648ac7770b
Related-Blueprint: neutron-ovn-merge
