openstack
/
puppet-designate
Code Issues Proposed changes

Merge "producer: Convert enabled_tasks to comma separated list"

This commit is contained in:
Zuul 2021-08-24 08:40:11 +00:00 committed by Gerrit Code Review
parent 26b2c4f6bc fc113562ab
commit c5b521ebc3
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/producer.pp
View File

@ -66,7 +66,7 @@ class designate::producer (
designate_config { designate_config {
'service:producer/workers' : value => $workers; 'service:producer/workers' : value => $workers;
'service:producer/threads' : value => $threads; 'service:producer/threads' : value => $threads;
'service:producer/enabled_tasks' : value => $enabled_tasks; 'service:producer/enabled_tasks' : value => join(any2array($enabled_tasks), ',');
} }
if $backend_url != undef { if $backend_url != undef {

14
spec/classes/designate_producer_spec.rb
View File

@ -35,19 +35,19 @@ describe 'designate::producer' do
end end
it 'configures designate producer with default config options' do it 'configures designate producer with default config options' do
is_expected.to contain_designate_config("service:producer/workers").with(:value => 8) is_expected.to contain_designate_config("service:producer/workers").with_value(8)
is_expected.to contain_designate_config("service:producer/threads").with(:value => '<SERVICE DEFAULT>') is_expected.to contain_designate_config("service:producer/threads").with_value('<SERVICE DEFAULT>')
is_expected.to contain_designate_config("service:producer/enabled_tasks").with(:value => '<SERVICE DEFAULT>') is_expected.to contain_designate_config("service:producer/enabled_tasks").with_value('<SERVICE DEFAULT>')
end end
end end
context 'with non default parameters' do context 'with non default parameters' do
before { params.merge!( designate_producer_params ) } before { params.merge!( designate_producer_params ) }
it 'configures desginate produce with non default parameters' do it 'configures desginate produce with non default parameters' do
is_expected.to contain_designate_config("service:producer/workers").with(:value => '3') is_expected.to contain_designate_config("service:producer/workers").with_value('3')
is_expected.to contain_designate_config("service:producer/threads").with(:value => '3000') is_expected.to contain_designate_config("service:producer/threads").with_value('3000')
is_expected.to contain_designate_config("service:producer/enabled_tasks").with(:value => ['domain_purge','periodic_secondary_refresh']) is_expected.to contain_designate_config("service:producer/enabled_tasks").with_value('domain_purge,periodic_secondary_refresh')
is_expected.to contain_designate_config("coordination/backend_url").with(:value => 'redis://10.0.0.1:1234') is_expected.to contain_designate_config("coordination/backend_url").with_value('redis://10.0.0.1:1234')
end end
end end
end end