2975 Commits

Author SHA1 Message Date
Michele Baldessari
c1e9447998 Make sure python3-novaclient is installed before creating fence_compute
This has been observed during an IHA FFU process. Namely
after the OS upgrade by LEAPP the fence_compute resource will
fail starting because python3-novaclient is not installed.
Normally this is taken care of by rpm dependencies, but
fence_compute is buggy and does not explicitely have that
dep (https://bugzilla.redhat.com/show_bug.cgi?id=1857247)

So we need to make sure the package is installed before
creating the resource.

Tested this on four consecutive successful IHA FFU runs
and it worked okay.

Related-Bug: #1888398

Change-Id: I6816d414409da3748b2e341ec05ebcad86ad8fd1
2020-07-23 07:59:13 +02:00
Takashi Kajinami
07e0aca242 Use relative names to include classes
... to avoid lint errors by relative_classname_inclusion, which was
re-enabled recently[1].

[1] https://review.opendev.org/#/c/740023/

Change-Id: Ibb80b8b0f4075c00ceb306bcf54bb87df58165af
2020-07-15 11:59:45 +09:00
Zuul
4cca6ed283 Merge "Add FFU support for ceph_nfs" 2020-07-07 11:33:33 +00:00
Zuul
3df797e61c Merge "Remove stonith level warning when running on a non cluster node" 2020-07-07 10:21:16 +00:00
Giulio Fidente
f1994dba33 Switch RGW HAProxy healthcheck to use special RGW healthcheck url
The change is made because /swift/healthcheck weights less on RGW
and avoids overloading the nodes CPU for basic HAProxy checks

For more information also see [1]

1. https://bugzilla.redhat.com/show_bug.cgi?id=1850036#c16

Change-Id: I3e2805a922c0e90dc493a3e065bbdc229e5fc7a8
2020-07-06 12:01:04 +00:00
Michele Baldessari
4243119d09
Add FFU support for ceph_nfs
This patch fixes the ceph_nfs upgrade process checking
for the short_name variable definition.
This is required to properly handle the FFU process for
this service.

Change-Id: I89c848bdae1b997b38a5164302acdcca94619471
2020-07-06 08:46:55 +02:00
Zuul
afb0869f0d Merge "Remove deprecated keystone::enable_bootstrap" 2020-07-04 19:24:10 +00:00
Dave Wilde (d34dh0r53)
c1e09672a5 Ensure that the HAProxy certificate is updated
While doing research for this bugzilla[1] I found that since the
actual certificate PEM file is being bind mounted the mount is acting
as a hard link to the inode of the PEM rather than just a pointer to
it's location in the directory.  When the new file is copied over the
inode is updated but the container still maintains a link to the stale
inode.  This patch copies the contents of the certificate into the
container so that the HUP of HAProxy will reload the certificate.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1765839

Change-Id: Idf106c9ffa23ed00c497e1e5014e1b5718254320
Closes-Bug: 1871663
2020-07-03 13:53:38 +00:00
Zuul
35a6c01d5e Merge "Include neutron::db" 2020-07-03 11:01:57 +00:00
Zuul
e20ad9c45a Merge "Make the additional_erl_args change more independent" 2020-07-02 21:01:56 +00:00
Zuul
0c9c341ddc Merge "Enable to modify params of logrotate-crond.conf" 2020-07-02 16:08:46 +00:00
Zuul
b91eb4f5e4 Merge "Fix haproxy ceph dashboard condition" 2020-07-02 13:42:24 +00:00
Michele Baldessari
f1b341962a Remove stonith level warning when running on a non cluster node
Currently when we run with puppet --debug on a non cluster node we get:
overcloud-novacompute-0 ~$ puppet facts --debug --color=false|grep Error
Debug: Facter: Error: unable to get cib

Let's just remove stderr from the pcs command. After the fix:
overcloud-novacompute-0 ~$ puppet facts --debug --color=false|grep Error
overcloud-novacompute-0 ~$

Change-Id: Ie48a78a30d9a2824155a9f7388660cab7b5935dd
2020-07-01 15:35:30 +02:00
Tobias Urdin
be2550f662 Include neutron::db
See [1] also need to move database_connection in THT [2]
to neutron::db::database_connection.

[1] https://review.opendev.org/#/c/737497/
[2] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/neutron/neutron-api-container-puppet.yaml#L263

Change-Id: I6d6c8e52e37fb1cce4cd6cf1ac9d0b8e20151ace
2020-07-01 07:52:24 +00:00
Michele Baldessari
cfc20b287f Make the additional_erl_args change more independent
In I3bf244a70538209773804eb85fae6be035c587f4 we made sure that
we use the additional_erl_args to define parameters. This all
works well but it requires the corresponding THT change
(I567839785a72813a382a00253562894e19eb6715). Let's make it so
that we can merge all the puppet changes without mandating the
THT change at the same time. This makes things easier when backporting.

Tested by deploying a queens environment with this change,
puppet-rabbitmq from master and correctly got a working rabbitmq
cluster. (I.e. we avoided deploying with the corresponding THT change)

Change-Id: I9fa9ba95410ed3994f608beb2c5e1578dc3a7c7a
Related-Bug: #1884922
2020-06-30 17:25:10 +02:00
Zuul
c63bb348aa Merge "Cleanup remaining implementation for EC2 API" 2020-06-30 01:38:25 +00:00
Takashi Kajinami
344c4b5c4f Remove deprecated keystone::enable_bootstrap
This patch removes usage of the keystone::enable_bootstrap parameter,
because it has been deprecated[1] and has no effect now.

Note that we currently implement bootstrap process in t-h-t, thus
we don't need to include keystone::bootstrap in puppet-tripleo.

[1] bc1ff1d7cb01ac02790c3302a3da6e994598d9f6

Change-Id: I9e29f774afe26c56f0091aa28ef5517f26fe1e4b
2020-06-29 15:36:20 +09:00
Francesco Pantano
a21b5ee7ce
Fix haproxy ceph dashboard condition
If grafana is not enabled in the overcloud the
dashboard section shouldn't be created. We
currently hit an issue during upgrades because
the haproxy exists (because of ceph_mgr_enabled)
even though the dashboard bits aren't deployed.
Using the same condition for both services should
be safe enough.

Closes-Bug: #1885122
Co-Authored-By: Giulio Fidente <gfidente@redhat.com>
Change-Id: I70d2ef2a64f0a46203d7a60b564eaa287e5708d6
2020-06-25 13:31:08 +02:00
Michele Baldessari
4d3864249d Fix RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS usage with a proper override mechanism
In THT we allow RabbitAdditionalErlArgs to set some additional
parameters which should be passed to RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS
when starting rabbit. The problem is that when we use internal tls
that parameter gets ignored and so we lose our default '+sbwt none'.

Let's do this via a proper parameter while also considering the fact
that historically the default value of RabbitAdditionalErlArgs had
apices around it.

Change-Id: I3bf244a70538209773804eb85fae6be035c587f4
Related-Bug: #1884922
2020-06-25 10:30:22 +02:00
Zuul
5e3e9cb425 Merge "Make promote timeout configurable" 2020-06-24 06:14:32 +00:00
Zuul
110323551c Merge "Fix the default values for ca_file and cert_file" 2020-06-23 23:45:26 +00:00
Takashi Kajinami
7cb19e66a6 Cleanup remaining implementation for EC2 API
... because support for EC2 API should have been removed[1].

[1] 1854f9a641fef548e1d5f665fce0030a867c6f80

Change-Id: I9ce13aefb82cbcada5466cd3dddf851cfc51bacc
2020-06-23 10:50:25 +09:00
Zuul
e976e46cf6 Merge "Remove support for Neutron FUJITSU plugin" 2020-06-22 11:55:51 +00:00
Damien Ciabrini
0606e22e24 Make promote timeout configurable
Allow override of galera promote timeout

This commit removes the hard coded value of pacemaker promote time out
(currently 300s), and allows operators to override it via:

tripleo::profile::pacemaker::database::mysql::promote_timeout
tripleo::profile::pacemaker::database::mysql_bundle::promote_timeout

Closes-Bug: #1883896
Change-Id: I96f5d349b94f05f4f66db6b85ba481deba0015d9
2020-06-22 12:07:37 +02:00
Ryo Hayakawa
f6f878d4b3 Enable to modify params of logrotate-crond.conf
Parameters "minsize" and "notifempty" of /etc/logrotate-crond.conf
in the container logrotate_crond should be changeable even if this
doesn't	comply with GDPR. This is because there might be users who
don't want to comply with it for some reason such as their internal
rule, testing purpose, etc.

This patch adds the following Puppet hieradata.

tripleo::profile::base::logging::logrotate::minsize (default: 1)
tripleo::profile::base::logging::logrotate::notifempty (default: True)

Change-Id: I623c711921cf7fe52f15cc1ba4a1dafb3c9479b7
Closes-Bug: #1884415
2020-06-21 22:37:09 +09:00
Zuul
47f5430d5e Merge "Use puppet-openstack-module-unit-jobs to define unit test jobs" 2020-06-20 16:33:43 +00:00
Grzegorz Grasza
9befc58257 Fix the default values for ca_file and cert_file
Before this change, the values were set to haproxy defaults,
however, these should not be used. The keystone endpoint
should be verified by the system's default CA certificates,
which are mounted into the neutron_api container.

Change-Id: I35b39a1bc0e1793116831485180a49da5e0a019a
Closes-Bug: #1883741
Resolves: rhbz#1844592
2020-06-18 19:55:06 +02:00
Zuul
165b9c5c57 Merge "Add the missing ':' in README" 2020-06-17 05:34:23 +00:00
Martin Loschwitz
436bfaa158 Make haproxy.pp honor EnableInternalTLS for rgw
haproxy.pp assumes that Ceph rgw instances cannot be SSL
encrypted and generates invalid haproxy configuration files
in setups where EnableInternalTLS is set to true.

This patch makes haproxy.pp honor EnableInternalTLS and
include internal_tls_member_options in the member_options
for Ceph rgw instances.

Change-Id: If59a27b28eb61ab2c1ff84f5047261e8695234d4
Closes-Bug: #1883296
2020-06-12 19:10:32 +02:00
Zuul
e62b614331 Merge "Deprecating Dell EMC Xtremio Iscsi Volume Config" 2020-06-10 00:08:46 +00:00
Zuul
4647c28654 Merge "Remove obsolete 'http' backend from glance configuration" 2020-06-06 04:48:37 +00:00
Zuul
525feb9f16 Merge "Switch to newer openstackdocstheme and reno versions" 2020-06-06 00:34:01 +00:00
Alan Bishop
a2a04ed488 Remove obsolete 'http' backend from glance configuration
Glance has a read-only 'http' backend that is obsolete now that tripleo
supports glance multi-store (multiple backends). Glance's web-download
import method no longer relies on the 'http' backend, so tripleo should
no longer include 'http' in the list of enabled backends.

Change-Id: I64ee3a3c8f0dabdeab16968c39ea00b8879f5405
2020-06-05 09:21:17 -07:00
Zuul
2b058cc7cc Merge "Stop to use the __future__ module." 2020-06-05 06:07:06 +00:00
Andreas Jaeger
c76bbf8760 Switch to newer openstackdocstheme and reno versions
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html

Change-Id: I40a84c827397517b923158e5b8c57b21228b64b6
2020-06-03 20:33:05 +02:00
Zuul
3441a35842 Merge "Finish HAProxy config for metrics_qdr" 2020-06-03 03:58:54 +00:00
Hervé Beraud
14fadeda6d Stop to use the __future__ module.
The __future__ module [1] was used in this context to ensure compatibility
between python 2 and python 3.

We previously dropped the support of python 2.7 [2] and now we only support
python 3 so we don't need to continue to use this module and the imports
listed below.

Imports commonly used and their related PEPs:
- `division` is related to PEP 238 [3]
- `print_function` is related to PEP 3105 [4]
- `unicode_literals` is related to PEP 3112 [5]
- `with_statement` is related to PEP 343 [6]
- `absolute_import` is related to PEP 328 [7]

[1] https://docs.python.org/3/library/__future__.html
[2] https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html
[3] https://www.python.org/dev/peps/pep-0238
[4] https://www.python.org/dev/peps/pep-3105
[5] https://www.python.org/dev/peps/pep-3112
[6] https://www.python.org/dev/peps/pep-0343
[7] https://www.python.org/dev/peps/pep-0328

Change-Id: I1a658a73efc0753d4728ab72e04b70621927a510
2020-06-02 20:45:19 +02:00
Zuul
6f8430a8ac Merge "Remove selinux relabel mount option for neutron" 2020-06-01 19:59:00 +00:00
Zuul
68a0f3c7ea Merge "Include vendordata class in nova-compute" 2020-05-29 03:25:11 +00:00
Brent Eagles
3fa8c735ae Remove selinux relabel mount option for neutron
Neutron agent processes launched in containers are failing with
 "Error: relabel failed "/var/lib/neutron": \
  SELinux relabeling of /var/lib/neutron is not allowed"

Possibly related prior patch:
 https://review.opendev.org/#/c/626546/

Change-Id: Ifc7d0cb79214da44d9cd12481f010e2d7d325aa6
Related-Bug: #1881146
2020-05-28 13:07:38 -02:30
Zuul
b58d69fe9a Merge "Support for Dell EMC VXFlexOS Backend" 2020-05-28 01:27:11 +00:00
Zuul
4bbb2b16a3 Merge "metadata.json: bump version for the start of Victoria" 2020-05-27 23:27:05 +00:00
Zuul
811c6d0897 Merge "Deprecate Keepalived" 2020-05-27 23:26:59 +00:00
Emilien Macchi
3d14df74db metadata.json: bump version for the start of Victoria
Bump the major version for the Victoria release and also update the
Puppet OpenStack dependency.

Change-Id: I58cddcb15424420f15b658348bff24f485d21cca
2020-05-27 09:05:51 -04:00
rajinir
c71e527f46 Support for Dell EMC VXFlexOS Backend
Adding support for VXFlexOS Volume Backend

Change-Id: I83b4d400947da16229c565c5311ca033b4c76d73
Closes-Bug: 1875176
2020-05-26 15:26:00 -05:00
54a9aba25a Update master for stable/ussuri
Add file to the reno documentation build to show release notes for
stable/ussuri.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.

Change-Id: I67c99ab0f495710b98c0720db79a3c9713fafb6d
Sem-Ver: feature
2020-05-26 17:14:06 +00:00
Takashi Kajinami
dab61ed2c0 Include vendordata class in nova-compute
The nova::vendordata is not automatically loaded now, so we should
explicitly include the class in the manifest for nova-compute to
configure vendordata parameters in nova-compute.

Depends-on: https://review.opendev.org/#/c/730424/
Change-Id: I0843d38bd9fe0cc9bf92f533a7dbe83a0b4f297d
2020-05-26 11:24:44 +09:00
Zuul
5cff8c20f7 Merge "Allow the Mistral tunnel timeout to be configurable." 2020-05-24 21:14:31 +00:00
Zuul
07448ba92b Merge "Deprecating ScaleIO Volume Config" 2020-05-20 22:01:00 +00:00
Luke Short
5c3e736e40 Allow the Mistral tunnel timeout to be configurable.
Change-Id: Ibfd5587476d5a411206f62e8b4b886db662bf7d1
Related-Bug:  #1872823
Signed-off-by: Luke Short <ekultails@gmail.com>
2020-05-20 11:20:52 -04:00