openstack/python-blazarclient
Code Issues Proposed changes

Remove use of mock.seal()

Browse Source 
The seal function was introduced in unittest.mock in Python 3.7. It is
preventing us from using unittest.mock instead of mock.

We can restore it when the minimum runtime is Python 3.7 or later.

Change-Id: Ieb26af07da0c4084fb8c4ea2c4d461eb5595f583
This commit is contained in:
Pierre Riteau
2021-02-23 15:10:51 +01:00
parent e875b75392
commit 1db6cb37c6
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
blazarclient/tests/v1/shell_commands/test_leases.py
View File

@@ -328,7 +328,6 @@ class ShowLeaseTestCase(tests.TestCase):
def test_show_lease(self): def test_show_lease(self):
show_lease, lease_manager = self.create_show_command() show_lease, lease_manager = self.create_show_command()
lease_manager.get.return_value = {'id': FIRST_LEASE} lease_manager.get.return_value = {'id': FIRST_LEASE}
mock.seal(lease_manager)
args = argparse.Namespace(id=FIRST_LEASE) args = argparse.Namespace(id=FIRST_LEASE)
expected = [('id',), (FIRST_LEASE,)] expected = [('id',), (FIRST_LEASE,)]
@@ -343,7 +342,6 @@ class ShowLeaseTestCase(tests.TestCase):
{'id': SECOND_LEASE, 'name': 'second-lease'}, {'id': SECOND_LEASE, 'name': 'second-lease'},
] ]
lease_manager.get.return_value = {'id': SECOND_LEASE} lease_manager.get.return_value = {'id': SECOND_LEASE}
mock.seal(lease_manager)
args = argparse.Namespace(id='second-lease') args = argparse.Namespace(id='second-lease')
expected = [('id',), (SECOND_LEASE,)] expected = [('id',), (SECOND_LEASE,)]
@@ -368,7 +366,6 @@ class DeleteLeaseTestCase(tests.TestCase):
def test_delete_lease(self): def test_delete_lease(self):
delete_lease, lease_manager = self.create_delete_command() delete_lease, lease_manager = self.create_delete_command()
lease_manager.delete.return_value = None lease_manager.delete.return_value = None
mock.seal(lease_manager)
args = argparse.Namespace(id=FIRST_LEASE) args = argparse.Namespace(id=FIRST_LEASE)
delete_lease.run(args) delete_lease.run(args)
@@ -382,7 +379,6 @@ class DeleteLeaseTestCase(tests.TestCase):
{'id': SECOND_LEASE, 'name': 'second-lease'}, {'id': SECOND_LEASE, 'name': 'second-lease'},
] ]
lease_manager.delete.return_value = None lease_manager.delete.return_value = None
mock.seal(lease_manager)
args = argparse.Namespace(id='second-lease') args = argparse.Namespace(id='second-lease')
delete_lease.run(args) delete_lease.run(args)