openstack/python-cinderclient
Code Issues Proposed changes

Fix the pep8 error on Noble

Browse Source 
pep8 job failing on Noble with below error.
Bumping the hacking version to 7.0.0 to fix it

     - AttributeError: 'EntryPoints' object has no attribute 'get'

Closes-Bug: #2088356

Change-Id: Ib168ad6842dfcf5cac8a85db973e339d2225b444
This commit is contained in:
Ghanshyam Mann 2024-12-11 19:53:45 -08:00
parent 7e30ba3d1c
commit 3120454508
4 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cinderclient/tests/unit/v3/fakes.py
View File

@ -401,16 +401,16 @@ class FakeHTTPClient(fakes_base.FakeHTTPClient):
return (200, {}, {'group_specs': {'k': 'v'}}) return (200, {}, {'group_specs': {'k': 'v'}})
def delete_group_types_1_group_specs_k(self, **kw): def delete_group_types_1_group_specs_k(self, **kw):
return(204, {}, None) return (204, {}, None)
def delete_group_types_1_group_specs_m(self, **kw): def delete_group_types_1_group_specs_m(self, **kw):
return(204, {}, None) return (204, {}, None)
def delete_group_types_1(self, **kw): def delete_group_types_1(self, **kw):
return (202, {}, None) return (202, {}, None)
def delete_group_types_3_group_specs_k(self, **kw): def delete_group_types_3_group_specs_k(self, **kw):
return(204, {}, None) return (204, {}, None)
def delete_group_types_3(self, **kw): def delete_group_types_3(self, **kw):
return (202, {}, None) return (202, {}, None)

12
cinderclient/tests/unit/v3/fakes_base.py
View File

@ -772,16 +772,16 @@ class FakeHTTPClient(base_client.HTTPClient):
return (200, {}, {'extra_specs': {'k': 'v'}}) return (200, {}, {'extra_specs': {'k': 'v'}})
def delete_types_1_extra_specs_k(self, **kw): def delete_types_1_extra_specs_k(self, **kw):
return(204, {}, None) return (204, {}, None)
def delete_types_1_extra_specs_m(self, **kw): def delete_types_1_extra_specs_m(self, **kw):
return(204, {}, None) return (204, {}, None)
def delete_types_1(self, **kw): def delete_types_1(self, **kw):
return (202, {}, None) return (202, {}, None)
def delete_types_3_extra_specs_k(self, **kw): def delete_types_3_extra_specs_k(self, **kw):
return(204, {}, None) return (204, {}, None)
def delete_types_3(self, **kw): def delete_types_3(self, **kw):
return (202, {}, None) return (202, {}, None)
@ -936,13 +936,13 @@ class FakeHTTPClient(base_client.HTTPClient):
{'restore': _stub_restore()}) {'restore': _stub_restore()})
def post_backups_76a17945_3c6f_435c_975b_b5685db10b62_action(self, **kw): def post_backups_76a17945_3c6f_435c_975b_b5685db10b62_action(self, **kw):
return(200, {}, None) return (200, {}, None)
def post_backups_1234_action(self, **kw): def post_backups_1234_action(self, **kw):
return(200, {}, None) return (200, {}, None)
def post_backups_5678_action(self, **kw): def post_backups_5678_action(self, **kw):
return(200, {}, None) return (200, {}, None)
def get_backups_76a17945_3c6f_435c_975b_b5685db10b62_export_record(self, def get_backups_76a17945_3c6f_435c_975b_b5685db10b62_export_record(self,
**kw): **kw):

7
cinderclient/v3/volumes_base.py
View File

@ -33,7 +33,7 @@ class Volume(base.Resource):
return self.manager.update(self, **kwargs) return self.manager.update(self, **kwargs)
def attach(self, instance_uuid, mountpoint, mode='rw', host_name=None): def attach(self, instance_uuid, mountpoint, mode='rw', host_name=None):
"""Inform Cinder that the given volume is attached to the given instance. """Inform Cinder if the given volume is attached to the given instance.
Calling this method will not actually ask Cinder to attach Calling this method will not actually ask Cinder to attach
a volume, but to mark it on the DB as attached. If the volume a volume, but to mark it on the DB as attached. If the volume
@ -54,9 +54,10 @@ class Volume(base.Resource):
host_name) host_name)
def detach(self): def detach(self):
"""Inform Cinder that the given volume is detached from the given instance. """Inform Cinder that the given volume is detached.
Calling this method will not actually ask Cinder to detach This inform Cinder that the given volume is detached from the given
instance. Calling this method will not actually ask Cinder to detach
a volume, but to mark it on the DB as detached. If the volume a volume, but to mark it on the DB as detached. If the volume
is not actually detached from the given instance, inconsistent is not actually detached from the given instance, inconsistent
data will result. data will result.

2
test-requirements.txt
View File

@ -3,7 +3,7 @@
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
# Hacking already pins down pep8, pyflakes and flake8 # Hacking already pins down pep8, pyflakes and flake8
hacking>=4.0.0,<4.1.0 # Apache-2.0 hacking>=7.0.0,<7.1.0 # Apache-2.0
flake8-import-order # LGPLv3 flake8-import-order # LGPLv3
docutils>=0.16 docutils>=0.16
coverage>=5.5 # Apache-2.0 coverage>=5.5 # Apache-2.0