openstack/python-cinderclient
Code Issues Proposed changes

Merge "Use immutable arg rather mutable arg"

Browse Source
This commit is contained in:
Jenkins
2014-12-21 16:15:41 +00:00
committed by Gerrit Code Review
parent 9ede59339e 31a7ae54f6
commit 59177814a4
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cinderclient/tests/fakes.py
View File

@@ -22,7 +22,10 @@ places where actual behavior differs from the spec.
from __future__ import print_function from __future__ import print_function
def assert_has_keys(dict, required=[], optional=[]): def assert_has_keys(dict, required=None, optional=None):
required = required or []
optional = optional or []
for k in required: for k in required:
try: try:
assert k in dict assert k in dict

4
cinderclient/tests/v1/test_shell.py
View File

@@ -81,8 +81,8 @@ class ShellTest(utils.TestCase):
# mimic the result of argparse's parse_args() method # mimic the result of argparse's parse_args() method
class Arguments: class Arguments:
def __init__(self, metadata=[]): def __init__(self, metadata=None):
self.metadata = metadata self.metadata = metadata or []
inputs = [ inputs = [
([], {}), ([], {}),

3
cinderclient/utils.py
View File

@@ -110,7 +110,8 @@ def _print(pt, order):
print(strutils.safe_encode(pt.get_string(sortby=order))) print(strutils.safe_encode(pt.get_string(sortby=order)))
def print_list(objs, fields, formatters={}, order_by=None): def print_list(objs, fields, formatters=None, order_by=None):
formatters = formatters or {}
mixed_case_fields = ['serverId'] mixed_case_fields = ['serverId']
pt = prettytable.PrettyTable([f for f in fields], caching=False) pt = prettytable.PrettyTable([f for f in fields], caching=False)
pt.aligns = ['l' for f in fields] pt.aligns = ['l' for f in fields]