openstack/python-cinderclient
Code Issues Proposed changes

Update link in HACKING.rst and Make it DRYer

Browse Source 
* Fix URL for global hacking doc, related to
  I579e7c889f3addc2cd40bce0c584bbc70bf435e2
* Remove section on locals, as its already in openstack-dev/hacking
  (http://git.openstack.org/cgit/openstack-dev/hacking/tree/doc/source/index.rst#n154)

Change-Id: If944b088f343404c5b90b02afe6f781dd1db914d
This commit is contained in:
Joe Gordon 2013-11-11 10:59:20 -08:00
parent d21ed05b4e
commit 6296974b1a
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
HACKING.rst
View File

@ -2,7 +2,7 @@ Cinder Client Style Commandments
=========================
- Step 1: Read the OpenStack Style Commandments
https://github.com/openstack-dev/hacking/blob/master/HACKING.rst
http://docs.openstack.org/developer/hacking/
- Step 2: Read on
Cinder Client Specific Commandments
@ -10,15 +10,6 @@ Cinder Client Specific Commandments
General
-------
- Do not use locals(). Example::
LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") %
locals()) # BAD
LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") %
{'vol_name': vol_name,
'vol_size': vol_size}) # OKAY
- Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised::
except Exception as e: