openstack/python-cinderclient
Code Issues Proposed changes

__repr__ crashes when empty dict passed

Browse Source 
The Capabilities class __repr__ method crashes when
along with any manager object, the info is passed as
empty dict.
This patch handles the issue.

Change-Id: Ife5cfc82137d107b27b011aa83c3a9c89e78d701
Closes-Bug: #1785091
This commit is contained in:
whoami-rajat
2018-08-02 17:06:05 +00:00
parent 460229c609
commit b3487484d8
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cinderclient/tests/unit/v2/test_capabilities.py
View File

@@ -53,3 +53,8 @@ class CapabilitiesTest(utils.TestCase):
cap = Capabilities(None, FAKE_CAPABILITY)
self.assertEqual(
"<Capabilities: %s>" % FAKE_CAPABILITY['namespace'], repr(cap))
def test__repr__when_empty(self):
cap = Capabilities(None, {})
self.assertEqual(
"<Capabilities: None>", repr(cap))

2
cinderclient/v2/capabilities.py
View File

@@ -22,7 +22,7 @@ class Capabilities(base.Resource):
NAME_ATTR = 'name'
def __repr__(self):
return "<Capabilities: %s>" % self._info['namespace']
return "<Capabilities: %s>" % self._info.get('namespace')
class CapabilitiesManager(base.Manager):