openstack/python-cinderclient
Code Issues Proposed changes

Replace assertTrue(isinstance()) by optimal assert

Browse Source 
assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests
should be replaced by assertIsInstance(A, B) provided by testtools.
Related-bug: #1268480

Change-Id: I755702d0f6e982d7cba173fbbdb86feb8ab384a0
This commit is contained in:
LiuNanke
2016-01-10 03:18:08 +08:00
parent 7476dbd8dc
commit c297309aff
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cinderclient/tests/unit/v2/test_type_access.py
View File

@@ -29,7 +29,7 @@ class TypeAccessTest(utils.TestCase):
access = cs.volume_type_access.list(volume_type='3') access = cs.volume_type_access.list(volume_type='3')
cs.assert_called('GET', '/types/3/os-volume-type-access') cs.assert_called('GET', '/types/3/os-volume-type-access')
for a in access: for a in access:
self.assertTrue(isinstance(a, volume_type_access.VolumeTypeAccess)) self.assertIsInstance(a, volume_type_access.VolumeTypeAccess)
def test_add_project_access(self): def test_add_project_access(self):
cs.volume_type_access.add_project_access('3', PROJECT_UUID) cs.volume_type_access.add_project_access('3', PROJECT_UUID)