Merge "refactor the getid method base.py"

This commit is contained in:
Zuul
2018-10-03 15:51:25 +00:00
committed by Gerrit Code Review
2 changed files with 5 additions and 13 deletions

View File

@@ -41,15 +41,10 @@ def getid(obj):
Abstracts the common pattern of allowing both an object or an object's ID
(UUID) as a parameter when dealing with relationships.
"""
try:
if obj.uuid:
return obj.uuid
except AttributeError:
pass
try:
return obj.id
except AttributeError:
return obj
if getattr(obj, 'uuid', None):
return obj.uuid
else:
return getattr(obj, 'id', obj)
# TODO(aababilov): call run_hooks() in HookableMixin's child classes

View File

@@ -53,10 +53,7 @@ def getid(obj):
Abstracts the common pattern of allowing both an object or an object's ID
as a parameter when dealing with relationships.
"""
try:
return obj.id
except AttributeError:
return obj
return getattr(obj, 'id', obj)
class Manager(common_base.HookableMixin):