openstack/python-cinderclient
Code Issues Proposed changes

Fix volume size units to match the API

Browse Source 
Both Horizon and the cinder client documents the size paramater in
gigabyes(GBs) but the API docs(both v1 and v2) list the size units as
gibibytes(GiBs). The correct unit should be gibibytes(GiBs). This
should help in clearing up any confusion on what units are used in
Cinder.

Closes-bug: 1511167
Change-Id: I42e15c18d1f084d435a2be9b343fb2f6c3cf377f
This commit is contained in:
Kurt Martin 2015-11-03 15:13:20 -08:00
parent 6e860e6e18
commit cb08ce33eb
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinderclient/v1/shell.py
View File

@ -214,7 +214,7 @@ def do_show(cs, args):
@utils.arg('size',
metavar='<size>',
type=int,
help='Volume size, in GBs.')
help='Volume size, in GiBs.')
@utils.arg(
'--snapshot-id',
metavar='<snapshot-id>',
@ -1039,7 +1039,7 @@ def do_transfer_show(cs, args):
@utils.arg('new_size',
metavar='<new-size>',
type=int,
help='Size of volume, in GBs.')
help='Size of volume, in GiBs.')
@utils.service_type('volume')
def do_extend(cs, args):
"""Attempts to extend size of an existing volume."""

4
cinderclient/v2/shell.py
View File

@ -282,7 +282,7 @@ class CheckSizeArgForCreate(argparse.Action):
nargs='?',
type=int,
action=CheckSizeArgForCreate,
help='Size of volume, in GBs. (Required unless '
help='Size of volume, in GiBs. (Required unless '
'snapshot-id/source-volid is specified).')
@utils.arg('--consisgroup-id',
metavar='<consistencygroup-id>',
@ -1520,7 +1520,7 @@ def do_transfer_show(cs, args):
@utils.arg('new_size',
metavar='<new_size>',
type=int,
help='New size of volume, in GBs.')
help='New size of volume, in GiBs.')
@utils.service_type('volumev2')
def do_extend(cs, args):
"""Attempts to extend size of an existing volume."""