1666 Commits

Author SHA1 Message Date
Sean McGinnis
eae7d55a07
Raise API max version for Stein updates
Functionality was added during stein, but the MAX_VERSION of the client
was not updated for these versions. This raises the version to support
the added functionality.

3.57 - Improve volume transfer records - no client changes
3.58 - Add project_id to group - no client changes

3.59 is not included here as that adds sort and pagination that will
need to be slightly reworked before we expose it.

Change-Id: If8a3b88b9a2811ae6681e52dbca62b906d3542eb
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2019-04-17 10:35:23 -05:00
Sean McGinnis
44061cfab2
Add support for backup user ID
Backup user_id was added with microversion 3.56 but never added to the
client. Added in Rocky with I3ffb544ef3ee65276cee8b1e870d524fd0e57085.

Change-Id: Ib9a4159db0f8af599dcf8315334de4f859be077e
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2019-04-17 09:59:44 -05:00
Sean McGinnis
b843a168ef
Raise API max version for Rocky updates
Functionality was added during rocky, but the MAX_VERSION of the client
was not updated for these versions. This raises the version to support
the added functionality.

3.53 - Schema validation - no client changes
3.54 - Add mode option to attachment-create:
    I22cfddd0192c4a72b8f844f23d1fa51b96c57e06
3.55 - Transfer snapshots with volumes
    I61a84b5abf386a4073baea57d8820c8fd762ae03

Change-Id: I8c8fb8f552e529c8474a3e3b771ba8eb7aed193a
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2019-04-17 09:36:55 -05:00
whoami-rajat
8ff86a1706 Drop use of git.openstack.org
Our cgit instance will be going away and opendev.org is the new
preferred URL for browsing our git repos. Redirects will exist for the
foreseeable future, but it's more efficient to just go directly to the
new locations.

Cinder patch : https://review.openstack.org/#/c/652774/

Change-Id: I355982de70c214bd4929c061507076c98b8ad8d2
2019-04-17 14:06:35 +05:30
whoami-rajat
6a498163e2 Add 'is_public' support in '--filters' option
'--is-public' is a valid argument for cinder type-list command[1]
and cinder group-type-list command but is missing in cinderclient.
This patch adds the support for it.

[1] https://developer.openstack.org/api-ref/block-storage/v3/?expanded=list-all-volume-types-detail#list-all-volume-types

Change-Id: I8af9bb06a28f3cc384c4925b8b52bdeaed52cb15
2019-04-15 08:36:27 +00:00
Eric Harney
274fa11169 Fix shell upload-to-image with no volume type
Upload-to-image would error after launching
the operation if the volume type is None.

Closes-Bug: #1821818
Change-Id: I015e0ddfa98d62f25334e2df5effaee72a3988ab
2019-04-03 11:34:40 -04:00
Eric Harney
0707191d43 Remove bash-completion calls from base.py
This should not be here since this is client
library code, but it isn't needed anyhow since
this completion is handled from the shell code.

Closes-Bug: #1817782

Change-Id: I3e7ddbe4a50a66db8961a71d71592ce708320b0d
2019-04-02 18:08:57 +00:00
Zuul
15295acb07 Merge "Tests: Don't write bash-completion cache files" 2019-04-02 16:51:47 +00:00
Zuul
8804b7c978 Merge "Replace openstack.org git:// URLs with https://" 2019-03-26 18:30:36 +00:00
Ian Wienand
c7ec64a9a8 Replace openstack.org git:// URLs with https://
This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.

This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.

This update should result in no functional change.

For more information see the thread at

 http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html

Change-Id: I0988958c8050e5501ef2213876991d17bd51d163
2019-03-24 20:35:48 +00:00
Zuul
97efb72661 Merge "Remove py35 from setup.cfg" 2019-03-22 19:12:52 +00:00
40287a50f4 Update master for stable/stein
Add file to the reno documentation build to show release notes for
stable/stein.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/stein.

Change-Id: Iaa9a39c33d76b90fbfd60adc6b729cacde69e0a0
Sem-Ver: feature
2019-03-18 14:49:42 +00:00
Eric Harney
17a1c4a14a Add bash completion for groups
Completion for group create/list.

Change-Id: I0b7027a72a3bc8ad7ca7323c6dbe0a501616cdd5
2019-03-07 12:25:06 -05:00
whoami-rajat
6c55e38fe5 Remove py35 from setup.cfg
This is a followup to Drop py35 jobs from gate and tox env[1].

[1] https://review.openstack.org/#/c/639388/

Change-Id: Ie6d897db48013b8b845cb5068da76a7c68e0e666
2019-02-28 11:05:39 +05:30
Eric Harney
a39805c6f4 Tests: Don't write bash-completion cache files
Mock out writing of bash-completion cache files
during unit tests.

Related-Bug: #1817782

Change-Id: I944862c30fb4684dd034eba6953e9302d2d22439
2019-02-26 14:33:51 -05:00
Sean McGinnis
8de1f789c5
Drop py35 jobs
Python 3.5 was the target runtime for the Rocky release. The current
target py3 runtime for Stein is Python 3.6, so there is no reason to
keep testing against the older version.

https://governance.openstack.org/tc/reference/runtimes/stein.html#python-runtime-for-stein

Change-Id: I8fbcde0573eddc1763104e0f812f93489a1b48e3
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2019-02-26 11:02:07 -06:00
Zuul
dc6e24f7d7 Merge "Fix: cinder group-list not working with non-admin user" 2019-02-25 23:09:28 +00:00
Zuul
0ca31c0425 Merge "add python 3.7 unit test job" 2019-02-25 22:16:03 +00:00
Zuul
3a6dc4d468 Merge "Fix bash_completion cache path" 2019-02-21 22:17:53 +00:00
Zuul
4e2952ea27 Merge "Add dependency on requests lib" 2019-02-21 20:01:36 +00:00
Eric Harney
7ee806f218 Fix bash_completion cache path
In change 4cf62cf3 we started writing the
cache to ~/.cache/cinderclient/ - this script
needs to read from there.

Related-Bug: #1712835

Change-Id: Ib4de058af6b636d06ac360fe448b432e8e7733ad
2019-02-20 10:15:56 -05:00
whoami-rajat
532aef0c73 Fix: cinder group-list not working with non-admin user
The all_tenants filter is passed to API when it's value is 0
(when not specified) which shouldn't be the case.
This patch only allows adding of all_tenants when specified
manually by user.

Change-Id: Ic7810c4d6e9f4be7c28c7a8778d57bb5ccb996a0
Closes-Bug: #1808621
Closes-Bug: #1808622
2019-02-18 14:34:35 +05:30
Corey Bryant
3c1e5b6a44 add python 3.7 unit test job
This is a mechanically generated patch to add a unit test job running
under Python 3.7.

See ML discussion here [1] for context.

[1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135626.html

Change-Id: Ia1bc00770fe99f044d492c5dd18349373b8602a4
Story: #2004073
2019-02-15 15:24:00 -05:00
Zuul
41d6ce3c3d Merge "Change bash completion dir permissions to 0750" 2019-02-15 18:47:14 +00:00
Zuul
4382c1cde9 Merge "Add Python 3.6 classifier to setup.cfg" 2019-02-15 17:52:01 +00:00
Brian Rosmaita
5c850bd855 Remove nonexistent job from gate
This is a follow-up to https://review.openstack.org/#/c/635321/
which removed a job configuration but missed removing the
reference to that job in the gate config.

Change-Id: If81145a743cec4070281b9f1369f101d4008e373
2019-02-13 13:47:47 -05:00
Eric Harney
a952c550b3 Add dependency on requests lib
cinderclient uses the requests library.

Change-Id: I2944ce54a304cb91f456c6c53daf2f083017c929
2019-02-13 09:57:45 -05:00
Brian Rosmaita
2e059b6d44 Remove dsvm-functional-identity-v3-only job
The cinderclient-dsvm-functional-identity-v3-only job is exactly
like the cinderclient-dsvm-functional job, except that it sets
the devstack config option ENABLE_IDENTITY_V2 to False.  Change
I5afcba6321f496b8170be27789bee7c9ad8eacce in devstack from back
in 2017 makes False the default value for this option.  Hence we
already have a gate job that uses identity v3, so remove the
redundant job.

Change-Id: I9b69bf765c9a59b6b77c2bc351c20e2917b82459
2019-02-12 15:18:59 -05:00
Brian Rosmaita
2abfb558ef Don't run DSVM tests for doc changes
Don't waste resources running the dsvm-functional tests on doc-only
changes.

Change-Id: Ie18427499c170ee315181040eaa0943f3fefed08
2019-02-06 16:16:46 -05:00
Zuul
0c89c0143b Merge "Cleanup the home page" 2019-02-06 20:33:28 +00:00
Sean McGinnis
bccbd510a7 Fix max version handling for help output
Commit fefe331f218d73ba6d1d7acf81b5eb02609c953e incorrectly set the
default API version to the max the client knew about in order to get the
full help output, including all microversioned commands.

The original intent was to have help print out information for all
versions, but still require the user to specify a version if they wanted
to use any microversioned version of an API. The code accidentally made
it so all commands would request the max version the client knew about.
This meant an unspecified request would get the newer functionality
rather than the default v3 functionality, and also meant the client
could request a microversion higher than what the server knew about,
resulting in an unexpected error being returned.

To keep the originally intended functionality, but keep all help output,
this only uses the max API version for the help command unless the user
specifies otherwise.

Closes-bug: #1813967

Change-Id: I20f6c5471ffefe5524a4d48c967e2e8db53233f1
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2019-01-30 19:00:51 -06:00
Zuul
cca017218a Merge "Remove i18n.enable_lazy() translation" 2019-01-30 12:37:25 +00:00
yenai
a8cd90a760 Fix incorrect punctuation
Change-Id: I70e1ad2d0152e74ab0672a3ac2e7b47f85ee92d7
2019-01-28 14:40:45 +08:00
Eric Harney
e40166740e More shell completion cache additions
Closes-Bug: #1712835
Change-Id: I9326d5d92ff2e93dd0398d9a115210b376059064
2018-12-21 06:16:55 +00:00
Zuul
3c143d95b3 Merge "Re-enable shell UUID completion cache" 2018-12-19 17:39:19 +00:00
Eric Harney
2505e2a903 Fix doc build error
Doc build keeps failing w/

Recursion error:
    maximum recursion depth exceeded while pickling an object

Sphinx recommends bumping up the recursion limit to
get around this, and it appears to work.

Change-Id: If0a78f9af2e4ddd5fd88c44757642355b3a5bf2e
2018-12-14 11:43:56 -05:00
Eric Harney
7319a40767 Re-enable shell UUID completion cache
This enables writing ids to a local completion
cache when using the cinderclient shell, which
allows tools/cinder.bash_completion to complete
commands such as
    cinder delete a<tab>

Volume ids are recorded on "cinder list" and
"cinder create" operations, similar for backup ids.

This functionality was unintentionally removed in
changes some time ago.  Labeled as Partial-Bug
because I haven't added name caching yet, which also
used to exist.

Partial-Bug: #1712835
Change-Id: Id56aa43b061758a00a2a8c9c92a5a33ab9f7ab84
(cherry picked from commit c4b37c2830fdd90b57383a93e09a8bd40ca41221)
2018-12-14 11:41:34 -05:00
Eric Harney
5d2116e747 Change bash completion dir permissions to 0750
This is no reason for this dir to be world-readable.

Change-Id: I50e85b5bb6116c64535ecbf09718141086c703c5
2018-12-05 10:51:43 -05:00
Joshua Cornutt
4cf62cf31f Change cache uniqifier from using md5 to sha-1
FIPS 140-2 does not allow MD5 use for most purposes and systems
in "FIPS mode" (fips=1 kernel flag) will cause software using
MD5 from popular libraries to fail.

Also change the default cache dir to use ~/.cache/

Change-Id: I6f653f10249992196abb04e05c54df5fb244b182
2018-12-05 10:51:42 -05:00
Matt Riedemann
85a3f0e30d Cleanup the home page
Good lord this thing needed some love. This change
does a few things:

* Remove the duplicate man page.
* Rename some titles to drop the CINDERCLIENT yelling -
  this is docs about cinderclient, I get it, no need to
  repeat in all caps.
* Fixed the sub-section title formatting in the home page.
* Dropped the duplicate usage guide wording and simply linked
  to the user docs from the home page.

Change-Id: I259787a40151e8c875ad87021f655a141e06b15e
2018-12-04 17:32:19 -05:00
Zuul
7cb50b4c4a Merge "Change openstack-dev to openstack-discuss" 2018-12-04 13:55:40 +00:00
sunjia
c6fdd2a67d Change openstack-dev to openstack-discuss
Mailinglists have been updated. Openstack-discuss replaces openstack-dev.

Change-Id: Iee7d2087d7015f49e96345d96217a150bb1c23e2
2018-12-03 21:50:20 -05:00
qingszhao
75bc7e50f4 Add Python 3.6 classifier to setup.cfg
Change-Id: I8eb981871397e1d9ae84e775d4e68915c06ecef7
2018-11-29 09:10:26 +00:00
Sean McGinnis
4b0f5876d6
Remove i18n.enable_lazy() translation
Per [1], don't.

[1] http://lists.openstack.org/pipermail/openstack-dev/2018-November/136289.html

Change-Id: I4a1e8cf84a88e5bd301d1baba41b064cde336f38
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-11-13 09:47:05 -06:00
Zuul
bfcda5000e Merge "Replace assertRaisesRegexp with assertRaisesRegex" 2018-11-10 10:16:39 +00:00
Sean McGinnis
e26b64c1a3
Fix incorrect use of flake8:noqa
Adding the comment flake8:noqa in a file will skip linting the entire
file. Most of the time, the intent was just to skip individual lines to
handle exception cases.

This gets rid of the "flake8:" prefix where it was used incorrectly and
fixes a few legitimate errors that were being hidden by the entire file
being skipped.

The behavior is change in flake8 to handle this better, which will
result in pep8 job failures if these are not fixes first. See more
information in the 3.6.0 release notes:

http://flake8.pycqa.org/en/latest/release-notes/3.6.0.html#features

Change-Id: I56cb20a7c8885c101826d4fe28c315de02b6ecb8
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2018-10-26 13:26:29 -05:00
Vieri
3b954791e4 Don't quote {posargs} in tox.ini
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')

Change-Id: Ieeae90ecbd4f89cbff0513dcd949a0c1a8e8d8c1
2018-10-09 13:45:27 +00:00
Zuul
4e17e1d191 Merge "Fix encoding of query parameters" 2018-10-03 17:54:19 +00:00
Zuul
c73844df2d Merge "refactor the getid method base.py" 2018-10-03 15:51:25 +00:00
Zuul
e9658c6ef6 Merge "Fix backwards compat for volume transfer < 3.55" 2018-10-02 17:33:26 +00:00