335 Commits

Author SHA1 Message Date
Peter Hamilton
6fd8d8e12e Require ctrl_location for encryption-type-create
This bug fix addresses bug #1267168, adding a default value to the
optional control_location parameter for the encryption-type-create
command. Prior to this fix, any invocation of encryption-type-create
that omitted the control_location parameter would fail. The failure
arose from the expectations of the cinder volume encryption type
API extension, which expects to always receive a value for the
control_location on encryption type creation.

control_location indicates which service will conduct the volume
encryption for the encryption-type under consideration; valid options
are 'front-end' (i.e., nova) and 'back-end' (i.e., cinder). The new
default value is 'front-end' and is used whenever control_location
is omitted from encryption-type-create invocation. For prior
discussion and information, see the abandoned patch below:

https://review.openstack.org/#/c/58303/

blueprint encrypt-cinder-volumes
https://blueprints.launchpad.net/nova/+spec/encrypt-cinder-volumes

Change-Id: I8db80929adbf5a3d818b9d3a8115067ae8e7d9e2
Closes-Bug: #1267168
DocImpact
2014-02-12 21:38:41 +02:00
Jeremy Stanley
7914e46b03 Remove tox locale overrides
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.

Change-Id: Ibd505447de74f13d90b9ff77dfd8c6b30c4c12cb
Closes-Bug: #1277495
2014-02-10 03:09:27 +00:00
Swapnil Kulkarni
4273bbefb9 Fix typos in cinderclient
Small nit-pics in volume_transfers.

Change-Id: I846b38970b14e6385269a02bb495c63464ea0842
Closes-Bug: #1255905
2014-02-05 16:23:23 +02:00
Mike Perez
e31e057ccc Revert "Update cinderclient to skip the additional GET during create"
This reverts commit 47014971b09f0334e5cc3b414bef31784f88a37d.

Conflicts:
	doc/source/index.rst

Change-Id: Ica1e526b2c181d1ce72183b7293d21119371c822
2014-02-04 14:14:22 -07:00
Jenkins
e0132e5206 Merge "Fixed image_name from image-name in upload-to-image" 2014-02-03 04:21:40 +00:00
john-griffith
305f760939 Update release notes for push to pypi
Need to get a 1.08 out, so just modifying the release notes
for the push version.

Change-Id: Icf9684ab0fabf0168662c3ff4047db54a2670d11
2014-02-02 09:25:27 +02:00
Andrew Kerr
019f43f63f Fixed image_name from image-name in upload-to-image
This fix addresses an issue where the variable name for image_name
was incorrect, causing the image_name parameter to be sent as null
when using "cinder upload-to-image" from cli with v2 of the API

Change-Id: I62f8bbb4397526fb291a46777d9025318da8e5b3
Closes-Bug: 1274552
2014-01-31 18:39:04 -05:00
Jenkins
7d7b7d2893 Merge "Sync up with oslo-incubator" 2014-01-30 01:31:20 +00:00
Eric Harney
306d451bc7 Add shell tests for snapshot_delete
snapshot_delete does not have a shell test covering it.

Closes-Bug: #1257747

Change-Id: I22252f5025c11a7c115aa75e07c78424eec75ba1
2014-01-27 13:48:12 -05:00
Jenkins
dd92af2a9e Merge "Remove RAX-specific auth in cinderclient" 2014-01-27 07:16:09 +00:00
Swapnil Kulkarni
c5b5646f9e Sync up with oslo-incubator
be81d6b Cleanup unused log related code
e53fe85 strutils bool_from_string, allow specified default
12bcdb7 Remove vim header
12d3bbc Add method quote_plus in module py3kcompat.urlutils
afdbc0a Fix E501 in individual openstack projects

Oslo Version:
8dee4b6 Merge "remove extra newlines that eventlet seems to add"
Thu, 23 Jan 2014 14:26:42 +0530 (08:56 +0000)

Change-Id: I7348e797a4a78ec20dff77ebdbb41bb8c6068b34
2014-01-26 16:13:11 +05:30
Avishay Traeger
17d7455d27 Add retype to index.rst
Retype patch was merged but not added to index.rst

Change-Id: I15e52153fccf07026d4b1dfcc1fb62a27d6d3ca2
2014-01-26 09:28:48 +02:00
Jenkins
3b92c27deb Merge "Add volume retype command" 2014-01-26 06:18:23 +00:00
Jenkins
4fca766f4e Merge "Unit tests for limits.py in cinderclient/v1 and v2" 2014-01-25 23:36:43 +00:00
Avishay Traeger
58d8a00a57 Add volume retype command
Add volume retype to Cinder client.
Cinder code: https://review.openstack.org/#/c/44881/

Change-Id: Ied4902da531386f744403962e4a8ddfb7587c4ef
2014-01-25 15:55:23 -07:00
Jenkins
36a92e1286 Merge "disable/enable a service has no output" 2014-01-25 14:23:20 +00:00
Jenkins
560df45093 Merge "Fix 'search_opts' unexpected keyword argument error" 2014-01-25 06:38:20 +00:00
Swapnil Kulkarni
fbee97cf19 Remove RAX-specific auth in cinderclient
Change-Id: Idd36694a322f467ba5e8c1f58bfac701bff8f3f8
Closes-Bug: #966329
2014-01-25 08:22:13 +05:30
Jenkins
e2642796b8 Merge "Add encryption-type-delete to cinderclient" 2014-01-24 11:39:12 +00:00
Jenkins
6cbf648881 Merge "Remove copyright from empty files" 2014-01-23 03:07:16 +00:00
Jay Lau
c2ef5eaf49 disable/enable a service has no output
When disable/enable a cinder service, there is no output, this
caused end user does not know if the service was disabled/enabled
successfully.

It is better add some output for the command just like nova to tell
end user the service status.

Change-Id: I9d440ab7437c268b17627e255f152db0b3bf4f53
Closes-Bug: #1261120
2014-01-21 22:57:23 +08:00
Xiao Chen
2f0863b7d4 Fix 'search_opts' unexpected keyword argument error
When executing 'encryption-type-create' command using resource
name, it will use the findall() in base.py, then error will
occur because list() in findall() used 'search_opts' argument
which list() in VolumeEncryptionTypeManager did not have. Some
other command like 'transfer-delete' met same issue.

This patch will add 'search_opts' argument in list() function
in child class to avoid the bug.

Closes-Bug: #1248519
Related-Bug: #1252665

Change-Id: If1cd8b812af21335e5d4351766539a927a8fbdf4
2014-01-20 15:43:31 +08:00
Dirk Mueller
a1a36499f4 Remove dependencies on pep8, pyflakes and flake8
They should be determined by the hacking dependency
implicitely.

Change-Id: I5c077e4b8e5985e86af3229a58aa475ac668b5e1
2014-01-16 13:19:28 +01:00
Alexander Ignatov
69188a9551 Remove copyright from empty files
According to policy change in HACKING:
http://docs.openstack.org/developer/hacking/#openstack-licensing
empty files should no longer contain copyright notices.

Change-Id: I357adea1d295cdc11a12194ad7116d73a8560122
Closes-Bug: #1262424
2014-01-16 02:12:43 +04:00
Igor A. Lukyanenkov
efc080dfca Unit tests for limits.py in cinderclient/v1 and v2
Change-Id: I962161ac657d9ec676f3b03ab17138ed1911ec35
2014-01-13 16:17:16 +04:00
Swapnil Kulkarni
47014971b0 Update cinderclient to skip the additional GET during create
With change https://review.openstack.org/64945 cinder V2 API now
returns volume details. Updated do_create in cinderclient
to remove additional GET call.

Change-Id: I2a36f2fa865b52f228bad44e0a9c67d49228321e
Partial-Bug: #1265893
2014-01-08 13:37:41 +05:30
Jenkins
2d155ecb07 Merge "Updates .gitignore" 2014-01-07 09:31:34 +00:00
Jenkins
a33240f578 Merge "Updates .gitignore for environment files" 2013-12-31 20:41:38 +00:00
Igor A. Lukyanenkov
1fc1b4bea1 Fix RateLimit.__repr__ - self.method is undefined
Using self.verb instead of self.method, unit tests added to cover this fix.

Closes-bug: #1258489

Change-Id: I4a84179ff96c50b230afcaea7a19fb54613577fb
2013-12-31 18:00:24 +04:00
Zhenguo Niu
12ee7b72ff Fix inappropriate comment for volume update api
Change-Id: Id7a436cc864772bd2662fce0ef80d647c9e3dcf0
Closes-Bug: #1264415
2013-12-27 10:38:25 +08:00
Sushil Kumar
2e1d92bd6d Updates .gitignore for environment files
Adding ignore for Eclipse IDE environment files
These files .project and .pydevproject should be
ignored while pushing to repositories.

Change-Id: I44dbdaae71c3ed37c11122f1795d36c401dd431a
Closes-Bug: #1256043
2013-12-23 20:21:11 +00:00
Sushil Kumar
420a8fdcea Updates .gitignore
Remove files we don't generate in the sources.

Closes-Bug: #1256043

Closes-Bug: #1257279

Change-Id: I18552182958448baa040c988b02affc231cbf62b
2013-12-18 09:28:47 +00:00
Jenkins
a2b9bdd36c Merge "Discrepancy between README.rst and cinder help" 2013-12-17 07:14:51 +00:00
Jenkins
78a09e94d3 Merge "Updates tox.ini to use new features" 2013-12-17 03:54:07 +00:00
Chris Buccella
97f293fea2 Discrepancy between README.rst and cinder help
1) --version in README should be --os-volume-api-version

2) CINDER_URL should be OS_AUTH_URL

Change-Id: I409634f3025463f2ae9419ddd0d99fa50554a04d
Closes-Bug: 1251385
2013-12-15 10:25:26 +02:00
Jenkins
b6f9364f54 Merge "Fix broken argument name in v2 volume extend routine" 2013-12-12 19:47:05 +00:00
Jenkins
1c3c79b19e Merge "Reset-state and snapshot-reset-state for multiple objects" 2013-12-12 19:47:03 +00:00
OpenStack Jenkins
1cfd71c776 Updated from global requirements
Change-Id: I53edc66fe4d112ee6f341aa39943630a74c08a87
2013-12-10 23:45:12 +00:00
Jon Bernard
c6a85e0c1c Fix broken argument name in v2 volume extend routine
The new_size attribute was misspelled, causing the volume extend
operation to fail with:

    ERROR: 'Namespace' object has no attribute 'new_size'

This happens only with the v2 API, v1 works fine.

Change-Id: Icb6b5008dad229f21e7906d9b5342d41f5e760cd
Closes-Bug: #1259552
2013-12-10 08:46:27 -05:00
Sushil Kumar
3f5f9b44d6 Updates tox.ini to use new features
Reasons:
 - tox update v1.6

Changes:
 - tox 1.6 allows us to skip the sdist step, which is slow.
 - It also allows us to override the install line. In this case, it's
   important as it allows us to stop getting pre-release software we
   weren't asking for.

Original patch by Monty Taylor, talked about here:
http://lists.openstack.org/pipermail/openstack-dev/2013-September/015495.html

Change-Id: I8a8fdd420eceb5b702e7d9eedd8b5be341d3f56e
2013-12-09 15:30:47 +00:00
Eric Harney
0e2bd33265 Reset-state and snapshot-reset-state for multiple objects
This allows a user to call reset-state or snapshot-reset-state on a
list of objects.  The behavior is modeled after a similar change to
delete multiple volumes.

$ cinder reset-state good_volume good_volume_2
<no output>

Error behavior is as follows:

One success/one failure:
$ cinder reset-state good_volume asdf
Reset state for volume asdf failed: No volume with a name or ID of 'asdf' exists.

One failure:
$ cinder reset-state asdf
ERROR: Reset state for volume asdf failed: No volume with a name or ID of 'asdf' exists.

Two failures:
$ cinder reset-state asdf qwert
Reset state for volume asdf failed: No volume with a name or ID of 'asdf' exists.
Reset state for volume qwert failed: No volume with a name or ID of 'qwert' exists.
ERROR: Unable to reset the state for any of the specified volumes.

Related-Bug: 1241941
Closes-Bug: 1256069
Change-Id: Id0a36fb7de0d69be0dac98ea04e4708775250b7a
2013-12-04 08:58:19 -05:00
Zhenguo Niu
8fc5ae480e Ignore swap files generated during file edting by vim
To ignore swap files from getting into repository
currently the implemented ignore is *.swp
however vim adds more swap files if these files exists,
so improving this with .*.sw?

Change-Id: I11965d5fb22aeae622dad8bb29cf1f0533ed439a
Closes-Bug: #1255876
2013-12-04 09:39:50 +08:00
Vincent Hou
e64973f9a7 Add search_opts into the method list() for VolumeTypeManager
Since the method base.ManagerWithFind.findall has been modified by
adding the search_opts for all tenants support, the parameter
search_opts should also be added to all the manager classes, which
can be called whithin this method. volumetypemanager does not have
this parameter for its method list(). Adding search_opts will resolve
this issue.

Closes-Bug: #1252665

Change-Id: I526500625f1b5483cb5d88ea15e6ac8485a66ae3
2013-12-03 11:59:19 +02:00
Jenkins
1aa375ae43 Merge "Add assert to delete multiple test" 2013-12-03 09:32:15 +00:00
Jenkins
15b10a0550 Merge "Update HACKING.rst with release note requirement" 2013-12-03 09:32:11 +00:00
Jenkins
37eeebe268 Merge "Fix string representation of VolumeBackupsRestore" 2013-11-30 23:01:20 +00:00
Avishay Traeger
c33dd1b842 Add assert to delete multiple test
Make sure calls are made to delete both volumes. Also removed redundant
fields in v1 fake volume.

Closes-Bug: #1253142
Change-Id: I51078041c6d765f28edb155d44928286ee2b0dd6
2013-11-28 11:30:49 +02:00
huangtianhua
5aaa68f09e Fix typo in cinderclient
sematics --> semantics
hypen-separated --> hyphen-separated
typicaly --> typically

Change-Id: I5df277ef7036082d0e4b079c23d41da809e5270f
Closes-Bug: #1254587
2013-11-28 09:28:05 +08:00
Stephen Mulcahy
3447532ba6 Fix string representation of VolumeBackupsRestore
Change string representation of VolumeBackupsRestore to use
volume_id rather than non-existent VolumeBackupsRestore id.

Change-Id: I7b585d0de9b3b0511e7fd1a70b214090a17dfa93
Closes-Bug: #1255488
2013-11-27 11:05:42 +00:00
wanghao
e8a0e6abdf Fix inappropriate comment for set_metadata
Fix inappropriate comment for the param of set_metadata

Change-Id: I01495f59b11ed88389b0e0f2f5fb34289f64dbac
Closes-Bug: 1254951
2013-11-26 08:07:16 +02:00