Added request_ids attribute to resource object for all the
volume_backups, volume_encryption_types and volume_transfers
APIs by updating following APIs:
volume_backups: reset_state, delete, export_record, import_record
volume_transfers: delete
volume_encryption_types: list
Returning list with request_ids as attribute in case of 'list' API
for volume_encryption_types.
These changes are required to return 'request_id' from client to log
request_id mappings of cross projects.
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
DocImpact
'request-ids' will be returned as an attribute with response object.
User can access it using 'res.request_ids' where 'res' is a
response object.
Change-Id: I2197ca38f6c9a8b0ced5c82d29676b49c9700b09
Partial-Implements: blueprint return-request-id-to-caller
Updated TupleWithMeta class to make it consistent with other Meta
classes in order to avoid confusion. Also made provision to call
TupleWithMeta with a tuple containing one or more elements.
For more details on how request_id will be returned to the caller,
please refer to the approved blueprint [1] discussed with the
cross-project team.
[1] http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html
Change-Id: I5a79a4ed8cb4dc83ea3b64499df191750462100d
Partial-Implements: blueprint return-request-id-to-caller
While "cinder snapshot-delete" and "cinder delete" allow multiple resources to be deleted in a single command, "cinder backup-delete" request can only delete one backup at a time. Adding this capability to backups in cinderclient. Enables "cinder backup-delete" to delete multiple backups in a single command.
With this change the command can be run as below:
cinder backup-delete <backup> [<backup>...]
DocImpact
Closes-Bug: #1543056
Implements: blueprint cli-backup-multiple-deletes
Change-Id: I767710bda3b7c358c6525c9a9f074010084e411d
1. Wrong use of 'noqa'. "# flake8: noqa" option disables all checks
for the whole file.
2. Remove exclusion of 'tools' and '*openstack/common*' in flake8 and
fix the violations.
Change-Id: I153e992ffd6a80e70a99d7066c503c34326c93ab
Closes-bug: #1540254
We found in a recent review that one of my debug
print statements was accidentally let in an
earlier patch. This patch removes my debug code.
Change-Id: I1d1baaed4362d499b1c141f0eba36dfe883d0e3a
In output of cinder type-update execution, is_public field
always displays N/A.
This is due to wrong usage of @property for is_public field
in code.
Change-Id: I1d76c3d5c937f5c16c668bd114e2df7dfc62f2f8
Closes-Bug: #1538412
Return appropriate wrapper classes with request_ids attribute from
base class.
Note:
In cinderclient/base.py->_update method will return None for
qos_specs->unset_keys method and for all other cases it returns body
of type dict. At few places, wherever the _update method is called,
it converts the return value back to the resource class and in all
other cases the same return value is returned back to the caller.
It's not possible to return request_ids with None so for all cases
object of DictWithMeta will be returned from this method. Second
approach would be to return (resp, body) tuple from _update method
and wherever this method is called, return the appropriate object.
These changes will affect v1 version and since v1 is already
deprecated the above approach sounds logical.
This change is required to return 'request_id' from client to log
request_id mappings of cross projects.
Change-Id: If73c47ae2c99dea2a0b1f25771f081bb4bbc26f1
Partial-Implements: blueprint return-request-id-to-caller
Added wrapper classes which are inherited from base data types list,
tuple and dict. Each of these wrapper classes contains a 'request_ids'
attribute which will be populated with a 'x-openstack-request_id'
received in a header from a response body.
This change is required to return 'request_id' from
client to log request_id mappings of cross projects.
Partial-Implements: blueprint return-request-id-to-caller
Change-Id: I3aadb4d8bf675e20f2094b66a23ac20f455a99eb
The sort in command snapshot-list and backup-list
doesn't work, and they show same results.
The patch is to fix the problem, and transfer
sortby_index as None in utils.print_list.
Closes-Bug: #1536054
Change-Id: I00760fd4b395b04b95a8139224e18ea8d649d377
Use six.moves.urllib.parse instead of urllib.
For urllib2 compatibility, it need to sync policy
module from oslo first. Then six.moves.urllib.request
can replace urllib2.
Change-Id: Ia351cd3088dd64fd8c8ce4ca8b9a5889c574888e
Partial-Bug: #1280105
This patch changes extension suffix from 'python_cinderclient_ext' to
'cinderclient_ext' to get more shorter module names.
Change-Id: Id78e05646d2bc4fda758710eb630dca5eefa457f
Word misspelling in following message:
1. shell.py
help='A unqiue identifier that represents a failover target.'
2. volumes.py
:param secondary: A unqiue identifier that represents a failover
Should change the word 'unqiue' to 'unique'.
Change-Id: I44a94b403f0bb71864d03683bdaf3b98f4d73bb1
assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests
should be replaced by assertIsInstance(A, B) provided by testtools.
Related-bug: #1268480
Change-Id: I755702d0f6e982d7cba173fbbdb86feb8ab384a0
Heat wants to use
`cinderclient.shell.OpenStackCinderShell._discover_extensions`
function (https://bugs.launchpad.net/heat/+bug/1527071),
which is private currently. It's better to change this method
to public for public use.
This change will do it as novaclient did.
Change-Id: Iaaa4cab530fd495877e15a372fff1354ddbeaa17
Closes-Bug: #1527169
We are already use Cinder API v2 by default so it sould be consistent to
use 'volumev2' service type by default
Change-Id: I9f2da310f6ad53a40d476ede62369cc364371064
Pass OS_* env variables for functional tests to use environment
variables if they are available instead of config file
Change-Id: Ic1b4752bf558c57974b5f2a4d5a45aee4a940bbb
Before, when API in cinderclient was set to v2, the issued call
used to fail with an error message, that the call is connecting
to the endpoint compatible to API v1, when other quota calls
were connecting to the proper, v2 enpoint.
Change-Id: I99a16e93ed15e3819d48d193b550c786012462d8
Closes-Bug: 1526829
Many clients have to_dict method in Resource class.
It is needed to get full info about resource.
So it would be nice to add to_dict method in
cinder client too.
Now openstack/common has graduated from oslo-incubator.
So we just modify it cinderclient.
Changes merged with this patch:
---------------------
apiclient/base.py
---add to_dict function in class Resource.
unit/test_base.py
---add unit test case.
change-Id: I81add424bcdd667ba271adb7d5b1ceb504120f93
Cinder list command was intended to show summary of
volumes, but currently the command shows many entries
than we expected.
This patch adds these two fixes to show volume list
more simply.
- Remove 'migration status' and 'multiattach' from
default list view.
- Add '--field' optional argument to 'list' subcommand.
This argument allows users to show only specified
entries. Unavailable fields will be ignored from
the list result.
DocImpact
Change-Id: Iad4bf76e87f84b6e57ec59d134b9413fcad16ce8
Closes-Bug: #1502639
v2 replication has been merged in cinder, but there is no way to call
the api methods. This patch allows the following methods to be called
in order to fully support v2 replication:
- os-enable_replication
- os-disable_replication
- os-list_replication_targets
- os-failover_replication
Change-Id: Ic3cf082916bdf089de05eebce456dff8cdc11f7c
Implements: blueprint replication-v2
As part of commit 0d2bf657ae5271a01e9ec84d379d17910b263b7e,
qos-key command's v2 support got broken again reintroducing
bug #1284321.
Change-Id: I30d60b060bd1b161bc96c4a529f4732b9ceef90d
Closes-Bug: 1284321
