This change fixes inspection failure on my hardware.
In the future we should develop a better understanding on which
fields are mandatory and which are not, as right now we're very
inconsistent with handling them.
Change-Id: Ia2af90fec4eef168953552a947933617e7c808d0
Closes-Bug: #1550328
Currently we raise an AttributeError when expected attribute is missing
from the response. This is not very developer-friendly, so this patch
creates a new exception (derived from AttributeError for compatibility)
for this purpose.
Change-Id: If2ac03dcd410d451dc7bbfe7bbd0b145da201c9a
Related-Bug: #1550328
Now it fails with AttributeError: 'NoneType' object has no attribute 'strip'.
Raise a new exception with proper explanation instead.
Partial-Bug: #1550328
Change-Id: Ie9f9d212c934bb75e8224dd64ec8df7f788b86d3
The python-dracclient job resource's JobManagement.get_job() causes a
FutureWarning. When that function is called, the following is output.
/usr/lib/python2.7/site-packages/dracclient/resources/job.py:103:
FutureWarning: The behavior of this method will change in future
versions. Use specific 'len(elem)' or 'elem is not None' test instead.
if drac_job:
Change the identified line as suggested by the warning.
Change-Id: I9624b76cbf2e195f387ba104c98ae922619aa1f2
Closes-Bug: #1639339
AttributeName just happens to be unique for everything under
DCIM_BIOS* but this is not a guarantee. Using InstanceId instead
which is guaranteed to be unique.
Discussion on the list
http://lists.openstack.org/pipermail/openstack-dev/2016-September/103602.html
Closes-Bug: #1635419
Signed-off-by: Anish Bhatt <anish.bhatt@salesforce.com>
Change-Id: I93c0f7919ecfd77642634d1d0addfe8a79aa6f57
This is already being polled but just not returned. This also
bring parity with standard racadm output.
Change-Id: Ia5f1c49b46463f4872960d2f652a7406b79101eb
This can fail with
AttributeError: 'NoneType' object has no attribute 'strip'
otherwise
Closes-Bug: #1550328
Change-Id: I8eafe606407cddc1e9ea03a33473b65ff3b59384
Splitting on fixed number of colons breaks in this case :
Disk.Bay.0:Enclosure.Internal.0-1:RAID.Integrated.1-1
Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1
Disk.Bay.2:Enclosure.Internal.0-1:RAID.Integrated.1-1
Disk.Bay.3:Enclosure.Internal.0-1:RAID.Integrated.1-1
Disk.Direct.4:RAID.Integrated.1-1
Disk.Direct.5:RAID.Integrated.1-1
Split from right instead, doesn't fail
Partial-Bug: #1586545
Change-Id: Ib4ca517388c48ade321451cb8af07abb731e5940
In Python 3 __ne__ by default delegates to __eq__ and inverts the
result, but in Python 2 they urge you to define __ne__ when you
define __eq__ for it to work properly [1].There are no implied
relationships among the comparison operators. The truth of x==y
does not imply that x!=y is false. Accordingly, when defining __eq__(),
one should also define __ne__() so that the operators will behave as
expected.
[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__
Change-Id: Iacd368b64650bf7eabd342a236339d1711aea4cd
- dict for PrimaryStatus is moved to constants
- inventory.Memory has its size renamed to size_mb
- job.Job has its state renamed to status
- raid.PhysicalDisk and raid.VirtualDisk have their state and raid_state
renamed to status and raid_status
Change-Id: I0fc8450d13a8f0de271f4e14b770bf5497e19b8e
This configures tox to use upper-constraints for everything, except
environments used for post jobs (as constraints aren't supported there
yet).
Change-Id: I52530198b1970733cca6a3d0dedb42e416c69f54
A new function, convert_physical_disks, converts disks to and from
RAID mode. This function enables a Dell system at factory defaults
to be initialised with a RAID configuration by python-dracclient.
Change-Id: Ice40bfb47485056428a22c216990cf0a026c73d2
To solve the problem of "db type could
not be determined" on py34 we have to run first the py34 env to, then, run
py27. This patch puts py34 first on the tox.ini list of envs to avoid this
problem to happen.
Change-Id: I94baade12db4b445e2f7879b1674c5d8e29fcccf
Closes-bug: #1489059