openstack/python-ironicclient
Code Issues Proposed changes

Merge "Using assertIsNone() is preferred over assertEqual()"

Browse Source
This commit is contained in:
Jenkins 2016-08-30 16:27:44 +00:00 committed by Gerrit Code Review
commit a4b367e4e0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ironicclient/tests/unit/v1/test_create_resources.py
View File

@ -261,7 +261,7 @@ class CreateMethodsTest(utils.BaseTestCase):
e = exc.ClientException('foo')
self.client.node.create.side_effect = e
res, err = create_resources.create_single_node(self.client, **params)
self.assertEqual(None, res)
self.assertIsNone(res)
self.assertIsInstance(err, exc.ClientException)
self.assertIn('Unable to create the node', str(err))
self.client.node.create.assert_called_once_with(driver='fake')
@ -271,7 +271,7 @@ class CreateMethodsTest(utils.BaseTestCase):
e = exc.InvalidAttribute('foo')
self.client.node.create.side_effect = e
res, err = create_resources.create_single_node(self.client, **params)
self.assertEqual(None, res)
self.assertIsNone(res)
self.assertIsInstance(err, exc.InvalidAttribute)
self.assertIn('Cannot create the node with attributes', str(err))
self.client.node.create.assert_called_once_with(driver='fake')