Replace assertEqual(None, *) with assertIsNone in tests
Replace assertEqual(None, *) with assertIsNone in tests to have more clear messages in case of failure. Change-Id: I109bef1afbbdd3a2cf25e9fb7133509516910891 Closes-bug: #1280522
This commit is contained in:
parent
5751b32932
commit
a90b16ca84
|
@ -735,7 +735,7 @@ class NodeManagerTest(testtools.TestCase):
|
||||||
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
|
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
|
||||||
]
|
]
|
||||||
self.assertEqual(expect, self.api.calls)
|
self.assertEqual(expect, self.api.calls)
|
||||||
self.assertEqual(None, maintenance)
|
self.assertIsNone(maintenance)
|
||||||
|
|
||||||
def test_node_set_maintenance_false(self):
|
def test_node_set_maintenance_false(self):
|
||||||
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'false')
|
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'false')
|
||||||
|
@ -743,7 +743,7 @@ class NodeManagerTest(testtools.TestCase):
|
||||||
('DELETE', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, None),
|
('DELETE', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, None),
|
||||||
]
|
]
|
||||||
self.assertEqual(expect, self.api.calls)
|
self.assertEqual(expect, self.api.calls)
|
||||||
self.assertEqual(None, maintenance)
|
self.assertIsNone(maintenance)
|
||||||
|
|
||||||
def test_node_set_maintenance_on(self):
|
def test_node_set_maintenance_on(self):
|
||||||
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'on',
|
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'on',
|
||||||
|
@ -753,7 +753,7 @@ class NodeManagerTest(testtools.TestCase):
|
||||||
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
|
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
|
||||||
]
|
]
|
||||||
self.assertEqual(expect, self.api.calls)
|
self.assertEqual(expect, self.api.calls)
|
||||||
self.assertEqual(None, maintenance)
|
self.assertIsNone(maintenance)
|
||||||
|
|
||||||
def test_node_set_maintenance_off(self):
|
def test_node_set_maintenance_off(self):
|
||||||
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'off')
|
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'off')
|
||||||
|
@ -761,7 +761,7 @@ class NodeManagerTest(testtools.TestCase):
|
||||||
('DELETE', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, None),
|
('DELETE', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, None),
|
||||||
]
|
]
|
||||||
self.assertEqual(expect, self.api.calls)
|
self.assertEqual(expect, self.api.calls)
|
||||||
self.assertEqual(None, maintenance)
|
self.assertIsNone(maintenance)
|
||||||
|
|
||||||
def test_node_set_maintenance_bad(self):
|
def test_node_set_maintenance_bad(self):
|
||||||
self.assertRaises(exc.InvalidAttribute, self.mgr.set_maintenance,
|
self.assertRaises(exc.InvalidAttribute, self.mgr.set_maintenance,
|
||||||
|
@ -775,7 +775,7 @@ class NodeManagerTest(testtools.TestCase):
|
||||||
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
|
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
|
||||||
]
|
]
|
||||||
self.assertEqual(expect, self.api.calls)
|
self.assertEqual(expect, self.api.calls)
|
||||||
self.assertEqual(None, maintenance)
|
self.assertIsNone(maintenance)
|
||||||
|
|
||||||
def test_node_set_power_state(self):
|
def test_node_set_power_state(self):
|
||||||
power_state = self.mgr.set_power_state(NODE1['uuid'], "on")
|
power_state = self.mgr.set_power_state(NODE1['uuid'], "on")
|
||||||
|
|
Loading…
Reference in New Issue