OSC 'node list' recognizes all provision states

Now OSC 'node list' command with --provision-state argument for
'available' will list all nodes whose provision state is 'available'.
It will also accept all the provision-states for OSC 'node list'
command.

Change-Id: If0032f652bcb3f6638b59dba32b97cb19176df46
Closes-Bug: #1663202

ironicclient/osc/v1/baremetal_node.py

@@ -564,9 +564,7 @@ class ListBaremetalNode(command.Lister):
             '--provision-state',
             dest='provision_state',
             metavar='<provision state>',
-            choices=self.PROVISION_STATES,
+            help=_("List nodes in specified provision state."))
-            help=_("Limit list to nodes in <provision state>. One of %s.") %
-                 (", ".join(self.PROVISION_STATES)))
         parser.add_argument(
             '--resource-class',
             dest='resource_class',

ironicclient/tests/unit/osc/v1/test_baremetal_node.py

@@ -778,18 +778,6 @@ class TestBaremetalList(TestBaremetal):
             **kwargs
         )
 
-    def test_baremetal_list_invalid_provision_state(self):
-        arglist = [
-            '--provision-state', 'invalid',
-        ]
-        verifylist = [
-            ('provision_state', 'invalid'),
-        ]
-
-        self.assertRaises(oscutils.ParserException,
-                          self.check_parser,
-                          self.cmd, arglist, verifylist)
-
     def test_baremetal_list_resource_class(self):
         arglist = [
             '--resource-class', 'foo',

releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml

@@ -0,0 +1,4 @@
+---
+fixes:
+  - Allows all provision states for OSC node list
+    command with --provision-state argument