openstack
/
python-mistralclient
Code Issues Proposed changes

Don't use default mutable parameter 

Using default mutable parameter is bad.
Default parameters are evaluated only once
if you mutate it you will get unexpected results.

Change-Id: I9c00cb16ac0e6cefd926974a9eab29080a4d94a7
This commit is contained in:
Eyal 2019-04-29 10:19:22 +03:00
parent aa3171ade1
commit 87d54bba87
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mistralclient/tests/unit/base.py
View File

@ -31,7 +31,7 @@ class BaseCommandTest(base.BaseTestCase):
self.app = mock.Mock()
self.client = self.app.client_manager.workflow_engine
def call(self, command, app_args=[], prog_name=''):
def call(self, command, app_args=(), prog_name=''):
cmd = command(self.app, app_args)
parsed_args = cmd.get_parser(prog_name).parse_args(app_args)