openstack/python-mistralclient
Code Issues Proposed changes

Add namespace parameter to workflow-get and workflow-get-definition

Browse Source 
* '--namespace' paramter was missing in these two commands. Now
  they are added.
* Fixed wrong parameter descriptions
* Style changes

Change-Id: Icce73a247e67268a60de56008e42560225990b68
This commit is contained in:
Renat Akhmerov
2018-05-08 13:40:00 +07:00
parent 8cc76487fd
commit c79ef859f6
1 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
mistralclient/commands/v2/workflows.py
View File

@@ -96,12 +96,22 @@ class Get(show.ShowOne):
parser = super(Get, self).get_parser(prog_name)
parser.add_argument('workflow', help='Workflow ID or name.')
parser.add_argument(
'--namespace',
nargs='?',
default='',
help="Namespace to get the workflow from.",
)
return parser
def take_action(self, parsed_args):
mistral_client = self.app.client_manager.workflow_engine
wf = mistral_client.workflows.get(parsed_args.workflow)
wf = mistral_client.workflows.get(
parsed_args.workflow,
parsed_args.namespace
)
return format(wf)
@@ -141,6 +151,7 @@ class Create(base.MistralLister):
def _get_resources(self, parsed_args):
scope = 'public' if parsed_args.public else 'private'
mistral_client = self.app.client_manager.workflow_engine
return mistral_client.workflows.create(
@@ -166,8 +177,7 @@ class Delete(command.Command):
'--namespace',
nargs='?',
default=None,
help="Parent task execution ID associated with workflow "
"execution list.",
help="Namespace to delete the workflow from.",
)
return parser
@@ -201,8 +211,7 @@ class Update(base.MistralLister):
'--namespace',
nargs='?',
default='',
help="Parent task execution ID associated with workflow "
"execution list.",
help="Namespace of the workflow.",
)
parser.add_argument(
@@ -218,6 +227,7 @@ class Update(base.MistralLister):
def _get_resources(self, parsed_args):
scope = 'public' if parsed_args.public else 'private'
mistral_client = self.app.client_manager.workflow_engine
return mistral_client.workflows.update(
@@ -235,12 +245,22 @@ class GetDefinition(command.Command):
parser = super(GetDefinition, self).get_parser(prog_name)
parser.add_argument('identifier', help='Workflow ID or name.')
parser.add_argument(
'--namespace',
nargs='?',
default='',
help="Namespace to get the workflow from.",
)
return parser
def take_action(self, parsed_args):
mistral_client = self.app.client_manager.workflow_engine
wf = mistral_client.workflows.get(parsed_args.identifier)
wf = mistral_client.workflows.get(
parsed_args.identifier,
parsed_args.namespace
)
self.app.stdout.write(wf.definition or "\n")
@@ -271,6 +291,7 @@ class Validate(show.ShowOne):
def take_action(self, parsed_args):
mistral_client = self.app.client_manager.workflow_engine
result = mistral_client.workflows.validate(
parsed_args.definition.read()
)