openstack
/
python-novaclient
Code Issues Proposed changes
OpenStack Compute (Nova) Client
3,304 Commits 9 Branches 35 Tags 35 MiB
Python 100%
Go to file
Stephen Finucane 33627242e8 Stop silently ignoring invalid 'nova boot --hint' options 
The '--hint' option for 'nova boot' expects a key-value pair like so:

  nova boot --hint group=245e1dfe-2d0e-4139-80a9-fce124948896 ...

However, the command doesn't complain if this isn't the case, meaning
typos like the below aren't indicated to the user:

  nova boot --hint 245e1dfe-2d0e-4139-80a9-fce124948896

Due to how we'd implemented this here, this ultimately results in us
POSTing the following as part of the body to 'os-servers':

  {
    ...
    "OS-SCH-HNT:scheduler_hints": {
      "245e1dfe-2d0e-4139-80a9-fce124948896": null
    }
    ...
  }

Which is unfortunately allowed and ignored by nova due to the use of
'additionalProperties' in the schema [1]

Do what we do for loads of other options and explicitly fail on invalid
values.

NOTE(stephenfin): This includes the release note first added separately
in change I753e9a0cda1e118578373c519cf2fb2dd605a623.

[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146

Change-Id: I0f9f75cba68e7582d32d4aab2f8f077b4360d386
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Closes-Bug: #1845322
(cherry picked from commit 6954aacd54)
 		2019-10-01 15:58:21 +01:00
doc Microversion 2.79: Add delete_on_termination to volume-attach API 2019-09-09 12:43:42 -04:00
novaclient Stop silently ignoring invalid 'nova boot --hint' options 2019-10-01 15:58:21 +01:00
playbooks/legacy/novaclient-dsvm-functional OpenDev Migration Patch 2019-04-19 19:43:24 +00:00
releasenotes Stop silently ignoring invalid 'nova boot --hint' options 2019-10-01 15:58:21 +01:00
tools Switch to stestr 2018-07-16 15:43:48 +07:00
.coveragerc Change ignore-errors to ignore_errors 2015-09-21 14:54:09 +00:00
.gitignore Switch to stestr 2018-07-16 15:43:48 +07:00
.gitreview OpenDev Migration Patch 2019-04-19 19:43:24 +00:00
.mailmap Add mailmap entry 2014-05-07 12:16:41 -07:00
.stestr.conf Switch to stestr 2018-07-16 15:43:48 +07:00
.zuul.yaml Merge "Add irrelevant files in dsvm job again" 2019-07-10 01:20:06 +00:00
CONTRIBUTING.rst Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
HACKING.rst Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
LICENSE whitespace cleanups 2011-08-08 13:25:29 -07:00
README.rst Updates for OpenDev transition 2019-04-23 01:18:31 +00:00
babel.cfg Enable i18n with Babel. 2015-09-08 10:10:25 -07:00
bindep.txt Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
lower-constraints.txt Cap sphinx for py2 and drop keyring dependency 2019-05-15 09:13:54 -04:00
requirements.txt Enable split logging for cinder-novaclient interaction 2018-08-24 12:49:36 +00:00
setup.cfg Add Python 3 Train unit tests 2019-07-02 09:35:48 +08:00
setup.py Updated from global requirements 2017-03-06 01:18:45 +00:00
test-requirements.txt Blacklist python-cinderclient 4.0.0 2019-06-04 10:51:36 +08:00
tox.ini Add Python 3 Train unit tests 2019-07-05 14:01:05 -04:00

README.rst

Team and repository tags

image

Python bindings to the OpenStack Compute API

Latest Version

This is a client for the OpenStack Compute API. It provides a Python API (the novaclient module) and a command-line script (nova). Each implements 100% of the OpenStack Compute API.