openstack/python-tackerclient
Code Issues Proposed changes

Update patch set 4

Browse Source 
Patch Set 4:

(4 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 33464 \u003c33464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33464\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 25701 \u003c25701@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33464\u003e replied on the change"}
This commit is contained in:
Gerrit User 33464
2023-02-16 01:43:11 +00:00
committed by Gerrit Code Review
parent 2d6f00a793
commit 5d95b101cf
1 changed files with 89 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
fa0e86837cb79dc823a6ef3d58f73ff556d6cd10
View File

@@ -71,6 +71,30 @@
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "57cd3140_e47f0555",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 7,
"author": {
"id": 33464
},
"writtenOn": "2023-02-16T01:43:11Z",
"side": 1,
"message": "It seems OK. I will fix it in PS5.",
"parentUuid": "ce8ec2af_348e6049",
"range": {
"startLine": 7,
"startChar": 8,
"endLine": 7,
"endChar": 13
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@@ -192,6 +216,23 @@
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c676aeac_ba0bb582",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 33464
},
"writtenOn": "2023-02-16T01:43:11Z",
"side": 1,
"message": "Thank you for the review.",
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@@ -287,6 +328,30 @@
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "34ced370_7aa3f4a5",
"filename": "tackerclient/tacker/v1_0/nfvo/vim_utils.py",
"patchSetId": 4
},
"lineNbr": 101,
"author": {
"id": 33464
},
"writtenOn": "2023-02-16T01:43:11Z",
"side": 1,
"message": "\"pop() is required in the function actually.\" Doesn\u0027t seem to match your intention, is it correct?\n\nIn addition, I guess, the programmer who wrote this code used pop() to mean moving data from one dictionary to another dictionary, in this case, moving data from config_param to vim. pop() is often used in functions like a2b(), here is args2body_vim().",
"parentUuid": "ada0eabd_e2593c9e",
"range": {
"startLine": 99,
"startChar": 4,
"endLine": 101,
"endChar": 28
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@@ -405,6 +470,30 @@
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "531c17ea_4cb53e67",
"filename": "tackerclient/tests/unit/vm/test_vim_utils.py",
"patchSetId": 4
},
"lineNbr": 60,
"author": {
"id": 33464
},
"writtenOn": "2023-02-16T01:43:11Z",
"side": 1,
"message": "Agree.",
"parentUuid": "1166ffe0_e4b9a576",
"range": {
"startLine": 57,
"startChar": 8,
"endLine": 60,
"endChar": 30
},
"revId": "fa0e86837cb79dc823a6ef3d58f73ff556d6cd10",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}