openstack
/
python-tripleoclient
Code Issues Proposed changes

Make ipmi lanplus the default in auto fencing 

This commit sets the default value for the lanplus parameter,
--ipmi-lanplus, to true instead of the previous false.
This is the default used by all modern IPMI interfaces so there's no
meaning to keep the default to false, and in any case the override will
still be possible, by specifying --ipmi-no-lanplus.

Change-Id: Ic206c235f040f03d0d0334bf396864d3eeb400d2
This commit is contained in:
Raoul Scarazzini 2018-04-20 14:58:15 +02:00
parent b7f3ef654b
commit a82124948f
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
releasenotes/notes/ipmi-lanplus-default-fb3ec3496853ed9e.yaml Normal file
View File

@ -0,0 +1,6 @@
---
features:
- |
Deprecate --ipmi-lanplus for ``openstack overcloud generate fencing``
command since now this is the default and add new option --ipmi-no-lanplus
to override it.

2
tripleoclient/tests/v1/test_overcloud_parameters.py
View File

@ -166,7 +166,7 @@ class TestGenerateFencingParameters(utils.TestCommand):
'delay': None,
'os_auth': {},
'ipmi_cipher': None,
'ipmi_lanplus': False,
'ipmi_lanplus': True,
'ipmi_level': None
},
run_sync=True, save_result=True)

8
tripleoclient/v1/overcloud_parameters.py
View File

@ -80,8 +80,14 @@ class GenerateFencingParameters(command.Command):
help=_('Wait DELAY seconds before fencing is '
'started'))
parser.add_argument('--ipmi-lanplus',
dest='ipmi_lanplus',
default=True,
action='store_true',
help=_('Use Lanplus. Defaults to: false'))
help=_('DEPRECATED: This is the default.'))
parser.add_argument('--ipmi-no-lanplus',
dest='ipmi_lanplus',
action='store_false',
help=_('Do not use Lanplus. Defaults to: false'))
parser.add_argument('--ipmi-cipher', type=int,
help=_('Ciphersuite to use (same as ipmitool -C '
'parameter.'))