Merge "Use with keyword for opening target file"

2019-01-31 18:52:43 +00:00
parent 9e500285f0 c59178a69a
commit dcc723a9c6
1 changed files with 2 additions and 1 deletions
--- a/tripleoclient/v1/tripleo_deploy.py
+++ b/tripleoclient/v1/tripleo_deploy.py
@@ -1101,7 +1101,8 @@ class Deploy(command.Command):
            raise exceptions.DeploymentError(msg)

        target = override_file
-        data = open(target, 'r').read()
+        with open(target, 'rb') as fb:
+            data = fb.read()
        if not data.strip():
            # since an empty file isn't valid yaml, let's be more specific
            msg = (_("hieradata override file (%s) cannot be empty") % target)