openstack/swift
Code Issues Proposed changes

Tighten up recon middleware unit tests

Browse Source 
Adds a test for get_expirer_info() and tightens up
the test for get_async_info().

While reviewing [1] I noticed that the existing tests on
master will not catch a bug creeping into the arg strings
that these methods pass to from_recon_cache().

[1] https://review.openstack.org/#/c/163889

Change-Id: Iee6f12aeff684d70435dbeea769ccc181021be79
This commit is contained in:
Alistair Coles 2015-03-19 11:02:09 +00:00
parent b7fabcc84a
commit a624a593df
1 changed files with 14 additions and 0 deletions

14
test/unit/common/middleware/test_recon.py

@ -489,6 +489,9 @@ class TestReconSuccess(TestCase):
from_cache_response = {'async_pending': 5}
self.fakecache.fakeout = from_cache_response
rv = self.app.get_async_info()
self.assertEquals(self.fakecache.fakeout_calls,
[((['async_pending'],
'/var/cache/swift/object.recon'), {})])
self.assertEquals(rv, {'async_pending': 5})
def test_get_replication_info_account(self):
@ -585,6 +588,17 @@ class TestReconSuccess(TestCase):
'/var/cache/swift/object.recon'), {})])
self.assertEquals(rv, {"object_updater_sweep": 0.79848217964172363})
def test_get_expirer_info_object(self):
from_cache_response = {'object_expiration_pass': 0.79848217964172363,
'expired_last_pass': 99}
self.fakecache.fakeout_calls = []
self.fakecache.fakeout = from_cache_response
rv = self.app.get_expirer_info('object')
self.assertEquals(self.fakecache.fakeout_calls,
[((['object_expiration_pass', 'expired_last_pass'],
'/var/cache/swift/object.recon'), {})])
self.assertEquals(rv, from_cache_response)
def test_get_auditor_info_account(self):
from_cache_response = {"account_auditor_pass_completed": 0.24,
"account_audits_failed": 0,