openstack/tacker
Code Issues Proposed changes

Fix 500 when creating already on-boarded VNF

Browse Source 
If you on-board a VNF to tacker and try to on-board it again tacker
gives 500 InternalServerError. The response message user get is
correct but the response code returned is incorrect which is 500.

message returned:
"vnfd already exist with given ['tenant_id', 'name', 'deleted_at']"

The type of a TackerError returned is 'DuplicateEntity' which has
500 response code as it is derived from 'TackerException'.

This patch changes the response code from 500 to 409 as this case
is of HTTPConflict.

This affects to below mentioned API's:
* POST /v1.0/vnfds
* POST /v1.0/vnfs
* POST /v1.0/vims
* POST /v1.0/nsds
* POST /v1.0/nss

NOTE:
There are no existing unit test cases written for such API's.

Closes-Bug: #1734316
Change-Id: I7f63ab5f9612c2f32f0f11397ad0d6e3cee2f8d6
This commit is contained in:
Dinesh Bhor 2017-11-23 18:22:14 +05:30
parent cc03b5d952
commit 3fbf7a9ae0
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
releasenotes/notes/bug-1734316-change-response-code-e74907cb7c800bc7.yaml Normal file
View File

@ -0,0 +1,13 @@
---
fixes:
- |
Fixes `bug 1734316`_ which will return correct response codes for below
API's:
- POST /v1.0/vnfds - old_response: 500, new_response: 409
- POST /v1.0/vnfs - old_response: 500, new_response: 409
- POST /v1.0/vims - old_response: 500, new_response: 409
- POST /v1.0/nsds - old_response: 500, new_response: 409
- POST /v1.0/nss - old_response: 500, new_response: 409
.. _bug 1734316: https://bugs.launchpad.net/tacker/+bug/1734316

2
tacker/common/exceptions.py
View File

@ -281,5 +281,5 @@ class DuplicateResourceName(TackerException):
message = _("%(resource)s with name %(name)s already exists")
class DuplicateEntity(TackerException):
class DuplicateEntity(Conflict):
message = _("%(_type)s already exist with given %(entry)s")