openstack/tempest
Code Issues Proposed changes

Skip test that rely on creds by role

Browse Source 
The legacy credential providers raises an exception when
is_role_available is invoked. This causes tests that rely on
credentials by role to fail rather than skip when that
credential provider is used.

The wrong behaviour was introduced in change
I351f86f0570070105bbf24f2d904e917feea6e57, and since than it's
causing periodic and experimental jobs using the legacy
credential provider to fail. Fixing that.

Change-Id: I0ca0b96fc618ffe60851984a9c6d46b0507878d4
This commit is contained in:
Andrea Frittoli (andreaf) 2015-11-20 06:40:54 +00:00
parent c4dc060b8c
commit 074dee8c76
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tempest/common/credentials_factory.py
View File

@ -118,11 +118,11 @@ class LegacyCredentialProvider(cred_provider.CredentialProvider):
raise exceptions.InvalidConfiguration(msg)
def is_role_available(self, role):
msg = "Credentials being specified through the config file can not be"\
" used with tests that specify using credentials by roles. "\
"Either exclude/skip the tests doing this or use either an "\
"test_accounts_file or dynamic credentials."
raise exceptions.InvalidConfiguration(msg)
# NOTE(andreaf) LegacyCredentialProvider does not support credentials
# by role, so returning always False.
# Test that rely on credentials by role should use this to skip
# when this is credential provider is used
return False
# Return the right implementation of CredentialProvider based on config