openstack/tempest
Code Issues Proposed changes

Merge "Fix RemoteClient having bad default ssh_shell_prologue"

Browse Source
This commit is contained in:
Jenkins
2017-08-23 07:24:20 +00:00
committed by Gerrit Code Review
parent 0a107b1b30 d8152de0da
commit 45e600c375
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
releasenotes/notes/fix-remoteclient-default-ssh-shell-prologue-33e99343d086f601.yaml Normal file
View File

@@ -0,0 +1,7 @@
---
fixes:
- |
Fix RemoteClient default ssh_shell_prologue: Bug#1707478
The default ssh_shell_proloque has been modified from
specifying erroneous PATH=$$PATH:/sbin to PATH=$PATH:/sbin.

2
tempest/lib/common/utils/linux/remote_client.py
View File

@@ -67,7 +67,7 @@ class RemoteClient(object):
def __init__(self, ip_address, username, password=None, pkey=None,
server=None, servers_client=None, ssh_timeout=300,
connect_timeout=60, console_output_enabled=True,
ssh_shell_prologue="set -eu -o pipefail; PATH=$$PATH:/sbin;",
ssh_shell_prologue="set -eu -o pipefail; PATH=$PATH:/sbin;",
ping_count=1, ping_size=56):
"""Executes commands in a VM over ssh

2
tempest/tests/lib/common/utils/linux/test_remote_client.py
View File

@@ -34,7 +34,7 @@ class TestRemoteClient(base.TestCase):
client = remote_client.RemoteClient('192.168.1.10', 'username')
client.exec_command('ls')
mock_ssh_exec_command.assert_called_once_with(
'set -eu -o pipefail; PATH=$$PATH:/sbin; ls')
'set -eu -o pipefail; PATH=$PATH:/sbin; ls')
@mock.patch.object(ssh.Client, 'test_connection_auth')
def test_validate_authentication(self, mock_test_connection_auth):