openstack
/
tempest
Code Issues Proposed changes

[V3] Rename get_group to show_group 

[GET /resources] methods should be "list_<resource name>s"
or "show_<resource name>", so this patch applies the rule
to groups client.

Partially implements blueprint consistent-service-method-names

Change-Id: Ia6c83f9bad2684c61e694e52244ea54c98d9d070
This commit is contained in:
Yaroslav Lobankov 2015-11-20 11:21:11 +03:00
parent 45025c0da1
commit 937438cb4a
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tempest/api/identity/admin/v3/test_groups.py
View File

@ -37,7 +37,7 @@ class GroupsV3TestJSON(base.BaseIdentityV3AdminTest):
self.assertEqual(updated_group['name'], new_name)
self.assertEqual(updated_group['description'], new_desc)
new_group = self.groups_client.get_group(group['id'])['group']
new_group = self.groups_client.show_group(group['id'])['group']
self.assertEqual(group['id'], new_group['id'])
self.assertEqual(new_name, new_group['name'])
self.assertEqual(new_desc, new_group['description'])

1
tempest/hacking/ignored_list_T110.txt
View File

@ -1,7 +1,6 @@
./tempest/services/compute/json/servers_client.py
./tempest/services/database/json/flavors_client.py
./tempest/services/identity/v3/json/credentials_client.py
./tempest/services/identity/v3/json/groups_client.py
./tempest/services/identity/v3/json/identity_client.py
./tempest/services/identity/v3/json/policy_client.py
./tempest/services/identity/v3/json/region_client.py

2
tempest/services/identity/v3/json/groups_client.py
View File

@ -37,7 +37,7 @@ class GroupsClient(service_client.ServiceClient):
body = json.loads(body)
return service_client.ResponseBody(resp, body)
def get_group(self, group_id):
def show_group(self, group_id):
"""Get group details."""
resp, body = self.get('groups/%s' % group_id)
self.expected_success(200, resp.status)