openstack/tempest
Code Issues Proposed changes

Remove an unused variable in the BaseTestCase class

Browse Source 
The variable has become useless with the migration of the clients
to tempest/lib.

Change-Id: I98b655026a9cf2f9ba6d94d98c20fa46cc5dddbd
This commit is contained in:
Jordan Pittier 2017-01-04 19:17:35 +01:00
parent 2ef46132e1
commit e4be907e34
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tempest/clients.py
View File

@ -40,12 +40,11 @@ class Manager(clients.ServiceClients):
}
default_params_with_timeout_values.update(default_params)
def __init__(self, credentials, service=None, scope='project'):
def __init__(self, credentials, scope='project'):
"""Initialization of Manager class.
Setup all services clients and make them available for tests cases.
:param credentials: type Credentials or TestResources
:param service: Service name
:param scope: default scope for tokens produced by the auth provider
"""
_, identity_uri = get_auth_provider_class(credentials)

5
tempest/common/credentials_factory.py
View File

@ -233,7 +233,6 @@ def get_credentials(fill_in=True, identity_version=None, **kwargs):
class AdminManager(clients.Manager):
"""Manager that uses admin credentials for its managed client objects"""
def __init__(self, service=None):
def __init__(self):
super(AdminManager, self).__init__(
credentials=get_configured_admin_credentials(),
service=service)
credentials=get_configured_admin_credentials())

4
tempest/test.py
View File

@ -219,7 +219,6 @@ class BaseTestCase(testtools.testcase.WithAttributes,
"""
setUpClassCalled = False
_service = None
# NOTE(andreaf) credentials holds a list of the credentials to be allocated
# at class setup time. Credential types can be 'primary', 'alt', 'admin' or
@ -533,8 +532,7 @@ class BaseTestCase(testtools.testcase.WithAttributes,
else:
raise lib_exc.InvalidCredentials(
"Invalid credentials type %s" % credential_type)
manager = cls.client_manager(credentials=creds.credentials,
service=cls._service)
manager = cls.client_manager(credentials=creds.credentials)
# NOTE(andreaf) Ensure credentials have user and project id fields.
# It may not be the case when using pre-provisioned credentials.
manager.auth_provider.set_auth()