8a8c85ddfc
Before [1] we didn't have conditionals for tempest_black_regex being set or not, therefore it had a default value of empty string set in the role's defaults. However after [1] we do have such conditionals which make setting the default value unnecessary - especially when we're asking if the var is defined - it will be always defined. Therefore this patch removes the default setting of tempest_black_regex and tempest_exclude_regex. The patch also removes 'Set tempest_exclude_regex' task introduced by [1] as it appears unnecessary as well. This task simply copied tempest_black_regex value to tempest_exclude_regex. However there are 2 tasks below which do the same logic plus more - they build CLI arguments for tempest where depending on which ansible var is used the appropriate CLI arg is chosen - tempest_black_regex is set, --black-regex will be passed to tempest (for backward compatibility) and if tempest_exclude_regex is set, --exclude-regex will passed to tempest. The patch creates a new temporary ansible var which will be used only internally. The role will store in it the CLI argument chosen dynamically which is passed to tempest later. Before we reused the tempest_exclude_regex variable for that, however that causes problems whent the var is set on a role level as set_fact won't override such var. [1] https://review.opendev.org/c/openstack/tempest/+/768583 Change-Id: I3e45741057e7a95b282b03bab4695f46c62d5271 |
||
|---|---|---|
| .. | ||
| acl-devstack-files | ||
| ipv6-only-deployments-verification | ||
| run-tempest | ||
| setup-tempest-data-dir | ||
| setup-tempest-run-dir | ||
| tempest-cleanup | ||