Update patch set 5
Patch Set 5: (1 comment) Patch-set: 5 Attention: {"person_ident":"Gerrit User 30858 \u003c30858@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"zhen replied on the change"} Attention: {"person_ident":"Gerrit User 28522 \u003c28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"zhen replied on the change"}
This commit is contained in:
parent
d76bcd6ac6
commit
29cee73e16
|
@ -39,6 +39,30 @@
|
||||||
},
|
},
|
||||||
"revId": "c0471fe71a4c7a6e77d3ce211eaac8a485794f34",
|
"revId": "c0471fe71a4c7a6e77d3ce211eaac8a485794f34",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "8e3bd1a3_97e562e4",
|
||||||
|
"filename": "tooz/drivers/memcached.py",
|
||||||
|
"patchSetId": 5
|
||||||
|
},
|
||||||
|
"lineNbr": 161,
|
||||||
|
"author": {
|
||||||
|
"id": 30858
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-05-26T09:09:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Appreciate for that comment.\nAccording to the previous code, lock.release() returns True on successful execution of \"self.coord.client.delete\". If \"self.coord.client.delete\" does not successfully delete the key, then others will be blocked when requesting the same key until the old key expires. So I think it\u0027s better to keep it this way? Is there any problem i never notice?",
|
||||||
|
"parentUuid": "8ddc7b82_a9e03b76",
|
||||||
|
"range": {
|
||||||
|
"startLine": 161,
|
||||||
|
"startChar": 12,
|
||||||
|
"endLine": 161,
|
||||||
|
"endChar": 76
|
||||||
|
},
|
||||||
|
"revId": "c0471fe71a4c7a6e77d3ce211eaac8a485794f34",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
Loading…
Reference in New Issue