openstack
/
tooz
Code Issues Proposed changes

Update patch set 8 

Patch Set 8: Code-Review-1

(1 comment)

Patch-set: 8
Reviewer: Gerrit User 9816 <9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, cf026e2fcebeda46af23e4e10b87735bfcaee560
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36759 \u003c36759@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
This commit is contained in:
Gerrit User 9816 2024-02-06 03:25:55 +00:00 committed by Gerrit Code Review
parent 1807455317
commit f589779405
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ba3a7531467418387b26f6bc0794b59728b02172
View File

@ -152,6 +152,30 @@
},
"revId": "ba3a7531467418387b26f6bc0794b59728b02172",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "70b630ff_4a630a7f",
"filename": "tooz/drivers/memcached.py",
"patchSetId": 6
},
"lineNbr": 284,
"author": {
"id": 9816
},
"writtenOn": "2024-02-06T03:25:55Z",
"side": 1,
"message": "If you do not prefer that kick out behavior then what\u0027s the point of supporting cluster ? Without that mechanism if you get any of your cluster nodes tooz may not function. It may have performance improvement but makes the cluster fragile.",
"parentUuid": "0215b53b_b1b589e1",
"range": {
"startLine": 283,
"startChar": 8,
"endLine": 284,
"endChar": 1
},
"revId": "ba3a7531467418387b26f6bc0794b59728b02172",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}