In some situations, openstack image list queries on name return a 0
exit code even though there is no result.
Change-Id: I20f63ea45e52181810654f7afab11499fef9baa2
Related-Bug: #1843059
We've been running into numerous issues with searching on patterns in
the command so using the container CLI to match seems better.
Change-Id: I13633ab4d5ebfc7f52b7215523c310fe72a5487e
Closes-Bug: #1869384
To avoid this error:
The error was: KeyError: 'container_data'
We need to fetch container_data from async_result_item in the async
results; that's where the key is. Updating unit tests as well, and the
task which creates the facts so there is no confusion in the logs.
Change-Id: I2a5533335151c4b292e85aea310adfdc44ab1e02
Remove async task from introspection, it will fail in case of
timeout due to node_timeout config
Set max_retries to 1 not to waste time and resources
In case we don't have info about nodes, something definitely went
wrong and let's fail it.
Change-Id: Ie4fbcc5fa0370832c0cf3eb5c5b363f380595db4
Since we allow to pass lists, we can't just use |join('').
In addition, using the multi-line support in YAML via the "|" creates
some issues when we want to use |join('\n'): it gets escaped, meaning we
end with a one-line content with some \n entries.
The present patch ensures that:
- generated content is still pushed in a fact to not lose time
- static content (lists) is properly treated and outputs correctly
Change-Id: I7e520035f24503e59840b34e5b2d9e9966cd6ca4
The expand function was failing to add the username and public keys to
the instances list. This change treats these arguments like other
defaults, and adds tests to confirm they're ending up in the instances
list.
This change also has a minor fix to the unprovision prompt validation
logic.
Change-Id: I603623511e4061e782a65d53a3118d211ea6e708
The SSH private key will normally be in $HOME/.ssh/id_rsa_tripleo
so if that key is present, then use it. This is a more reliable
location than "{{ playbook_dir }}/ssh_key", which will go away
with Mistral. This change is also backwards compatible as it
will fall back to using "{{ playbook_dir }}/ssh_key" in the case
that $HOME/.ssh/id_rsa_tripleo is missing. Covers one extra case
where CephAnsibleEnvironmentVariables/ANSIBLE_PRIVATE_KEY_FILE
might have been needed.
Also switches nodes_uuid_command to use ceph-ansible's ansible.cfg as
config-download may not always provide "{{ playbook_dir }}/ansible.cfg"
Change-Id: Ic7e20844877492d7c4b85f7579e90f6c9de355ec
Closes-Bug: #1868864
When a service is stopped using "service_kill" script and the
namespace where the container is running does not exist, the
container processi should be forced to stop from the root namespace.
A namespace where a process is running, can be deleted whitout
stopping the mentioned process. "ip netns identify <PID>" then
returns an empty string (root namespace).
This patch will prevent an endless loop in Neutron DHCP agent. As
reported in the related bug, when a DHCP agent is resync, the DHCP
helper (metadata proxy) is stopped. In case this process stop raises
an exception (for example if the namespace does not exist), schedules
again a resync, creating an endless loop.
Change-Id: I9bac918fcde80e6a2336bc3cf1e6972512298118
Closes-Bug: #1868607
If a container fails to start after many retries, the default logging of
the async_status tasks isn't great and it's hard to figure out what
container failed to start.
In this patch, we introduce a new filter that will read the
async_results and build a list of containers which failed to start
(failed to True) or did not finish to start (finished to 0); the
async_status ignores errors, but we fail a bit later after building that
list.
Change-Id: I5a2270130bdf5b9d781f4d81ec25c6ccf12fdc07
This adds a new module to upload templates to plan as a tar
file.
Change-Id: I7ac4c328ec7f4dd0fb4aa7495945fbc57feb4bbc
Depends-On: https://review.opendev.org/712599
Signed-off-by: Kevin Carter <kecarter@redhat.com>
Uses tripleo-common library to build image params and update
the plan.
Depends-On: https://review.opendev.org/712598
Change-Id: If8df9863a3b3f18e00767d095849b48eb08486fd
This change fixes the docs job to ensure we have access to development
versions of tripleo-common. This is being done because we have more
modules coming in which are using tripleo-common which may require
unreleased versions of the package when running tests. This change
adds tripleo-common as an upstream constraint which is only used in
the docs and molecule test scenarios.
Change-Id: Ib64307defe4d5a0e06ad862ab9f51d1da3d23312
Signed-off-by: Kevin Carter <kecarter@redhat.com>
This patch is filtering out the wrapper execution from the ps output
in the sync script. By doing this, it'll effectively detect when
the target process is not running and start it. Otherwise, there might
be cases where the process start is postponed until next iteration
of the sync script (1 minute) and it may be already too late.
This is causing tests to fail as the metadata service is not provisioned
in time for instances to fetch their SSH keys.
Change-Id: I530e257f343ffc551db9e984f9a27b20c397bfb1
Co-Authored-By: Jakub Libosvar <jlibosva@redhat.com>
Closes-Bug: #1868082
Signed-off-by: Daniel Alvarez <dalvarez@redhat.com>
Also extends tripleo_ceph_run_ansible molecule job to run for
changes to any tripleo_ceph_.* role
The issue initially tracked by bug 1867012 should have been fixed
by I9952a4df122c00c0163b7e79dab8a821e3feff06
Change-Id: I79e33ca2bf5d8ae8f6e1ac39dda7710e4e65fa3a
Add a new variable which would be used for strict images comparing
Use by default a "lite mode" which compares only image and tag.
Change-Id: I7592707c2a17654e521f6f136eabcb76c8152fba
- --systemd needs to be given with a string (default to true, so since
we used that argument we want true).
- Add fedora registry in the list of container registries to strip when
figuring out what image is deployed in podman_container (for
idempotency). This code should be improved in a future patch to stop
hardcoding these registries and find another way to figure out the
image name.
Change-Id: If0d4cc6590105808a07569b60877eb440f1dd6d1
Closes-Bug: #1867787
