Davlet Panech 861ecd49cf build-stx-images: disable cache when rebuilding ...

When we build application docker images if "docker build" fails,
we sleep a bit and retry. But some dockerfiles contain commands that
falsely succeed, causing failures later. That falsely successful command
gets cached by docker build cache, so the retry is ineffective.

HYPOTHETICAL EXAMPLE
====================

  FROM ubuntu:latest

  # At this point apt cache already exists (inherited from base image)

  # Lets say this fails because some of the repo URLs aren't responding
  # apt-get will print a warning, but "succeed" and keep using the old
  # cache
  RUN apt-get update

  # This fails, because package index cache is too old. But when we
  # retry the build, it resumes from here because the previous
  # "apt-get update" was seemingly successful and got cached by docker
  # build.
  RUN apt-get install SOME_PACKAGE

SOLUTION
========
Always disable the cache after the 1st build attempt fails.

TESTS
=====
Build the base image, a "loci" and a "docker"-type containers with an
artificial error in them. Make sure the second build attempt does not
use the cache, even when "--cache" is present on the command line.

Story: 2010055
Task: 52260

Signed-off-by: Davlet Panech <davlet.panech@windriver.com>
Change-Id: Ie251faaac8c2537bd2361cabe09800ddd1204af6

2025-05-28 15:57:57 -04:00

1.3 KiB

Raw Blame History

View Raw