dae3b33921
Historically, this build-helm-charts.sh script would rely on its
APP_NAME and APP_VERSION variables to write in the application
metadata.yaml. The APP_NAME would be used to override in build-time the
application final name [1] and the APP_VERSION would be initialized by
the internal "get_app_version" functional.
Now, after the AppFwk update on all applications Zuul jobs, the
metadata.yaml can no longer be missing neither the "app_name" or the
"app_version" keys/values [2].
So, the build-helm-charts.sh needs to be updated as follows:
1) Stop the blind write of APP_VERSION on metadata and use this
variable to override the metadata default value instead
2) Use APP_NAME (cli parsed argument) to override the default metadata
app_name, instead of only using it when the metadata is missing the
key/value.
NOTE: Since this script is currently always used with the "--app"
argument, this change should be safe. But if "--app" is not used, the
app_name will always fallback to "stx-openstack"
[1] 31aea8e88b
[2] https://review.opendev.org/c/starlingx/openstack-armada-app/+/903781
Closes-Bug: 2050825
TEST PLAN:
PASS - Build stx-openstack helm-charts tarball
PASS - system application-upload stx-openstack.tgz
PASS - system application-apply stx-openstack
Change-Id: Ibc37e1306ba93b911a66993f5e56c8e609291c2c
Signed-off-by: Thales Elero Cervi <thaleselero.cervi@windriver.com>