starlingx/test
Code Issues Proposed changes

Add test_dell_storage.py

Browse Source 
- Add test_dell_storage_PowerStore_procedure()
- Add marker lab_dell_storage
- Add dell-storage test resources files
- Modify helm keywords
- Modify kubectl_file_delete keywords
- Modify kubectl_exec_in_pods keywords
- Add SystemHelmChartAttributeModifyKeywords

Change-Id: I8aea53d300631b0e855ce0209534d5f73bae29af
Signed-off-by: ppeng <peng.peng@windriver.com>
This commit is contained in:
ppeng
2025-10-20 20:41:14 -04:00
parent 2f133194af
commit fc4d089ea2
10 changed files with 393 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
keywords/cloud_platform/system/helm/system_helm_chart_attribute_modify_keywords.py Normal file
View File

@@ -0,0 +1,34 @@
from framework.ssh.ssh_connection import SSHConnection
from keywords.base_keyword import BaseKeyword
from keywords.cloud_platform.command_wrappers import source_openrc
class SystemHelmChartAttributeModifyKeywords(BaseKeyword):
"""
This class contains all the keywords related to the 'system helm-chart-attribute-modify' commands.
"""
def __init__(self, ssh_connection: SSHConnection):
"""
Constructor
Args:
ssh_connection (SSHConnection): SSH connection object.
"""
self.ssh_connection = ssh_connection
def helm_chart_attribute_modify_enabled(self, enabled_value: str, app_name: str, chart_name: str, namespace: str):
"""
Modify helm chart attribute.
Args:
enabled_value (str): enabled_value to be modified
app_name (str): Name of the application
chart_name (str): Name of the chart
namespace (str): Namespace of chart overrides
"""
command = source_openrc(f"system helm-chart-attribute-modify --enabled {enabled_value} {app_name} {chart_name} {namespace}")
self.ssh_connection.send(command)
self.validate_success_return_code(self.ssh_connection)

12
keywords/cloud_platform/system/helm/system_helm_keywords.py
View File

@@ -1,3 +1,4 @@
from framework.ssh.ssh_connection import SSHConnection
from keywords.base_keyword import BaseKeyword
from keywords.cloud_platform.command_wrappers import source_openrc
@@ -6,15 +7,17 @@ class SystemHelmKeywords(BaseKeyword):
"""
This class contains all the keywords related to the 'system helm' commands.
"""
def __init__(self, ssh_connection):
def __init__(self, ssh_connection: SSHConnection):
"""
Constructor
Args:
ssh_connection:
ssh_connection (SSHConnection): SSH connection object.
"""
self.ssh_connection = ssh_connection
def helm_override_update(self, app_name: str, chart_name: str, namespace: str, values: str):
"""
Update helm chart user overrides.
@@ -26,7 +29,6 @@ class SystemHelmKeywords(BaseKeyword):
values (str): YAML file containing helm chart override values
"""
command = source_openrc(f"system helm-override-update {app_name} {chart_name} {namespace} --values {values}")
self.ssh_connection.send(command)
self.validate_success_return_code(self.ssh_connection)
self.validate_success_return_code(self.ssh_connection)

14
keywords/k8s/files/kubectl_file_delete_keywords.py
View File

@@ -1,3 +1,4 @@
from framework.ssh.ssh_connection import SSHConnection
from keywords.base_keyword import BaseKeyword
from keywords.k8s.k8s_command_wrapper import export_k8s_config
@@ -7,21 +8,24 @@ class KubectlFileDeleteKeywords(BaseKeyword):
Keywords for delete file resources
"""
def __init__(self, ssh_connection):
def __init__(self, ssh_connection: SSHConnection):
"""
Constructor
Args:
ssh_connection:
ssh_connection (SSHConnection): SSH connection object.
"""
self.ssh_connection = ssh_connection
def delete_resources(self, file_path: str) -> str:
"""
Deletes the dashboard resources
Args:
file_path (): the file path
Returns: the output
Args:
file_path (str): the file path
Returns:
str: the output
"""
output = self.ssh_connection.send(export_k8s_config(f"kubectl delete -f {file_path}"))

35
keywords/k8s/pods/kubectl_exec_in_pods_keywords.py
View File

@@ -1,3 +1,4 @@
from framework.ssh.ssh_connection import SSHConnection
from keywords.base_keyword import BaseKeyword
from keywords.k8s.k8s_command_wrapper import export_k8s_config
@@ -7,28 +8,46 @@ class KubectlExecInPodsKeywords(BaseKeyword):
Keywords for Exec in pods
"""
def __init__(self, ssh_connection):
def __init__(self, ssh_connection: SSHConnection):
"""
Constructor
Args:
ssh_connection:
ssh_connection (SSHConnection): the ssh connection
"""
self.ssh_connection = ssh_connection
def run_pod_exec_cmd(self, pod_name: str, cmd: str) -> str:
def run_pod_exec_cmd(
self,
pod_name: str,
cmd: str,
options: str = "",
) -> str:
"""
Executes the given command in the pod
Args:
pod_name (): the name of the pod
cmd (): the cmd to execute
Returns: the output
Args:
pod_name (str): the name of the pod
cmd (str): the cmd to execute
options (str): options
Returns:
str: the output
"""
output = self.ssh_connection.send(export_k8s_config(f"kubectl exec {pod_name} -- {cmd}"))
output = self.ssh_connection.send(export_k8s_config(f"kubectl exec {options} {pod_name} -- {cmd}"))
self.validate_success_return_code(self.ssh_connection)
return output
def exec_calicoctl_apply(self, pod_name: str, namespace: str, config_file: str):
"""
exec_calicoctl_apply
Args:
pod_name (str): the name of the pod
namespace (str): namespace
config_file (str): config file
"""
self.ssh_connection.send(export_k8s_config(f"kubectl exec {pod_name} -n {namespace} -i -- calicoctl apply -f {config_file}"))

9
resources/cloud_platform/storage/dell_storage/dell-storage-csi-powerstore-snapshot.yaml Normal file
View File

@@ -0,0 +1,9 @@
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshot
metadata:
name: csi-powerstore-pvc-snapshot
namespace: dell-storage
spec:
volumeSnapshotClassName: csi-powerstore-snapshot
source:
persistentVolumeClaimName: pvol0

13
resources/cloud_platform/storage/dell_storage/dell-storage-powerstoreOverrides.yaml Normal file
View File

@@ -0,0 +1,13 @@
storageClasses:
- name: csi-powerstore-iscsi
arrayID: PSc02e199014f4
fstype: ext4
secret:
arrays:
- globalID: PSc02e199014f4
username: "{{ username }}"
password: "{{ password }}"
endpoint: https://128.224.51.253/api/rest
isDefault: true
blockProtocol: "ISCSI"

53
resources/cloud_platform/storage/dell_storage/dell-storage-powerstoretest-snapshot.yaml Normal file
View File

@@ -0,0 +1,53 @@
---
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: pvol0-snap-restore
namespace: dell-storage
spec:
accessModes:
- ReadWriteOnce
volumeMode: Filesystem
dataSource:
name: csi-powerstore-pvc-snapshot
kind: VolumeSnapshot
apiGroup: snapshot.storage.k8s.io
resources:
requests:
storage: 8Gi
storageClassName: csi-powerstore-iscsi
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: powerstoretest-snapshot
namespace: dell-storage
---
kind: StatefulSet
apiVersion: apps/v1
metadata:
name: powerstoretest-snapshot-restore
namespace: dell-storage
spec:
serviceName: powerstoretest-snapshot
selector:
matchLabels:
app: powerstoretest-snapshot
template:
metadata:
labels:
app: powerstoretest-snapshot
spec:
serviceAccount: powerstoretest-snapshot
hostNetwork: true
containers:
- name: test
image: quay.io/centos/centos:latest
command: [ "/bin/sleep", "3600" ]
volumeMounts:
- mountPath: "/data0"
name: mydemo-pvc-pvol0
volumes:
- name: mydemo-pvc-pvol0
persistentVolumeClaim:
claimName: pvol0-snap-restore

49
resources/cloud_platform/storage/dell_storage/dell-storage-test-pod.yaml Normal file
View File

@@ -0,0 +1,49 @@
---
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: pvol0
namespace: dell-storage
spec:
accessModes:
- ReadWriteOnce
volumeMode: Filesystem
resources:
requests:
storage: 8Gi
storageClassName: csi-powerstore-iscsi
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: powerstoretest
namespace: dell-storage
---
kind: StatefulSet
apiVersion: apps/v1
metadata:
name: powerstoretest
namespace: dell-storage
spec:
serviceName: powerstoretest
selector:
matchLabels:
app: powerstoretest
template:
metadata:
labels:
app: powerstoretest
spec:
serviceAccount: powerstoretest
hostNetwork: true
containers:
- name: test
image: quay.io/centos/centos:latest
command: [ "/bin/sleep", "3600" ]
volumeMounts:
- mountPath: "/data0"
name: pvol0
volumes:
- name: pvol0
persistentVolumeClaim:
claimName: pvol0

191
testcases/cloud_platform/regression/storage/test_dell_storage.py Normal file
View File

@@ -0,0 +1,191 @@
from pytest import mark
from config.configuration_manager import ConfigurationManager
from framework.logging.automation_logger import get_logger
from framework.resources.resource_finder import get_stx_resource_path
from framework.validation.validation import validate_equals
from keywords.cloud_platform.ssh.lab_connection_keywords import LabConnectionKeywords
from keywords.cloud_platform.system.application.object.system_application_status_enum import SystemApplicationStatusEnum
from keywords.cloud_platform.system.application.system_application_apply_keywords import SystemApplicationApplyKeywords
from keywords.cloud_platform.system.application.system_application_list_keywords import SystemApplicationListKeywords
from keywords.cloud_platform.system.application.system_application_remove_keywords import SystemApplicationRemoveInput, SystemApplicationRemoveKeywords
from keywords.cloud_platform.system.helm.system_helm_chart_attribute_modify_keywords import SystemHelmChartAttributeModifyKeywords
from keywords.cloud_platform.system.helm.system_helm_override_keywords import SystemHelmOverrideKeywords
from keywords.files.file_keywords import FileKeywords
from keywords.files.yaml_keywords import YamlKeywords
from keywords.k8s.files.kubectl_file_apply_keywords import KubectlFileApplyKeywords
from keywords.k8s.files.kubectl_file_delete_keywords import KubectlFileDeleteKeywords
from keywords.k8s.pods.kubectl_create_pods_keywords import KubectlCreatePodsKeywords
from keywords.k8s.pods.kubectl_exec_in_pods_keywords import KubectlExecInPodsKeywords
from keywords.k8s.pods.kubectl_get_pods_keywords import KubectlGetPodsKeywords
from keywords.k8s.volumesnapshots.kubectl_get_volumesnapshots_keywords import KubectlGetVolumesnapshotsKeywords
@mark.p2
@mark.lab_dell_storage
def test_dell_storage_powerstore_procedure(request):
"""
Test case: This Test case is to test dell storage PowerStore procedure
Test Steps:
- Check if dell-storage was upload. Uploading dell-storage app.
- Check if only CSI-Powerstore is activated.
- Create powerstoreOverrides.yaml file to use as user-overrides (ISCSI)
- Set up the storage network from DM
- Update user-overrides for CSI-Powerstore chart.
- Apply dell-storage.
- Check if all pods are running.
- Create dell storage PVC and pod
- Write a test.txt file on test pod
- pod sync
- Create volumesnapshot
- Create snapshot pod
- Check whether test.txt is in snapshot pod
Teardown:
- Remove test stuff.
"""
ssh_connection = LabConnectionKeywords().get_active_controller_ssh()
dell_storage_app_name = "dell-storage"
namespace = "dell-storage"
get_logger().log_test_case_step(f"Check {dell_storage_app_name} app status.")
system_applications = SystemApplicationListKeywords(ssh_connection).get_system_application_list()
dell_storage_app_status = system_applications.get_application(dell_storage_app_name).get_status()
get_logger().log_info(f"{dell_storage_app_name} application is: {dell_storage_app_status}")
get_logger().log_test_case_step("Copy dell-storage test files to target.")
snapshot_pod_yaml = "dell-storage-powerstoretest-snapshot.yaml"
snapshot_yaml = "dell-storage-csi-powerstore-snapshot.yaml"
test_pod_yaml = "dell-storage-test-pod.yaml"
dell_storage_files = [snapshot_pod_yaml, snapshot_yaml, test_pod_yaml]
for file_name in dell_storage_files:
local_path = get_stx_resource_path(f"resources/cloud_platform/storage/dell_storage/{file_name}")
remote_yaml_path = f"/home/sysadmin/{file_name}"
FileKeywords(ssh_connection).upload_file(local_path, remote_yaml_path, overwrite=True)
def teardown():
kubectl_delete_keywords = KubectlFileDeleteKeywords(ssh_connection)
snapshot_pod_name = "powerstoretest-snapshot-restore-0"
get_logger().log_info(f"Check if test snapshot pod {snapshot_pod_name} is running")
snapshot_pod_status = KubectlGetPodsKeywords(ssh_connection).wait_for_pod_status(snapshot_pod_name, "Running", namespace)
if snapshot_pod_status is True:
get_logger().log_teardown_step(f"Clean up the snapshot pod {snapshot_pod_name}.")
kubectl_delete_keywords.delete_resources(f"/home/sysadmin/{snapshot_pod_yaml}")
snapshot_name = "csi-powerstore-pvc-snapshot"
get_logger().log_info(f"Check whether {snapshot_name} is ready to use")
snapshot_status = KubectlGetVolumesnapshotsKeywords(ssh_connection).wait_for_volumesnapshot_status(snapshot_name, "true", namespace)
if snapshot_status is True:
get_logger().log_teardown_step(f"Clean up the snapshot {snapshot_name}.")
kubectl_delete_keywords.delete_resources(f"/home/sysadmin/{snapshot_yaml}")
test_pod_name = "powerstoretest-0"
get_logger().log_info(f"Check if test {test_pod_name} pod is running")
pod_status = KubectlGetPodsKeywords(ssh_connection).wait_for_pod_status(test_pod_name, "Running", namespace)
if pod_status is True:
get_logger().log_teardown_step(f"Clean up the test pod {test_pod_name}.")
kubectl_delete_keywords.delete_resources(f"/home/sysadmin/{test_pod_yaml}")
get_logger().log_teardown_step("Remove test yaml files")
for file_name in dell_storage_files:
FileKeywords(ssh_connection).delete_file(f"/home/sysadmin/{file_name}")
request.addfinalizer(teardown)
if dell_storage_app_status == SystemApplicationStatusEnum.APPLY_FAILED:
get_logger().log_test_case_step(f"Remove {dell_storage_app_name} application.")
dell_storage_remove_input = SystemApplicationRemoveInput()
dell_storage_remove_input.set_app_name(dell_storage_app_name)
dell_storage_remove_input.set_force_removal(False)
dell_app_output = SystemApplicationRemoveKeywords(ssh_connection).system_application_remove(dell_storage_remove_input)
dell_storage_app_status = dell_app_output.get_system_application_object().get_status()
validate_equals(dell_storage_app_status, SystemApplicationStatusEnum.UPLOADED.value, "dell-storage removal status validation")
get_logger().log_info(f"{dell_storage_app_name} application is: {dell_storage_app_status}")
if dell_storage_app_status == SystemApplicationStatusEnum.UPLOADED.value:
chart_name = "csi-powerstore"
helm_chart_attribute_modify_keywords = SystemHelmChartAttributeModifyKeywords(ssh_connection)
get_logger().log_test_case_step(f"Set {dell_storage_app_name} helm override attributes is true")
helm_chart_attribute_modify_keywords.helm_chart_attribute_modify_enabled("true", dell_storage_app_name, chart_name, namespace)
get_logger().log_test_case_step("Update user-overrides for CSI-Powerstore chart")
yaml_file = "dell-storage-powerstoreOverrides.yaml"
rest_credentials = ConfigurationManager.get_lab_config().get_rest_credentials()
username = rest_credentials.get_user_name()
password = rest_credentials.get_password()
template_file = get_stx_resource_path(f"resources/cloud_platform/storage/dell_storage/{yaml_file}")
replacement_dictionary = {"username": username, "password": password}
remote_yaml = YamlKeywords(ssh_connection).generate_yaml_file_from_template(template_file, replacement_dictionary, yaml_file, "/home/sysadmin")
SystemHelmOverrideKeywords(ssh_connection).update_helm_override(remote_yaml, dell_storage_app_name, chart_name, namespace)
get_logger().log_test_case_step(f"Apply {dell_storage_app_name}.")
SystemApplicationApplyKeywords(ssh_connection).system_application_apply(dell_storage_app_name)
app_status_list = ["applied"]
SystemApplicationListKeywords(ssh_connection).validate_app_status_in_list(dell_storage_app_name, app_status_list, timeout=360, polling_sleep_time=10)
get_logger().log_info(f"{dell_storage_app_name} application is: applied")
get_logger().log_test_case_step("Check if all dell-storage pods are running")
pod_prefix = "csi-powerstore"
get_pod_obj = KubectlGetPodsKeywords(ssh_connection)
pod_names = get_pod_obj.get_pods(namespace=namespace).get_unique_pod_matching_prefix(starts_with=pod_prefix)
pod_status = get_pod_obj.wait_for_pod_status(pod_names, "Running", namespace)
validate_equals(pod_status, True, f"Verify {pod_prefix} pods are running")
get_logger().log_test_case_step("Create resources test pod via yaml")
yaml_path = "/home/sysadmin/dell-storage-test-pod.yaml"
kubectl_create_pods_keyword = KubectlCreatePodsKeywords(ssh_connection)
kubectl_create_pods_keyword.create_from_yaml(yaml_path)
pod_name = "powerstoretest-0"
get_logger().log_test_case_step(f"Check if test {pod_name} pod is running")
get_pod_obj = KubectlGetPodsKeywords(ssh_connection)
pod_status = get_pod_obj.wait_for_pod_status(pod_name, "Running", namespace)
validate_equals(pod_status, True, f"Verify {pod_name} pod is running")
get_logger().log_test_case_step(f"Creating text.txt file inside of {pod_name} pod")
kubeclt_exec_in_pods = KubectlExecInPodsKeywords(ssh_connection)
options = f"-it -n {namespace}"
cmd = "bash -c 'touch /data0/test.txt'"
kubeclt_exec_in_pods.run_pod_exec_cmd(pod_name, cmd, options=options)
validate_equals(ssh_connection.get_return_code(), 0, f"Write to {pod_name} pod success")
get_logger().log_info("sync pod")
cmd = "bash -c 'sync'"
kubeclt_exec_in_pods.run_pod_exec_cmd(pod_name, cmd, options=options)
validate_equals(ssh_connection.get_return_code(), 0, f"sync pod {pod_name} success")
get_logger().log_info("Check if test.txt is exist")
cmd = "bash -c 'test -f /data0/test.txt'"
kubeclt_exec_in_pods.run_pod_exec_cmd(pod_name, cmd, options=options)
validate_equals(ssh_connection.get_return_code(), 0, f"Access to {pod_name} pod success")
get_logger().log_test_case_step("Creating volumesnapshot via yaml")
yaml_path = "/home/sysadmin/dell-storage-csi-powerstore-snapshot.yaml"
KubectlFileApplyKeywords(ssh_connection=ssh_connection).apply_resource_from_yaml(yaml_path)
snapshot_name = "csi-powerstore-pvc-snapshot"
get_logger().log_test_case_step(f"Waiting for {snapshot_name} is ready to use")
expect_status = "true"
snapshot_status = KubectlGetVolumesnapshotsKeywords(ssh_connection).wait_for_volumesnapshot_status(snapshot_name, expect_status, namespace)
validate_equals(snapshot_status, True, "Verify snapshot is readt to use")
get_logger().log_test_case_step("Creating volume snapshot pod via yaml")
yaml_path = "/home/sysadmin/dell-storage-powerstoretest-snapshot.yaml"
KubectlFileApplyKeywords(ssh_connection=ssh_connection).apply_resource_from_yaml(yaml_path)
pod_name = "powerstoretest-snapshot-restore-0"
get_logger().log_test_case_step(f"Check if test snapshot {pod_name} pod is running")
get_pod_obj = KubectlGetPodsKeywords(ssh_connection)
pod_status = get_pod_obj.wait_for_pod_status(pod_name, "Running", namespace)
validate_equals(pod_status, True, f"Verify {pod_name} pod is running")
get_logger().log_test_case_step(f"Check whether volumesnapshot {pod_name} pod has test.txt file")
kubectl_exec_in_pods = KubectlExecInPodsKeywords(ssh_connection)
options = f"-it -n {namespace}"
cmd = "bash -c 'test -f /data0/test.txt'"
kubectl_exec_in_pods.run_pod_exec_cmd(pod_name, cmd, options=options)
validate_equals(ssh_connection.get_return_code(), 0, f"test.txt is on {pod_name} pod.")

1
testcases/pytest.ini
View File

@@ -38,6 +38,7 @@ markers=
lab_has_ptp_configuration_compute: mark tests that requred ptp_configuration_expectation_compute.json5
lab_rook_ceph: mark tests that require rook-ceph application applied
lab_is_aio: mark labs without worker nodes
lab_dell_storage: mark tests that require dell-storage application applied
#TODO: add 'lab_has_bmc_ipmi', 'lab_has_bmc_redfish', 'lab_has_bmc_dynamic', and 'lab_bmc_sensor'