Change to trigger jenkins + associated cleanup.

Change-Id: I1c5db6958ccc4ce1c3fbd891ce7276ac1c2bbea1

anvil/components/base_testing.py

@@ -60,7 +60,6 @@ class PythonTestingComponent(base.Component):
     def _get_test_command(self):
         # See: http://docs.openstack.org/developer/nova/devref/unit_tests.html
         # And: http://wiki.openstack.org/ProjectTestingInterface
-        app_dir = self.get_option('app_dir')
 
         cmd = ['coverage', 'run', '/usr/bin/nosetests']
         # See: $ man nosetests

anvil/components/configurators/quantum_plugins/__init__.py

@@ -14,8 +14,6 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-from anvil import shell as sh
-
 from anvil.components.configurators import base
 
 

anvil/packaging/yum.py

@@ -204,7 +204,6 @@ class YumDependencyHandler(base.DependencyHandler):
                 src_repo_files = []
             if not src_repo_files:
                 continue
-            src_repo_base_files = [sh.basename(f) for f in src_repo_files]
             LOG.info('Building %s RPM packages from their SRPMs for repo %s using %s jobs',
                      len(src_repo_files), self.SRC_REPOS[repo_name], self.jobs)
             makefile_name = sh.joinpths(self.deps_dir, "binary-%s.mk" % repo_name)

anvil/trace.py

@@ -201,7 +201,6 @@ class TraceReader(object):
 
     def packages_installed(self):
         lines = self.read()
-        pkgs_installed = list()
         pkg_list = list()
         for (cmd, action) in lines:
             if cmd == PKG_INSTALL and len(action):

docs/source/conf.py

@@ -1,4 +1,5 @@
-import sys, os
+import os
+import sys
 
 # If extensions (or modules to document with autodoc) are in another directory,
 # add these directories to sys.path here. If the directory is relative to the
@@ -9,7 +10,6 @@ sys.path.insert(0, os.path.abspath('./'))
 sys.path.insert(0, os.path.abspath('.'))
 
 from anvil import version as anvil_version
-from anvil import settings as anvil_settings
 
 # Supress warnings for docs that aren't used yet
 #unused_docs = [

test-requirements.txt

@@ -1 +1,5 @@
-pylint
+# Install bounded pep8/pyflakes first, then let flake8 install
+pep8==1.4.5
+pyflakes==0.7.2
+flake8==2.0
+pylint==0.25.2

tox.ini

@@ -0,0 +1,44 @@
+[tox]
+envlist = py26,py27,pep8
+
+[testenv]
+sitepackages = True
+setenv = VIRTUAL_ENV={envdir}
+         LANG=en_US.UTF-8
+         LANGUAGE=en_US:en
+         LC_ALL=C
+         NOSE_WITH_OPENSTACK=1
+         NOSE_OPENSTACK_COLOR=1
+         NOSE_OPENSTACK_RED=0.05
+         NOSE_OPENSTACK_YELLOW=0.025
+         NOSE_OPENSTACK_SHOW_ELAPSED=1
+         NOSE_OPENSTACK_STDOUT=1
+deps = -r{toxinidir}/requirements.txt
+       -r{toxinidir}/test-requirements.txt
+commands = nosetests {posargs}
+
+[tox:jenkins]
+sitepackages = True
+downloadcache = ~/cache/pip
+
+[testenv:pep8]
+sitepackages = False
+commands =
+  flake8 {posargs}
+
+[testenv:pylint]
+setenv = VIRTUAL_ENV={envdir}
+deps = -r{toxinidir}/test-requirements.txt
+       -r{toxinidir}/requirements.txt
+commands = pylint --rcfile=pylintrc anvil
+
+[testenv:cover]
+setenv = NOSE_WITH_COVERAGE=1
+
+[testenv:venv]
+commands = {posargs}
+
+[flake8]
+ignore = H402,H403,E121,E123,E124,E125,E126,E127,E128,E202,E501
+builtins = _
+exclude = .venv,.tox,dist,doc,*egg,.git,build,tools