Browse Source

Add bashate version >=0.5.0 as test dependency

We have a lots of long heredocs lines in the OCF scripts and older bashate
versions consider these as E006 violations.
From version 0.5.0, bashate doesn't check heredocs, so we specify this
version as a dependency.

In addition, this commit turns on E006 violation checking again.

Change-Id: I1ff675dd587239f0b7fd65c15b8df57a39a2c72b
Signed-off-by: Norbert Illes <norbert.e.illes@ericsson.com>
Norbert Illes 3 years ago
parent
commit
a0b55d3329
1 changed files with 6 additions and 11 deletions
  1. 6
    11
      tox.ini

+ 6
- 11
tox.ini View File

@@ -6,17 +6,12 @@ skipsdist = True
6 6
 whitelist_externals = bash
7 7
 
8 8
 [testenv:bashate]
9
-deps = bashate
10
-# NOTE: We ignore E006 violations (--ignore E006) only temporary.
11
-# The reason is that the currently available bashate versions (<=0.4.0) are
12
-# considering heredocs as normal code lines, hence lines longer than 79 columns
13
-# in these sections are also considered as E006 violations.
14
-# Commit 649c7dc79948 in bashate repository modifies bashate to ignore long
15
-# lines in heredocs, but currently there is no bashate release which contains
16
-# this commit.
17
-# TODO: After a new bashate released, '--ignore E006' should be deleted and the
18
-# newer bashate version should be specified as a dependency.
19
-commands = bash -c "bashate --ignore E006 --verbose {toxinidir}/ocf/*"
9
+# NOTE: We have a lots of long heredocs lines in the OCF scripts and older
10
+# bashate versions consider these as E006 violations.
11
+# From version 0.5.0, bashate doesn't check heredocs, so we specify this
12
+# version as a dependency.
13
+deps = bashate>=0.5.0
14
+commands = bash -c "bashate --verbose {toxinidir}/ocf/*"
20 15
 
21 16
 [testenv:syntax-check]
22 17
 setenv =

Loading…
Cancel
Save