A recent change in pep/pycodingchecks introduced new warnings as part of
the pep8 target that causes pep8 to fail now.
This patch fixes code that issued warnings W503,E731,E266,E402
Change-Id: I57c035440bd847193ea5f8a8078016fb9baa3c31
Commit I944021cbb6dfc950cff353e0ac908fa2b9c29bfe added a code to
avoid adding the mac learning + no security profiles for ENS ports
upon creation.
This patch does the same for the port update action
Change-Id: I287ccbc85c1a8ec201650b1d7b9ce9e603044815
The NSX will not accept 0.0.0.0/0 for remote and local IP
prefixes. This is changed internally to 'ANY'
The 'ANY' will only be internal. The API for the user will not
change, they will stell see the 0.0.0.0/0
Change-Id: I24adc9da9f52d17621117b46d8a535ccedf93227
When removing or changing the gateway of a router, we should not
set the edge-cluster id to None, and the NSX backend does not
support it.
Change-Id: I46e3ccdf1f3325ff0f6995b40146e26fe5a195d9
LBaaS forreign key migration adds several foreign keys, to enforce the
cleanup of stale NSXv DB objects when the LBaaS object is being deleted.
However, garbage rows may exist - and must be cleaned up prior to the
creation of the foreign key.
Change-Id: Ie6a0348df8b19a49525a1f2bad89f12370a3cd46
Since oslo.utils provide the ability to generate the uuid string,
and some others use oslo.utils[0] too. For consistency, this ps
replaces uuid.uuid4() with uuidutils.generate_uuid().
Change-Id: I9b3ebff137d0ffaed8c54031c8587c3bfc1acdce
Bug fix 2082554: handle the exception in neutron side for Qos
since its not supported from NSXT for ENS TZ
Change-Id: I8ca4c7d04286830ce785a60d7a24439b9a39d801
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
When neutron VPNaaS is not configured, the NSX plugins should
come up and work even if the neutron-vpnaas code is not installed.
This patch moves a constant the plugin needs to a file without
neutron_vpnaas imports so that the plugin doesn't have to import it.
Change-Id: I4c0893128fe8fd9c4797531bdb31d6407d18f034
When neutrion FWaaS is not configured, the NSX plugins should
come up and work even if the neutron-fwaas code is not installed.
This patch adds try/except on fwaas imports, and some mocks to
allow it.
Change-Id: I44895c1ded046668c56d559b47a69c44102d2f04
When the default TZ is a ENS VLAN TZ then we identify this this
is not a regular overlay network. It is a VLAN network. There was
a missing check for regular networks that were not provider
networks.
Change-Id: I9e4241fd2e1047ba14442babc4677efa4dcab3a5
This patch will allow users to filter ports according
to security_group supplied as a filter.
Code is for V and V3.
Change-Id: I20b4655cb188aae9d031fee20aea917268ebdf48
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
The VPNaaS uses a neutron port to allocate a local peer ip.
This port should not be updated or deleted by the neutron users.
Change-Id: I5c0e823ebd1fe79cb3ccdf175f760b16d5e2f562
a No-SNAT router subnets cannot overlap with VPN subnets becasue of the rotuer
advertisment.
This patch adds validations when changing the rotuer GW or addign an interface.
Also change the local endpoint port creation so this port will have a distingished
name and device id/owner and won't be queried by mistake.
Change-Id: I41faf97bae67ca85b38da3ade47894865eac8d51
The NSX currently does not support trunking for DHCP and
metadata ports. When a network and subnet are create we will
not create these if transparent VLAN is set on the network.
Change-Id: I7f8c4c81ba5074c58e61d31b08e0af66ef43accb
Commit I34d72b12289d6f6527bc114a32dac88281dd2cc4 added NO_DNAT rules
for each router interface. Those rules are not supported and unnecessary
for older NSX versions as VLAN networks were not supported with routers.
This commit adds the NO_DNAT rules only when supported.
Depends-on: I4d99193caac6940911cc071016359a1361428967
Change-Id: Ic0934979931e20645ee1d7d6b5968d7d3efc9c01
By default MAC learning is enabled on these networks. The patch
does the following:
1. prevent disabling this for TZ networks
2. marks the port mac learning as enabled on create
3. does some minor optimization in reading id the port is on a TZ
network
Change-Id: I944021cbb6dfc950cff353e0ac908fa2b9c29bfe
This reverts commit dec28f6d2b83700e96180b1b10b712799f0c76f7.
We needed to revert this as it broke the nsx cleanup utility
for NSX|V. This broke the CI.
Change-Id: Iffb05ab0c0bcb8c8184a0c821dece1e88cdd3fb3
- Support the case of empty neutron names
- Fix NSX local endpoints tags
- Support connection/service admin-state configuration
Depends-on: Ieb9da32b6f3b908dda7b4c5b99cb4ca2b79c9286
Change-Id: If5509fdcf3c496ad446921a3fb57b48deb6179f4
Instead of always trying to load all 3 plugins (v, t, dvs), the customer
can now configure those he wishes to support.
This way we will be quicker on neutron restart (and CIs) and avoid the errors
in the logs.
Change-Id: I9b41dc4002e7bd758dd46810763e70dbfc9202b0
Adds missing methods. Something changed witht he way in which
the callbacks were invoked which showed that we did not support
the correct methods.
Change-Id: I253ceee343d829923b874057603a32ccd8c662f6
Commit a96d83ece64d1ab662be8ee62eca15c3e3ab4c19 set the internal
security group description to be None. This should be a string.
Change-Id: Ia4b1e0cea3f4e1493e41bf1e97bcf3016e389bf9
Commit I123ae390bec489a931180a2e33f4bf7b1d51edb2 broke the extended
security group code, by removing the 'is_default' attribute from the
list of fields that should have been updated in the DB.
Not sure exactly why it broke us.
Change-Id: I891bc792e62ac90683ce8745f98a3139c9ffd3d9
When getting floating ips by port id, we should ignore the requesting
tenant since this is called via nova with a service tenant.
Change-Id: I557a9bb7071481e15c8be064a14cad583140991f
When the neutron network updated, some related NSX objects may need
be updated as well: DHCP server & port & metadata port
Depends-on: I07658bdaabe919f94dc877585206c76a1191f16c
Change-Id: Id563788af4b41aa360f8e87b28c310d1bab33feb
When a port is deleted, the plugin should delete its backend dhcp
static binding only if it is a compute port, since it is added
only for compute ports.
Note that the case of changing the device owner of the port was already
handled in the update-port code.
Calling the delete on non-compute ports issues a warning in the logs
We keep callign it anyway to avoid edge cases but will skip the warnings.
Change-Id: I5e76b14de0c2f2b844c7411bc325e46746fda54d
In Rocky we are going to start working on decoupling neutron db. This
will be a long effort, so from a vmware-nsx POV we can hopefully pick
away at it as we go.
This patch changes to use of class references to fully qulified class
names when defining ORM relationships. This allows us to remove a few
of the neutron db related imports in vmware-nsx.
Change-Id: I1df4cb3eec59488a5b35fac9f943bbfdbb44df63
