Update patch set 2
Patch Set 2: I would prefer that you didn't merge this (1 inline comment) One question about simplifying and possibly making parameters more clear. Patch-set: 2 Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Workflow=0
This commit is contained in:
parent
6d0ef8e575
commit
85b0954738
|
@ -0,0 +1,21 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "AAAATH//tXk\u003d",
|
||||||
|
"filename": "nodepool/nodepool.py",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 995,
|
||||||
|
"author": {
|
||||||
|
"id": 4146
|
||||||
|
},
|
||||||
|
"writtenOn": "2013-10-10T21:47:26Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Do we need reset provider and image here? Looking at the old image update command in nodepoolcmd.py the values passed in as provider and image appear to be identical to those retrieved here.",
|
||||||
|
"revId": "5695884bb399672a18626c729f031228c162e844",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue